From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60EBE2F2C for ; Tue, 8 Feb 2022 23:53:26 +0000 (UTC) Received: by mail-pf1-f174.google.com with SMTP id z13so1251781pfa.3 for ; Tue, 08 Feb 2022 15:53:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9yllLJXxvJNbb7TJ6F8GXcTe3gXNYnW6vmBXP6xHdmQ=; b=1TP2oV0hvpTVvUc38sU25Nq8P8dLloqnVrR1dLnL0k00RIz6cxvWF4JovZ1JHdh+Iq QjJ5AHaidFx9YmqNTrZ5h5qyJPKM/tziAB9DhO4YFzjPd5bpNTRb+YsjUwlfA7jtVsFK U7OdrJqAvGZ07hdSarMyxYyjKgkfa4xWh2cbsWw1St7pAb9nNM89cLwW6fNieqLKy8A0 lEy6S237O1zyS6B6nOobWB1RoW/2FsR/vn8FET1ptCNsh08iwgcstMONTlv3sghEwQq4 uOxijQbfhnxc35FRPR6EYrfjLYHOlXzLa9Vs6xBYs94IsyLrdPrgdUt8qrZhQDjGtN/K zJ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9yllLJXxvJNbb7TJ6F8GXcTe3gXNYnW6vmBXP6xHdmQ=; b=O3oCfnQmVarz3TAYrkw7fehUc7X57j+GYidQYXD63YVoZmMD2BQgmlk3jpTvsqSFOV 8mSIJhfQ2xR2kVVelddThGcVT6QHYO4+aU2/IgR75T7HcCHxT6JMUNabMTbW0f2a0OE8 813ovbiccjk9QaNzVmxqJ/bW2V2E3uPiKSvOBA/tO/g1hHFUmB9LXtL6f4Eh77IoQCdT 5TZrbF63Wc1lHddwmeN8jUGVeQOfxZOHwlL1Oy+C97kzpKdD6h8hsDD2lqZJvk03kf3k stEGsm2WoH9ChjsdlH5Z/4c295kTwD2UHWngTkBY5fq7V7R/wODvUTJlSS51+rtyl9G8 vHXA== X-Gm-Message-State: AOAM5323ZnUle6JPP5ZaKO4C1MA/Vm/DuGBGMvae5lssByKBsygZs7s3 elp3TUB6Fg52hibsIh0CRM1KwCycyV5w87aEugl5ww== X-Google-Smtp-Source: ABdhPJxeYY0PWIjCV0oL3qSXzPE/CqXZVnxQ/6hAd62TUxvblfYAlcQYEDEiHEyZHUJKW9dSv16xGL4Nt/VbJK9Vxe0= X-Received: by 2002:a63:8849:: with SMTP id l70mr2640980pgd.437.1644364405842; Tue, 08 Feb 2022 15:53:25 -0800 (PST) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-7-hch@lst.de> In-Reply-To: From: Dan Williams Date: Tue, 8 Feb 2022 15:53:14 -0800 Message-ID: Subject: Re: [PATCH 6/8] mm: don't include in To: Christoph Hellwig Cc: Andrew Morton , Felix Kuehling , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Jason Gunthorpe , Alistair Popple , Logan Gunthorpe , Ralph Campbell , Linux Kernel Mailing List , amd-gfx list , Maling list - DRI developers , nouveau@lists.freedesktop.org, Linux NVDIMM , Linux MM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 7, 2022 at 3:49 PM Dan Williams wrot= e: > > On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > > > Move the check for the actual pgmap types that need the free at refcoun= t > > one behavior into the out of line helper, and thus avoid the need to > > pull memremap.h into mm.h. > > Looks good to me assuming the compile bots agree. > > Reviewed-by: Dan Williams Yeah, same as Logan: mm/memcontrol.c: In function =E2=80=98get_mctgt_type=E2=80=99: mm/memcontrol.c:5724:29: error: implicit declaration of function =E2=80=98is_device_private_page=E2=80=99; did you mean =E2=80=98is_device_private_entry=E2=80=99? [-Werror=3Dimplicit-function-dec= laration] 5724 | if (is_device_private_page(page)) | ^~~~~~~~~~~~~~~~~~~~~~ | is_device_private_entry ...needs: diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d1e97a54ae53..0ac7515c85f9 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -62,6 +62,7 @@ #include #include #include +#include #include "internal.h" #include #include From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E823C433FE for ; Tue, 8 Feb 2022 23:53:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8AD3810E35E; Tue, 8 Feb 2022 23:53:27 +0000 (UTC) Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E2B610E35E for ; Tue, 8 Feb 2022 23:53:26 +0000 (UTC) Received: by mail-pf1-x433.google.com with SMTP id n32so1169376pfv.11 for ; Tue, 08 Feb 2022 15:53:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9yllLJXxvJNbb7TJ6F8GXcTe3gXNYnW6vmBXP6xHdmQ=; b=1TP2oV0hvpTVvUc38sU25Nq8P8dLloqnVrR1dLnL0k00RIz6cxvWF4JovZ1JHdh+Iq QjJ5AHaidFx9YmqNTrZ5h5qyJPKM/tziAB9DhO4YFzjPd5bpNTRb+YsjUwlfA7jtVsFK U7OdrJqAvGZ07hdSarMyxYyjKgkfa4xWh2cbsWw1St7pAb9nNM89cLwW6fNieqLKy8A0 lEy6S237O1zyS6B6nOobWB1RoW/2FsR/vn8FET1ptCNsh08iwgcstMONTlv3sghEwQq4 uOxijQbfhnxc35FRPR6EYrfjLYHOlXzLa9Vs6xBYs94IsyLrdPrgdUt8qrZhQDjGtN/K zJ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9yllLJXxvJNbb7TJ6F8GXcTe3gXNYnW6vmBXP6xHdmQ=; b=K2fl487TvC6dvDzEO1+QzsSUBdYWzm5PRBwz5xXDjyzbmYL9qURJKAsktYZp4OwsrB x1LoBttX8UzzjolMyOK12ymm+IAW5grvTdk7zVailZBEwK+nIM9htSxVYbRTXt9wsnBF 16lLJ3oCzLuK6LFe6wk9PQ/2Ja467wDu2ANmjCjVAakXZZssEH64WmDodg7LfOc2F10K my714CjL/SeuouaEm4yHvdh7c6KEmDkjUyJ9Lkd8/95G4uM7sPrI8Ay2nVUxAAPxkWxV cMaGLOjw7WJkoQ/77bPTthrK5XMVsEOjlLygHRrg5eQQukSyYh9EJf3sOq85+MZ05p4E LYdw== X-Gm-Message-State: AOAM532cfzkdLwImucqTywnrODwMG4jDRjr9K+CElZg3abiYHsWFnJLx uwoSPycTuKQA2AnFvAjFa7TIKSiMtk9JKesust/33A== X-Google-Smtp-Source: ABdhPJxeYY0PWIjCV0oL3qSXzPE/CqXZVnxQ/6hAd62TUxvblfYAlcQYEDEiHEyZHUJKW9dSv16xGL4Nt/VbJK9Vxe0= X-Received: by 2002:a63:8849:: with SMTP id l70mr2640980pgd.437.1644364405842; Tue, 08 Feb 2022 15:53:25 -0800 (PST) MIME-Version: 1.0 References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-7-hch@lst.de> In-Reply-To: From: Dan Williams Date: Tue, 8 Feb 2022 15:53:14 -0800 Message-ID: To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Nouveau] [PATCH 6/8] mm: don't include in X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Ralph Campbell , Alistair Popple , Maling list - DRI developers , Linux MM , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Jason Gunthorpe , Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Mon, Feb 7, 2022 at 3:49 PM Dan Williams wrot= e: > > On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > > > Move the check for the actual pgmap types that need the free at refcoun= t > > one behavior into the out of line helper, and thus avoid the need to > > pull memremap.h into mm.h. > > Looks good to me assuming the compile bots agree. > > Reviewed-by: Dan Williams Yeah, same as Logan: mm/memcontrol.c: In function =E2=80=98get_mctgt_type=E2=80=99: mm/memcontrol.c:5724:29: error: implicit declaration of function =E2=80=98is_device_private_page=E2=80=99; did you mean =E2=80=98is_device_private_entry=E2=80=99? [-Werror=3Dimplicit-function-dec= laration] 5724 | if (is_device_private_page(page)) | ^~~~~~~~~~~~~~~~~~~~~~ | is_device_private_entry ...needs: diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d1e97a54ae53..0ac7515c85f9 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -62,6 +62,7 @@ #include #include #include +#include #include "internal.h" #include #include From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3E27C433F5 for ; Tue, 8 Feb 2022 23:53:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0196910E34E; Tue, 8 Feb 2022 23:53:27 +0000 (UTC) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D58A10E34E for ; Tue, 8 Feb 2022 23:53:26 +0000 (UTC) Received: by mail-pf1-x42d.google.com with SMTP id i30so1189056pfk.8 for ; Tue, 08 Feb 2022 15:53:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9yllLJXxvJNbb7TJ6F8GXcTe3gXNYnW6vmBXP6xHdmQ=; b=1TP2oV0hvpTVvUc38sU25Nq8P8dLloqnVrR1dLnL0k00RIz6cxvWF4JovZ1JHdh+Iq QjJ5AHaidFx9YmqNTrZ5h5qyJPKM/tziAB9DhO4YFzjPd5bpNTRb+YsjUwlfA7jtVsFK U7OdrJqAvGZ07hdSarMyxYyjKgkfa4xWh2cbsWw1St7pAb9nNM89cLwW6fNieqLKy8A0 lEy6S237O1zyS6B6nOobWB1RoW/2FsR/vn8FET1ptCNsh08iwgcstMONTlv3sghEwQq4 uOxijQbfhnxc35FRPR6EYrfjLYHOlXzLa9Vs6xBYs94IsyLrdPrgdUt8qrZhQDjGtN/K zJ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9yllLJXxvJNbb7TJ6F8GXcTe3gXNYnW6vmBXP6xHdmQ=; b=fPnqa6l2/L8YGIl0kPgMfsen9tpRJKPVGn4n2Y+3qL8IdhG3Q0L/bQUIp5ADTNAqs3 yYNBN9Hna7/8dPGeEp8ocyAP4MVdWD7jS/Ho2b/ypiXf6YGRBU1x9WLiwurpwtvE9tJ8 U5DCvlMo7tSclFcShEp/pO6jTfyFp9d60ahW1riKRQeGnClOHk+mNXmbVmQZ3JBNKOP8 LczE3XwbWP1T6g4D1Rmt1XJ12H5tdoaAKs+Cb0PQDqzf6IEbCYgWudUyQ8yP7ZBLKsBx StLDv3Ost7TA9TbKfPofi19aBRz3USWsKHdSA3jvVNQ04pagNE3AdC9FqU1ObqFas1SP argQ== X-Gm-Message-State: AOAM53049q4PQ99aq0+HwxFyA9TkRfGmHauOBdGXWgpOFPNydWi6OXIh tsdIgCpqyjlBImZpLHxG2UjPTA1r3p7h45n5TTf9hA== X-Google-Smtp-Source: ABdhPJxeYY0PWIjCV0oL3qSXzPE/CqXZVnxQ/6hAd62TUxvblfYAlcQYEDEiHEyZHUJKW9dSv16xGL4Nt/VbJK9Vxe0= X-Received: by 2002:a63:8849:: with SMTP id l70mr2640980pgd.437.1644364405842; Tue, 08 Feb 2022 15:53:25 -0800 (PST) MIME-Version: 1.0 References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-7-hch@lst.de> In-Reply-To: From: Dan Williams Date: Tue, 8 Feb 2022 15:53:14 -0800 Message-ID: Subject: Re: [PATCH 6/8] mm: don't include in To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Ralph Campbell , Alistair Popple , Maling list - DRI developers , Karol Herbst , Linux MM , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Jason Gunthorpe , Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 7, 2022 at 3:49 PM Dan Williams wrot= e: > > On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > > > Move the check for the actual pgmap types that need the free at refcoun= t > > one behavior into the out of line helper, and thus avoid the need to > > pull memremap.h into mm.h. > > Looks good to me assuming the compile bots agree. > > Reviewed-by: Dan Williams Yeah, same as Logan: mm/memcontrol.c: In function =E2=80=98get_mctgt_type=E2=80=99: mm/memcontrol.c:5724:29: error: implicit declaration of function =E2=80=98is_device_private_page=E2=80=99; did you mean =E2=80=98is_device_private_entry=E2=80=99? [-Werror=3Dimplicit-function-dec= laration] 5724 | if (is_device_private_page(page)) | ^~~~~~~~~~~~~~~~~~~~~~ | is_device_private_entry ...needs: diff --git a/mm/memcontrol.c b/mm/memcontrol.c index d1e97a54ae53..0ac7515c85f9 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -62,6 +62,7 @@ #include #include #include +#include #include "internal.h" #include #include