From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C79ACC4363C for ; Wed, 7 Oct 2020 18:53:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B69D2173E for ; Wed, 7 Oct 2020 18:53:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="OFMCe2fA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728034AbgJGSx3 (ORCPT ); Wed, 7 Oct 2020 14:53:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbgJGSx2 (ORCPT ); Wed, 7 Oct 2020 14:53:28 -0400 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C7DFC061755 for ; Wed, 7 Oct 2020 11:53:28 -0700 (PDT) Received: by mail-ej1-x642.google.com with SMTP id ce10so4484241ejc.5 for ; Wed, 07 Oct 2020 11:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Rdre9jrmRp+/9/Y6RnzGhKU8N5YkFWVxUCgScft3zmU=; b=OFMCe2fA7ENUSEpSD1GFyoJSxPtUoTVyvWQ0nTA6wRiRt3SeCvMFuQ4bQDkdqLvM/7 /4/nQ7dvOnsthrJcz2BG09maCJRRIa5jdEe9z525GK+fBvhK5hoj+nY4WiqXn/+83XDh S1DVmBDjd9f3ZJU+WCAmMSwUQKH5R7gZLwd0KA+PNuih6PquuL2Ls5p5Cm2oRCwrTKVb gE//eAYWWZWyOQ2AUskNBJ2OZS/7EWasnYJSqWZCGBpRxgRegLepOnSxQGG0NnrrjdRF A9Ig8OW1Jz0RU6RtM10weytdPGoUgw+vqeM8WxFQLNtnef/z4F/K2lWeKD/tuNez14nM kYhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rdre9jrmRp+/9/Y6RnzGhKU8N5YkFWVxUCgScft3zmU=; b=pRGRbbhBa2zXUtMros8Jmr95CUJdyl6J/B5bi6y3oqGSETBEdSMaJNswarA6dfa0lt 6psTGaePkpt4ggz1deqCNiU9G1UJpwTyZHPuATCpxMM/jjbS4jwsqIR2j4TGjbsACpyW s/tnA2hXZpVX6FwY67xIw3kWGYgAKekbm70bX2aXerI7GgAyrN7aE/0UO5IJUq20FI/t ddgV3zSxUa01m7YrOJ0e4WU5rWOKrHMKnXqf7/Kp0N/1R14noDdYQ1Q9cGIXtWNQeGDL LTB+e0e9+Q34uSQNvM6Gh9Ym0tYl8IzL+t5DAuxSg/GrqrE1HxscbxqMVCBP29Mld4JZ B8+w== X-Gm-Message-State: AOAM532wyW1pDIZMn6aSeI0L3kLqc3GRrABEpfXidlHavV/wZ0olT1hC RGSIRGJw1S9Rgqzn8Mg30UGePPyAzp1LpP/SyyhBbA== X-Google-Smtp-Source: ABdhPJwTY40tXBoCGJvpR0HSEuM3/x/Oubwtv2I1I6/MuM6iQLQYOQ6MDqfOLpfRHPqQEuX+JWoAr7Ap/AtWi0NxOJA= X-Received: by 2002:a17:906:7e47:: with SMTP id z7mr4723987ejr.418.1602096807136; Wed, 07 Oct 2020 11:53:27 -0700 (PDT) MIME-Version: 1.0 References: <160197822988.7002.13716982099938468868.tip-bot2@tip-bot2> <20201007111447.GA23257@zn.tnic> <20201007164536.GJ5607@zn.tnic> <20201007170305.GK5607@zn.tnic> In-Reply-To: <20201007170305.GK5607@zn.tnic> From: Dan Williams Date: Wed, 7 Oct 2020 11:53:15 -0700 Message-ID: Subject: Re: [tip: ras/core] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}() To: Borislav Petkov Cc: linux-tip-commits@vger.kernel.org, Tony Luck , Michael Ellerman , stable , x86 , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 7, 2020 at 11:47 AM Borislav Petkov wrote: > > On Wed, Oct 07, 2020 at 06:45:36PM +0200, Borislav Petkov wrote: > > It doesn't look like it is toolchain-specific and in both cases, > > copy_mc_fragile's checksum is 0. > > > > SUSE Leap 15.1: > > > > Name : binutils > > Version : 2.32-lp151.3.6.1 > > > > $ grep -E "(copy_mc_fragile|copy_user_generic_unrolled)" Module.symvers > > 0x00000000 copy_mc_fragile vmlinux EXPORT_SYMBOL_GPL > > 0xecdcabd2 copy_user_generic_unrolled vmlinux EXPORT_SYMBOL > > > > debian testing: > > > > Package: binutils > > Version: 2.35-2 > > > > $ grep -E "(copy_mc_fragile|copy_user_generic_unrolled)" Module.symvers > > 0x00000000 copy_mc_fragile vmlinux EXPORT_SYMBOL_GPL > > 0xecdcabd2 copy_user_generic_unrolled vmlinux EXPORT_SYMBOL > > Ok, I think I have it: > > --- > From: Borislav Petkov > Date: Wed, 7 Oct 2020 18:55:35 +0200 > Subject: [PATCH] x86/mce: Allow for copy_mc_fragile symbol checksum to be generated > > Add asm/mce.h to asm/asm-prototypes.h so that that asm symbol's checksum > can be generated in order to support CONFIG_MODVERSIONS with it and fix: > > WARNING: modpost: EXPORT symbol "copy_mc_fragile" [vmlinux] version \ > generation failed, symbol will not be versioned. > > For reference see: > > 4efca4ed05cb ("kbuild: modversions for EXPORT_SYMBOL() for asm") > 334bb7738764 ("x86/kbuild: enable modversions for symbols exported from asm") Oh nice! I just sent a patch [1] to fix this up as well, but mine goes after minimizing when it is exported, I think perhaps both are needed. http://lore.kernel.org/r/160209507277.2768223.9933672492157583642.stgit@dwillia2-desk3.amr.corp.intel.com