From: Dan Williams <dan.j.williams@intel.com>
To: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 2/5] dax: fix offset to physical address translation
Date: Fri, 9 Sep 2016 18:00:14 -0700 [thread overview]
Message-ID: <CAPcyv4jqsPuOMMbkjUtNSxd+vJXaoyJXvX_ttGfS12bCyRDtfg@mail.gmail.com> (raw)
In-Reply-To: <147318057109.30325.17721163157375660986.stgit@dwillia2-desk3.amr.corp.intel.com>
On Tue, Sep 6, 2016 at 9:49 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> In pgoff_to_phys() 'pgoff' is already relative to base of the dax
> device, so we only need to compare if the current offset is within the
> current resource extent. Otherwise, we are double accounting the
> resource start offset when translating pgoff to a physical address.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
On second look this results in the exact same translation, correct in
both cases. This is also confirmed by a new ndctl unit test that does
data verification by writing through a /dev/pmem device and the
verifying via a /dev/dax device associated with the same namespace, so
I'm dropping this patch.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>
Cc: Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 2/5] dax: fix offset to physical address translation
Date: Fri, 9 Sep 2016 18:00:14 -0700 [thread overview]
Message-ID: <CAPcyv4jqsPuOMMbkjUtNSxd+vJXaoyJXvX_ttGfS12bCyRDtfg@mail.gmail.com> (raw)
In-Reply-To: <147318057109.30325.17721163157375660986.stgit@dwillia2-desk3.amr.corp.intel.com>
On Tue, Sep 6, 2016 at 9:49 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> In pgoff_to_phys() 'pgoff' is already relative to base of the dax
> device, so we only need to compare if the current offset is within the
> current resource extent. Otherwise, we are double accounting the
> resource start offset when translating pgoff to a physical address.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
On second look this results in the exact same translation, correct in
both cases. This is also confirmed by a new ndctl unit test that does
data verification by writing through a /dev/pmem device and the
verifying via a /dev/dax device associated with the same namespace, so
I'm dropping this patch.
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 2/5] dax: fix offset to physical address translation
Date: Fri, 9 Sep 2016 18:00:14 -0700 [thread overview]
Message-ID: <CAPcyv4jqsPuOMMbkjUtNSxd+vJXaoyJXvX_ttGfS12bCyRDtfg@mail.gmail.com> (raw)
In-Reply-To: <147318057109.30325.17721163157375660986.stgit@dwillia2-desk3.amr.corp.intel.com>
On Tue, Sep 6, 2016 at 9:49 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> In pgoff_to_phys() 'pgoff' is already relative to base of the dax
> device, so we only need to compare if the current offset is within the
> current resource extent. Otherwise, we are double accounting the
> resource start offset when translating pgoff to a physical address.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
On second look this results in the exact same translation, correct in
both cases. This is also confirmed by a new ndctl unit test that does
data verification by writing through a /dev/pmem device and the
verifying via a /dev/dax device associated with the same namespace, so
I'm dropping this patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-10 1:00 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 16:49 [PATCH 0/5] device-dax and huge-page dax fixes for 4.8-rc6 Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 16:49 ` [PATCH 1/5] dax: fix mapping size check Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 16:49 ` [PATCH 2/5] dax: fix offset to physical address translation Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-10 1:00 ` Dan Williams [this message]
2016-09-10 1:00 ` Dan Williams
2016-09-10 1:00 ` Dan Williams
2016-09-06 16:49 ` [PATCH 3/5] mm: fix show_smap() for zone_device-pmd ranges Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 20:16 ` Andrew Morton
2016-09-06 20:16 ` Andrew Morton
2016-09-06 16:49 ` [PATCH 4/5] mm: fix cache mode of dax pmd mappings Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 17:20 ` Matthew Wilcox
2016-09-06 17:20 ` Matthew Wilcox
2016-09-06 17:32 ` Dan Williams
2016-09-06 17:32 ` Dan Williams
2016-09-06 17:32 ` Dan Williams
[not found] ` <147318058165.30325.16762406881120129093.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-06 20:17 ` Andrew Morton
2016-09-06 20:17 ` Andrew Morton
2016-09-06 20:17 ` Andrew Morton
[not found] ` <20160906131756.6b6c6315b7dfba3a9d5f233a-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2016-09-06 21:52 ` Dan Williams
2016-09-06 21:52 ` Dan Williams
2016-09-06 21:52 ` Dan Williams
[not found] ` <CAPcyv4hjdPWxdY+UTKVstiLZ7r4oOCa+h+Hd+kzS+wJZidzCjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-07 19:39 ` Kani, Toshimitsu
2016-09-07 19:39 ` Kani, Toshimitsu
[not found] ` <1473277101.2092.39.camel-ZPxbGqLxI0U@public.gmane.org>
2016-09-07 19:45 ` Dan Williams
2016-09-07 19:45 ` Dan Williams
2016-09-07 19:45 ` Dan Williams
2016-09-06 16:49 ` [PATCH 5/5] mm: cleanup pfn_t usage in track_pfn_insert() Dan Williams
2016-09-06 16:49 ` Dan Williams
2016-09-06 16:49 ` Dan Williams
[not found] ` <147318058712.30325.12749411762275637099.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-06 20:20 ` Andrew Morton
2016-09-06 20:20 ` Andrew Morton
2016-09-06 20:20 ` Andrew Morton
[not found] ` <20160906132001.cd465767fa9844ddeb630cc4-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2016-09-06 20:30 ` Dan Williams
2016-09-06 20:30 ` Dan Williams
2016-09-06 20:30 ` Dan Williams
2016-09-07 5:12 ` Anshuman Khandual
2016-09-07 5:12 ` Anshuman Khandual
2016-09-07 5:12 ` Anshuman Khandual
2016-09-07 15:47 ` Dan Williams
2016-09-07 15:47 ` Dan Williams
2016-09-07 15:47 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jqsPuOMMbkjUtNSxd+vJXaoyJXvX_ttGfS12bCyRDtfg@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.