From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-x230.google.com (mail-yw0-x230.google.com [IPv6:2607:f8b0:4002:c05::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DCF6921D091AC for ; Wed, 26 Jul 2017 10:29:46 -0700 (PDT) Received: by mail-yw0-x230.google.com with SMTP id l82so33903388ywc.2 for ; Wed, 26 Jul 2017 10:31:49 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170726171952.frohvqpekfx4iefn@gmail.com> References: <150102217021.2258.1380624380896006.stgit@dwillia2-desk3.amr.corp.intel.com> <150102218643.2258.15362632812220627446.stgit@dwillia2-desk3.amr.corp.intel.com> <20170725235512.GC23846@kernel.org> <20170726112935.a4ztsb6yke7bhsvo@gmail.com> <20170726171952.frohvqpekfx4iefn@gmail.com> From: Dan Williams Date: Wed, 26 Jul 2017 10:31:48 -0700 Message-ID: Subject: Re: [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Ingo Molnar Cc: "linux-nvdimm@lists.01.org" , Peter Zijlstra , "linux-kernel@vger.kernel.org" , Arnaldo Carvalho de Melo , Alexander Shishkin , Ingo Molnar List-ID: On Wed, Jul 26, 2017 at 10:19 AM, Ingo Molnar wrote: > > * Dan Williams wrote: > >> On Wed, Jul 26, 2017 at 4:29 AM, Ingo Molnar wrote: >> > >> > * Dan Williams wrote: >> > >> >> On Tue, Jul 25, 2017 at 4:55 PM, Arnaldo Carvalho de Melo >> >> wrote: >> >> > Em Tue, Jul 25, 2017 at 03:36:26PM -0700, Dan Williams escreveu: >> >> >> Replace the ccan implementation of list primitives, bitmap helpers and >> >> >> small utility macros with the common definitions available in >> >> >> tool/include/linux. >> >> > >> >> > You should first add what you need in separate patches, paving the way >> >> > to then use it, and some stuff are already there, see below: >> >> >> >> Ok, I'll break out those changes separately. >> > >> > BTW., another general observation I have is that ndctl uses autotools - while perf >> > uses its own build system, some of which is abstracted out into tools/build/ and >> > reused by other tooling projects as well. >> > >> > I despise autotools with a passion, it's slow, bloated, and encourages all sorts >> > of bad API/ABI practices that plagues many OSS projects. I know that Linus >> > explicitly did a Makefile based build system for Git for (I think) similar >> > reasons. >> > >> > It might be a good idea to not let autotools into the kernel tooling tree, not >> > because ndctl's use of autotools is bad in any fashion (it appears to be a fairly >> > straightforward use), but to generally encourage good API/ABI practices in our >> > tooling space, and to encourage enhancements to the tools/build/ infrastructure. >> >> That's a fair point. Regardless, autotools will be in the git history, >> but if you'd like to see the final merge product eliminate its use, I >> can't really argue otherwise. I was originally not concerned because >> tools/usb/usbip/ was an existing in tree autotools user. In any event >> if you want the autotools removal to be done out-of-tree I'll need to >> put this effort on the back burner until 4.15. > > So that was another thing I wanted to suggest: why not import the current ndctl > version as a single commit? > > I had a quick look, and there's quite a few of commits in the ndctl history that > don't conform to kernel standards, such as: > > ce881c1e78f6: ndctl: seed tracking > > which doesn't have any Signed-off-by tags. > > There's also commits with ambiguous titles that would be confusing in the kernel > context - for example: > > 796b6f373dec: clarify copyright and license information > > ... which on the surface could be misunderstood as something talking about the > kernel copyright ... > > Or: > > e38bd36e5d0a: completion: updates for file name completion > > which I could initially mistake for a commit about scheduler completions ;-) > > Or: > > 2ad6a39c9ae9: Fix attribute sizes to match NFIT 0.8s2 > cc7cb44385d3: Import initial infrastructure > > etc. > > I suppose all that could be corrected, SOBs added, titles clarified and prefixed > with tools/ndctl, but then it wouldn't really be unmodified history anymore, > right? > > At that point we might as well do a clean start - and not import ~500 extra > commits into the kernel tree? I think keeping the history is worth it, similar reasoning to why we kept the btrfs history. Also, since the history is linear and already rewritten by 'git filter-branch' to move everything to tools/ndctl/ it wouldn't be that much more work to go clean up these few commits that are problematic. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751524AbdGZRbv (ORCPT ); Wed, 26 Jul 2017 13:31:51 -0400 Received: from mail-yw0-f176.google.com ([209.85.161.176]:36526 "EHLO mail-yw0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750996AbdGZRbt (ORCPT ); Wed, 26 Jul 2017 13:31:49 -0400 MIME-Version: 1.0 In-Reply-To: <20170726171952.frohvqpekfx4iefn@gmail.com> References: <150102217021.2258.1380624380896006.stgit@dwillia2-desk3.amr.corp.intel.com> <150102218643.2258.15362632812220627446.stgit@dwillia2-desk3.amr.corp.intel.com> <20170725235512.GC23846@kernel.org> <20170726112935.a4ztsb6yke7bhsvo@gmail.com> <20170726171952.frohvqpekfx4iefn@gmail.com> From: Dan Williams Date: Wed, 26 Jul 2017 10:31:48 -0700 Message-ID: Subject: Re: [PATCH 3/4] ndctl: switch to tools/include/linux/{kernel, list, bitmap}.h To: Ingo Molnar Cc: Arnaldo Carvalho de Melo , "linux-nvdimm@lists.01.org" , Peter Zijlstra , Alexander Shishkin , Ingo Molnar , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 26, 2017 at 10:19 AM, Ingo Molnar wrote: > > * Dan Williams wrote: > >> On Wed, Jul 26, 2017 at 4:29 AM, Ingo Molnar wrote: >> > >> > * Dan Williams wrote: >> > >> >> On Tue, Jul 25, 2017 at 4:55 PM, Arnaldo Carvalho de Melo >> >> wrote: >> >> > Em Tue, Jul 25, 2017 at 03:36:26PM -0700, Dan Williams escreveu: >> >> >> Replace the ccan implementation of list primitives, bitmap helpers and >> >> >> small utility macros with the common definitions available in >> >> >> tool/include/linux. >> >> > >> >> > You should first add what you need in separate patches, paving the way >> >> > to then use it, and some stuff are already there, see below: >> >> >> >> Ok, I'll break out those changes separately. >> > >> > BTW., another general observation I have is that ndctl uses autotools - while perf >> > uses its own build system, some of which is abstracted out into tools/build/ and >> > reused by other tooling projects as well. >> > >> > I despise autotools with a passion, it's slow, bloated, and encourages all sorts >> > of bad API/ABI practices that plagues many OSS projects. I know that Linus >> > explicitly did a Makefile based build system for Git for (I think) similar >> > reasons. >> > >> > It might be a good idea to not let autotools into the kernel tooling tree, not >> > because ndctl's use of autotools is bad in any fashion (it appears to be a fairly >> > straightforward use), but to generally encourage good API/ABI practices in our >> > tooling space, and to encourage enhancements to the tools/build/ infrastructure. >> >> That's a fair point. Regardless, autotools will be in the git history, >> but if you'd like to see the final merge product eliminate its use, I >> can't really argue otherwise. I was originally not concerned because >> tools/usb/usbip/ was an existing in tree autotools user. In any event >> if you want the autotools removal to be done out-of-tree I'll need to >> put this effort on the back burner until 4.15. > > So that was another thing I wanted to suggest: why not import the current ndctl > version as a single commit? > > I had a quick look, and there's quite a few of commits in the ndctl history that > don't conform to kernel standards, such as: > > ce881c1e78f6: ndctl: seed tracking > > which doesn't have any Signed-off-by tags. > > There's also commits with ambiguous titles that would be confusing in the kernel > context - for example: > > 796b6f373dec: clarify copyright and license information > > ... which on the surface could be misunderstood as something talking about the > kernel copyright ... > > Or: > > e38bd36e5d0a: completion: updates for file name completion > > which I could initially mistake for a commit about scheduler completions ;-) > > Or: > > 2ad6a39c9ae9: Fix attribute sizes to match NFIT 0.8s2 > cc7cb44385d3: Import initial infrastructure > > etc. > > I suppose all that could be corrected, SOBs added, titles clarified and prefixed > with tools/ndctl, but then it wouldn't really be unmodified history anymore, > right? > > At that point we might as well do a clean start - and not import ~500 extra > commits into the kernel tree? I think keeping the history is worth it, similar reasoning to why we kept the btrfs history. Also, since the history is linear and already rewritten by 'git filter-branch' to move everything to tools/ndctl/ it wouldn't be that much more work to go clean up these few commits that are problematic.