Re: [PATCHv4,2/5] mailbox: Introduce framework for mailbox

From: Markus Mayer <markus.mayer@linaro.org>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Linux Kernel Mailing list <linux-kernel@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>, Suman Anna <s-anna@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	"Omar Ramirez Luna (omar.ramirez@copitl.com)" 
	<omar.ramirez@copitl.com>, Loic Pallardy <loic.pallardy@st.com>,
	LeyFoon Tan <lftan.linux@gmail.com>,
	Craig McGeachie <slapdau@yahoo.com.au>,
	Courtney Cavin <courtney.cavin@sonymobile.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Rob Herring <robherring2@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Josh Cartwright <joshc@codeaurora.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Kumar Gala <galak@codeaurora.org>,
	Girish K S <ks.giri@samsung.com>
Subject: Re: [PATCHv4,2/5] mailbox: Introduce framework for mailbox
Date: Mon, 31 Mar 2014 15:05:05 -0700	[thread overview]
Message-ID: <CAPdLdqkDCYS7WsgkofJt78ztGTixQ9P+gVhkJZxteQL-YvwbKQ@mail.gmail.com> (raw)
In-Reply-To: <CABb+yY3N0e3yTf=+2aqM0gWM8xcnybBWNSJxGezUC5uckAQBGg@mail.gmail.com>

On 28 March 2014 20:54, Jassi Brar <jassisinghbrar@gmail.com> wrote:
> On Sat, Mar 29, 2014 at 3:38 AM, Markus Mayer <markus.mayer@linaro.org> wrote:
>
> .....
>
>>> +int mbox_send_message(struct mbox_chan *chan, void *mssg)
>>> +{
>>> +     int t;
>>> +
>>> +     if (!chan || !chan->cl)
>>> +             return -EINVAL;
>>> +
>>> +     t = _add_to_rbuf(chan, mssg);
>>> +     if (t < 0) {
>>> +             pr_err("Try increasing MBOX_TX_QUEUE_LEN\n");
>>> +             return t;
>>> +     }
>>> +
>>> +     _msg_submit(chan);
>>> +
>>> +     if (chan->txdone_method == TXDONE_BY_POLL)
>>> +             poll_txdone((unsigned long)chan->con);
>>
>> Wouldn't it be cleaner to use
>>                 poll_txdone((unsigned long)&chan->con);
>> ?
>>
> Here's how we use it ...
>
> static void poll_txdone(unsigned long data)
> {
>      struct mbox_con *con = (struct mbox_con *)data;
>      .....
> }
>
> To me, unnecessarily passing a pointer to a pointer seems unclean.

You are right. I didn't look closely enough.

Regards,
-Markus