From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48591)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <matthew.garrett@coreos.com>) id 1bWqSx-0004E4-Hy
	for qemu-devel@nongnu.org; Mon, 08 Aug 2016 15:44:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <matthew.garrett@coreos.com>) id 1bWqSv-0004Yz-K3
	for qemu-devel@nongnu.org; Mon, 08 Aug 2016 15:44:02 -0400
Received: from mail-yw0-x22c.google.com ([2607:f8b0:4002:c05::22c]:36045)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <matthew.garrett@coreos.com>) id 1bWqSu-0004Wq-Ds
	for qemu-devel@nongnu.org; Mon, 08 Aug 2016 15:44:01 -0400
Received: by mail-yw0-x22c.google.com with SMTP id u134so311371727ywg.3
	for <qemu-devel@nongnu.org>; Mon, 08 Aug 2016 12:43:58 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <OFA12AAB00.DF53D2ED-ON00258007.00155F53-85258007.0015AE85@notes.na.collabserv.com>
References: <1466716148-10655-1-git-send-email-mjg59@coreos.com>
	<1470439032-20995-1-git-send-email-mjg59@coreos.com>
	<OFA12AAB00.DF53D2ED-ON00258007.00155F53-85258007.0015AE85@notes.na.collabserv.com>
From: Matthew Garrett <mjg59@coreos.com>
Date: Mon, 8 Aug 2016 12:43:57 -0700
Message-ID: <CAPeXnHsmtcNfqV_URsnMSu7P4vXAcyZj_sppN19w5ommS3wQpA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH V2] hw/misc: Add simple measurement hardware
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Berger <stefanb@us.ibm.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu-devel@nongnu.org

On Fri, Aug 5, 2016 at 8:56 PM, Stefan Berger <stefanb@us.ibm.com> wrote:
> Matthew Garrett <mjg59@coreos.com> wrote on 08/05/2016 07:17:12 PM:
>> This version of the implementation depends on port io, but if there's
>> interest I'll add mmio as well.
>
> Port io is x86 specific, right? I don't think it should stay an x86 specific
> device.

Not strictly, there are other architectures that implement it. But
yes, most other platforms will want MMIO support. The intent is
certainly to add that.

>> -    if (misc.tpm_version != TPM_VERSION_UNSPEC) {
>> +    if (misc.tpm_version != TPM_VERSION_UNSPEC ||
>> misc.measurements_io_base) {
>>          acpi_add_table(table_offsets, tables_blob);
>>          build_tpm_tcpa(tables_blob, tables->linker, tables->tcpalog);
>>
>
> If this device is hitchhiking on the TPM's ACPI tables, then are you also
> making this device mutually exclusive with the TPM ? Of not please do so.

I'll look into the best way to do that.