From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 502C2C4363A for ; Tue, 27 Oct 2020 06:35:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A49F2080A for ; Tue, 27 Oct 2020 06:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.b="ffXTeo09" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbgJ0Ge6 (ORCPT ); Tue, 27 Oct 2020 02:34:58 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:33405 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725964AbgJ0Ge6 (ORCPT ); Tue, 27 Oct 2020 02:34:58 -0400 Received: by mail-oi1-f195.google.com with SMTP id s21so251633oij.0 for ; Mon, 26 Oct 2020 23:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4OLZkKXHEUBY7DeEd3iPlPLN0NQpAEg6enu9STnS7gk=; b=ffXTeo09Myz4E6soRpWj2Esy56EmQrebOlb3RE7TmmoT1uSQrgSHt8qModdv583VB5 ylDwsYc9wCjqHA/1Ctvj8kdagxf9BDstCFics+g9YAnZ4Ss2k8648LnNtoLoQQ+kt23a I5ddwt0WoVvSq9ZP4Ceh4ZIIFO7IkCXVBzImlnUqpATQX34dG2IJTArM3oibnMy9D2OF 0xHJTwrm6pEQ7P57eQrxKkHgO4e7lRLMAiSj+v3uifIXSW7n577GqyJaAGk6jUVXLACv bk+POnX8MtadcvZjfCCIfjekBz2Bx5DUnkT3PIRnYV3QzIgvB56+T3IBYNXxO++8G3Zu n54Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4OLZkKXHEUBY7DeEd3iPlPLN0NQpAEg6enu9STnS7gk=; b=m8Uq29IZYiI65JNKJNGVPclQ6RiMOlgf/tuZF0yXCRaO3UFQh3Y0LryThVCg5QIIOC IjsCidzgO23rd5/b/ZilGfdgkw9uaFgjndF4m5h1/8VHwGsWzptInmTEOfdfLQaDw533 Z/y+jPhzBaLMJmBDMQ4eyovN4fa+mHDHY42jIbukxKRhzCoxcLygljCimdTWzsBz74KB 1p0WbQwsu73MbAqUF3bECNQIy5b+jwkrhtb6d9YkDJq1rIzpfto1/Xl/sog2EQPXzx35 zfFoqNCIBK/eLW3P5olQ9VRSuqIjBg+ckj7IOo0+KtwUsGV4YoTtk+MjLYoLVU57PMur drYg== X-Gm-Message-State: AOAM531bUfHq6CvTsBypaU3ik+IvRPTOjiEKToXDFO8YiFsTuTgtX4Qy jEMWHmdrOgvH8N+PxphS9VtRh3eApjWb3JddC6IxzA== X-Google-Smtp-Source: ABdhPJx4N+GAZxZ3jOHWvgwLwSSRNUrBUdQfoPGcM/X3gXA5Q7shoWCmNyp4K61V0o+weJRPWgJvvBer3oP7qIR+Oms= X-Received: by 2002:aca:b644:: with SMTP id g65mr404581oif.164.1603780497113; Mon, 26 Oct 2020 23:34:57 -0700 (PDT) MIME-Version: 1.0 References: <3ede1c31-9436-a8ec-b7cd-65cee5fa23fc@pengutronix.de> <975a3598-c229-0b9a-df95-c9647f138a3a@hartkopp.net> <20201025105808.2pltif74at3xwtjd@hardanger.blackshift.org> <68846197-98dc-b991-1ec8-a477ceb8d614@posteo.de> <715b3c3b-dbbc-688c-9757-578455c3a607@pengutronix.de> <0667516a-525e-9c4e-ec7a-e4d8a188c338@posteo.de> <92dd7044-8f0d-154b-eb04-8cec1b572dd2@pengutronix.de> <2a1ddec7-ca28-ae44-dc06-f80f0017bf1f@pengutronix.de> In-Reply-To: From: Drew Fustini Date: Tue, 27 Oct 2020 01:35:03 -0500 Message-ID: Subject: Re: mcp251xfd on RPi 5.4 downstream To: Marc Kleine-Budde Cc: Patrick Menschel , Oliver Hartkopp , linux-can@vger.kernel.org, Josh S Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On Mon, Oct 26, 2020 at 9:22 PM Drew Fustini wrote: > > Thank you the feedback. > > I think it may be any issue with spi interface and/or chip select config. > > [ 6.812079] DEBUG mcp251xfd mcp251xfd_probe(): ENTER > [ 6.812174] mcp251xfd spi0.0: DEBUG mcp251xfd mcp251xfd_probe(): > devm_clk_get() > [ 6.812208] mcp251xfd spi0.0: DEBUG mcp251xfd mcp251xfd_probe(): > feq=0x2625a00 > [ 6.850106] mcp251xfd spi0.0 (unnamed net_device) (uninitialized): > Failed to detect MCP251xFD (osc=0x00000000). > > This proves that the driver is getting the 40 MHz from the device tree > properties. The board does have a 40 MHz osc. > > It is the Waveshare CANFD Hat [1]. They have their own tarball for > download [2] with a mcp25xxfd driver that is copyright 2019 by Martin > Sperl . I'm looking at that to see why it > works and the newer, proper driver does not. > > Thanks, > Drew > > [1] https://www.waveshare.com/wiki/2-CH_CAN_FD_HAT > [2] https://www.waveshare.com/wiki/File:2-CH-CAN-FD-HAT-Demo.7z This is the overlay that the Waveshare download is using: https://gist.github.com/pdp7/784d0ba8b9648d20ab055747ec945225 It is different but I'm having trouble understanding why it works and the new overlay for the newer driver does not. -Drew