All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Flanagan, Elizabeth" <elizabeth.flanagan@intel.com>
To: "Aníbal Limón" <anibal.limon@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH][fido] classes/license.bbclass: Improve generic license copy validation.
Date: Wed, 24 Jun 2015 19:59:40 +0100	[thread overview]
Message-ID: <CAPhnLPBfdLeT-3UtWrwqYew48jTCUqqZ4jCSUd_ODMwgUomt9g@mail.gmail.com> (raw)
In-Reply-To: <1435164582-31218-1-git-send-email-anibal.limon@linux.intel.com>

On 24 June 2015 at 17:49, Aníbal Limón <anibal.limon@linux.intel.com> wrote:
> Remove + char in any position for cover cases when license has
> the form like GPL-2.0+-with-OpenSSL-exception.
>
> [YOCTO #7584]
>
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
>  meta/classes/license.bbclass | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
> index 73a0e97..e00a695 100644
> --- a/meta/classes/license.bbclass
> +++ b/meta/classes/license.bbclass
> @@ -71,8 +71,12 @@ license_create_manifest() {
>
>                 lics="$(echo ${pkged_lic} | sed "s/[|&()*]/ /g" | sed "s/  */ /g" )"
>                 for lic in ${lics}; do
> +                       # remove + chars in any position this cover cases like
> +                       # GPL-2.0+-with-OpenSSL-exception -> GPL-2.0-with-OpenSSL-exception
> +                       lic="$(echo ${lic} | sed "s/\+//g")"
> +
>                         # to reference a license file trim trailing + symbol
> -                       if ! [ -e "${LICENSE_DIRECTORY}/${pkged_pn}/generic_${lic%+}" ]; then
> +                       if ! [ -e "${LICENSE_DIRECTORY}/${pkged_pn}/generic_${lic}" ]; then
>                                 bbwarn "The license listed ${lic} was not in the licenses collected for ${pkged_pn}"
>                         fi
>                 done
> --
> 1.9.1
>
> --

This looks like the right fix for this for right now.

Acked-by: Beth Flanagan <elizabeth.flanagan@intel.com>

> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
Elizabeth Flanagan
Yocto Project
Build and Release


  reply	other threads:[~2015-06-24 18:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24 16:49 [PATCH][fido] classes/license.bbclass: Improve generic license copy validation Aníbal Limón
2015-06-24 18:59 ` Flanagan, Elizabeth [this message]
2015-06-26 14:30 ` Joshua Lock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPhnLPBfdLeT-3UtWrwqYew48jTCUqqZ4jCSUd_ODMwgUomt9g@mail.gmail.com \
    --to=elizabeth.flanagan@intel.com \
    --cc=anibal.limon@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.