From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9FA2C433F5 for ; Thu, 14 Apr 2022 21:03:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346739AbiDNVGE (ORCPT ); Thu, 14 Apr 2022 17:06:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346721AbiDNVF7 (ORCPT ); Thu, 14 Apr 2022 17:05:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44A4AD8F46; Thu, 14 Apr 2022 14:03:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 001FFB82B23; Thu, 14 Apr 2022 21:03:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97D90C385AA; Thu, 14 Apr 2022 21:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649970211; bh=UkMQ4UMV4zIIjkvwR6WA9j7hHfaJIvKpNRMLcx2C8EQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=m94A1dx0IP+EPc09O6usSPeuJVq+pXXLjnEfitt2q/KFXYI/hO/8d0eMZ1Lx8FSRK bs0YdH+jPjyX+vv5OqVG3IvuJCz7OxnRIQrsW30ZtumUL26J4Ad2E0/eGDxtsPBWvx RG78EDk0NOS6W3In0lQW5yE8t3qpz8f9i91VC2zhtKJCGutyshmekmemMg91q5ruyM OTwPg7tbB7o6TuLnFNnorq71dtfuvc8i86JpCPveAcNkOb7xuj9SrkZJhXZ3rov6rv sgGDYMFacmlsH05qRCeNm7VVArmpfN+FcGx2V72nCTI1uNdJU9l0eihS0tfK7oV3yc VweQTvwBhSk9A== Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-2ebd70a4cf5so68200427b3.3; Thu, 14 Apr 2022 14:03:31 -0700 (PDT) X-Gm-Message-State: AOAM530jevJQYXKMvOOG9MZQfU9K+ybY9w8s4im/xcDcqdC8wIvCTu1c NOG2MyEIYTyzraj/FVEbh7o/7MxG6t/kj7qbvvM= X-Google-Smtp-Source: ABdhPJzWj+86yGa1OXSzZVano7JEjnkCaOvqXeqGXSAQzAwOci0XM45nfY5+5dzQ/w3y1uC8uuJDMNPGXalm5AAcHMg= X-Received: by 2002:a81:14c8:0:b0:2eb:eb91:d88f with SMTP id 191-20020a8114c8000000b002ebeb91d88fmr3746888ywu.148.1649970210616; Thu, 14 Apr 2022 14:03:30 -0700 (PDT) MIME-Version: 1.0 References: <20220414195914.1648345-1-song@kernel.org> <20220414195914.1648345-4-song@kernel.org> In-Reply-To: From: Song Liu Date: Thu, 14 Apr 2022 14:03:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 bpf RESEND 3/4] module: introduce module_alloc_huge To: Luis Chamberlain Cc: bpf , Linux-MM , open list , Alexei Starovoitov , Daniel Borkmann , Kernel Team , Andrew Morton , "Edgecombe, Rick P" , Christoph Hellwig , imbrenda@linux.ibm.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luis, On Thu, Apr 14, 2022 at 1:34 PM Luis Chamberlain wrote: > > On Thu, Apr 14, 2022 at 12:59:13PM -0700, Song Liu wrote: > > Introduce module_alloc_huge, which allocates huge page backed memory in > > module memory space. The primary user of this memory is bpf_prog_pack > > (multiple BPF programs sharing a huge page). > > > > Signed-off-by: Song Liu > > See modules-next [0], as modules.c has been chopped up as of late. > So if you want this to go throug modules this will need to rebased > on that tree. fortunately the amount of code in question does not > seem like much. > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=modules-next We are hoping to ship this with to 5.18, as the set addresses some issue with huge page backed vmalloc. I guess we cannot ship it via modules-next branch. How about we ship module_alloc_huge() to 5.18 in module.c for now, and once we update modules-next branch, I will send another patch to clean it up? Thanks, Song