All of lore.kernel.org
 help / color / mirror / Atom feed
From: Song Liu <song@kernel.org>
To: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] md: drop queue limitation for RAID1 and RAID10
Date: Tue, 4 Jan 2022 08:42:30 -0800	[thread overview]
Message-ID: <CAPhsuW5PabOGtqSeqfyqCR+Cw6hn_R_xu1h=PDo=JEnFTbuj6A@mail.gmail.com> (raw)
In-Reply-To: <20220103161204.00003025@linux.intel.com>

On Mon, Jan 3, 2022 at 7:33 AM Mariusz Tkaczyk
<mariusz.tkaczyk@linux.intel.com> wrote:
>
> On Sat, 1 Jan 2022 16:30:07 -0800
> Song Liu <song@kernel.org> wrote:
>
> > On Fri, Dec 17, 2021 at 1:30 AM Mariusz Tkaczyk
> > <mariusz.tkaczyk@linux.intel.com> wrote:
> > >
> > > As suggested by Neil Brown[1], this limitation seems to be
> > > deprecated.
> > >
> > > With plugging in use, writes are processed behind the raid thread
> > > and conf->pending_count is not increased. This limitation occurs
> > > only if caller doesn't use plugs.
> > >
> > > It can be avoided and often it is (with plugging). There are no
> > > reports that queue is growing to enormous size so remove queue
> > > limitation for non-plugged IOs too.
> > >
> > > [1]
> > > https://lore.kernel.org/linux-raid/162496301481.7211.18031090130574610495@noble.neil.brown.name
> > >
> > > Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
> >
> > I applied this patch to md-next, cecause it helps simplify Vishal's
> > patches for REQ_NOWAIT. However, I think this change is not complete,
> > as we can now remove pending_count from r1conf and r10conf. Please
> > send patch on top of md-next to clean up pending_count.
> >
> Should I also remove pending_cnt from raid1_plug_cb and raid10_plug_cb?

Yeah, I think we should also remove pending_cnt.

Thanks,
Song

      reply	other threads:[~2022-01-04 16:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17  9:29 [PATCH] md: drop queue limitation for RAID1 and RAID10 Mariusz Tkaczyk
2022-01-02  0:30 ` Song Liu
2022-01-03 15:33   ` Mariusz Tkaczyk
2022-01-04 16:42     ` Song Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPhsuW5PabOGtqSeqfyqCR+Cw6hn_R_xu1h=PDo=JEnFTbuj6A@mail.gmail.com' \
    --to=song@kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mariusz.tkaczyk@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.