* [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary
@ 2021-05-19 6:22 Christoph Hellwig
2021-05-19 6:24 ` Christoph Hellwig
2021-05-19 11:01 ` wp1083705-spam02 wp1083705-spam02
0 siblings, 2 replies; 7+ messages in thread
From: Christoph Hellwig @ 2021-05-19 6:22 UTC (permalink / raw)
To: song, axboe; +Cc: linux-raid, linux-block, Florian D .
Now that the original bdev is stored in the bio this assert is incorrect
and will trigge for any partitioned raid5 device.
Reported-by: Florian D. <spam02@dazinger.net>
Fixes: 309dca309fc3 ("block: store a block_device pointer in struct bio"),
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/md/raid5.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 841e1c1aa5e6..7d4ff8a5c55e 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -5311,8 +5311,6 @@ static int in_chunk_boundary(struct mddev *mddev, struct bio *bio)
unsigned int chunk_sectors;
unsigned int bio_sectors = bio_sectors(bio);
- WARN_ON_ONCE(bio->bi_bdev->bd_partno);
-
chunk_sectors = min(conf->chunk_sectors, conf->prev_chunk_sectors);
return chunk_sectors >=
((sector & (chunk_sectors - 1)) + bio_sectors);
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary
2021-05-19 6:22 [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary Christoph Hellwig
@ 2021-05-19 6:24 ` Christoph Hellwig
2021-05-19 7:57 ` Guoqing Jiang
2021-05-19 11:01 ` wp1083705-spam02 wp1083705-spam02
1 sibling, 1 reply; 7+ messages in thread
From: Christoph Hellwig @ 2021-05-19 6:24 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: song, axboe, linux-raid, linux-block, Florian D .
s/incorect/incorrect/ in the subject, sorry.
On Wed, May 19, 2021 at 08:22:15AM +0200, Christoph Hellwig wrote:
> Now that the original bdev is stored in the bio this assert is incorrect
> and will trigge for any partitioned raid5 device.
>
> Reported-by: Florian D. <spam02@dazinger.net>
> Fixes: 309dca309fc3 ("block: store a block_device pointer in struct bio"),
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/md/raid5.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 841e1c1aa5e6..7d4ff8a5c55e 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -5311,8 +5311,6 @@ static int in_chunk_boundary(struct mddev *mddev, struct bio *bio)
> unsigned int chunk_sectors;
> unsigned int bio_sectors = bio_sectors(bio);
>
> - WARN_ON_ONCE(bio->bi_bdev->bd_partno);
> -
> chunk_sectors = min(conf->chunk_sectors, conf->prev_chunk_sectors);
> return chunk_sectors >=
> ((sector & (chunk_sectors - 1)) + bio_sectors);
> --
> 2.30.2
>
---end quoted text---
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary
2021-05-19 6:24 ` Christoph Hellwig
@ 2021-05-19 7:57 ` Guoqing Jiang
0 siblings, 0 replies; 7+ messages in thread
From: Guoqing Jiang @ 2021-05-19 7:57 UTC (permalink / raw)
To: Christoph Hellwig, Christoph Hellwig
Cc: song, axboe, linux-raid, linux-block, Florian D .
On 5/19/21 2:24 PM, Christoph Hellwig wrote:
> s/incorect/incorrect/ in the subject, sorry.
>
> On Wed, May 19, 2021 at 08:22:15AM +0200, Christoph Hellwig wrote:
>> Now that the original bdev is stored in the bio this assert is incorrect
>> and will trigge for any partitioned raid5 device.
Maybe s/trigge/trigger/? Anyway
Reviewed-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
Thanks,
Guoqing
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary
2021-05-19 6:22 [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary Christoph Hellwig
2021-05-19 6:24 ` Christoph Hellwig
@ 2021-05-19 11:01 ` wp1083705-spam02 wp1083705-spam02
2021-05-24 4:38 ` Song Liu
1 sibling, 1 reply; 7+ messages in thread
From: wp1083705-spam02 wp1083705-spam02 @ 2021-05-19 11:01 UTC (permalink / raw)
To: Christoph Hellwig, song, axboe; +Cc: linux-raid, linux-block
> Christoph Hellwig <hch@lst.de> hat am 19.05.2021 08:22 geschrieben:
>
>
> Now that the original bdev is stored in the bio this assert is incorrect
> and will trigge for any partitioned raid5 device.
>
> Reported-by: Florian D. <spam02@dazinger.net>
> Fixes: 309dca309fc3 ("block: store a block_device pointer in struct bio"),
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/md/raid5.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 841e1c1aa5e6..7d4ff8a5c55e 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -5311,8 +5311,6 @@ static int in_chunk_boundary(struct mddev *mddev, struct bio *bio)
> unsigned int chunk_sectors;
> unsigned int bio_sectors = bio_sectors(bio);
>
> - WARN_ON_ONCE(bio->bi_bdev->bd_partno);
> -
> chunk_sectors = min(conf->chunk_sectors, conf->prev_chunk_sectors);
> return chunk_sectors >=
> ((sector & (chunk_sectors - 1)) + bio_sectors);
> --
> 2.30.2
yes, this solves it, I can confirm with this patch the error/warning message when booting linux-5.12 is gone!
Thanks a lot!
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary
2021-05-19 11:01 ` wp1083705-spam02 wp1083705-spam02
@ 2021-05-24 4:38 ` Song Liu
2021-05-24 11:00 ` Florian D.
0 siblings, 1 reply; 7+ messages in thread
From: Song Liu @ 2021-05-24 4:38 UTC (permalink / raw)
To: wp1083705-spam02 wp1083705-spam02
Cc: Christoph Hellwig, Jens Axboe, linux-raid, linux-block
On Wed, May 19, 2021 at 4:36 AM wp1083705-spam02 wp1083705-spam02
<spam02@dazinger.net> wrote:
>
>
> > Christoph Hellwig <hch@lst.de> hat am 19.05.2021 08:22 geschrieben:
> >
> >
> > Now that the original bdev is stored in the bio this assert is incorrect
> > and will trigge for any partitioned raid5 device.
> >
> > Reported-by: Florian D. <spam02@dazinger.net>
> > Fixes: 309dca309fc3 ("block: store a block_device pointer in struct bio"),
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > drivers/md/raid5.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> > index 841e1c1aa5e6..7d4ff8a5c55e 100644
> > --- a/drivers/md/raid5.c
> > +++ b/drivers/md/raid5.c
> > @@ -5311,8 +5311,6 @@ static int in_chunk_boundary(struct mddev *mddev, struct bio *bio)
> > unsigned int chunk_sectors;
> > unsigned int bio_sectors = bio_sectors(bio);
> >
> > - WARN_ON_ONCE(bio->bi_bdev->bd_partno);
> > -
> > chunk_sectors = min(conf->chunk_sectors, conf->prev_chunk_sectors);
> > return chunk_sectors >=
> > ((sector & (chunk_sectors - 1)) + bio_sectors);
> > --
> > 2.30.2
>
> yes, this solves it, I can confirm with this patch the error/warning message when booting linux-5.12 is gone!
Applied to md-fixes. Thanks all.
@ Florian, would you like to update the Reported-by tag (with your
full name and/or
different email)?
Thanks,
Song
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary
2021-05-24 4:38 ` Song Liu
@ 2021-05-24 11:00 ` Florian D.
2021-05-26 1:05 ` Song Liu
0 siblings, 1 reply; 7+ messages in thread
From: Florian D. @ 2021-05-24 11:00 UTC (permalink / raw)
To: Song Liu; +Cc: Christoph Hellwig, Jens Axboe, linux-raid, linux-block
As you like... if it's better in the 'tested by:' line, you can also take my full name: Florian Dazinger.
I use the e- mail address regularly, so that's ok.
Thanks for the quick patch!
Florian
On 24 May 2021 06:38:35 CEST, Song Liu <song@kernel.org> wrote:
>On Wed, May 19, 2021 at 4:36 AM wp1083705-spam02 wp1083705-spam02
><spam02@dazinger.net> wrote:
>>
>>
>> > Christoph Hellwig <hch@lst.de> hat am 19.05.2021 08:22 geschrieben:
>> >
>> >
>> > Now that the original bdev is stored in the bio this assert is
>incorrect
>> > and will trigge for any partitioned raid5 device.
>> >
>> > Reported-by: Florian D. <spam02@dazinger.net>
>> > Fixes: 309dca309fc3 ("block: store a block_device pointer in struct
>bio"),
>> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>> > ---
>> > drivers/md/raid5.c | 2 --
>> > 1 file changed, 2 deletions(-)
>> >
>> > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
>> > index 841e1c1aa5e6..7d4ff8a5c55e 100644
>> > --- a/drivers/md/raid5.c
>> > +++ b/drivers/md/raid5.c
>> > @@ -5311,8 +5311,6 @@ static int in_chunk_boundary(struct mddev
>*mddev, struct bio *bio)
>> > unsigned int chunk_sectors;
>> > unsigned int bio_sectors = bio_sectors(bio);
>> >
>> > - WARN_ON_ONCE(bio->bi_bdev->bd_partno);
>> > -
>> > chunk_sectors = min(conf->chunk_sectors,
>conf->prev_chunk_sectors);
>> > return chunk_sectors >=
>> > ((sector & (chunk_sectors - 1)) + bio_sectors);
>> > --
>> > 2.30.2
>>
>> yes, this solves it, I can confirm with this patch the error/warning
>message when booting linux-5.12 is gone!
>
>Applied to md-fixes. Thanks all.
>
>@ Florian, would you like to update the Reported-by tag (with your
>full name and/or
>different email)?
>
>Thanks,
>Song
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary
2021-05-24 11:00 ` Florian D.
@ 2021-05-26 1:05 ` Song Liu
0 siblings, 0 replies; 7+ messages in thread
From: Song Liu @ 2021-05-26 1:05 UTC (permalink / raw)
To: Florian D.; +Cc: Christoph Hellwig, Jens Axboe, linux-raid, linux-block
On Mon, May 24, 2021 at 4:00 AM Florian D. <spam02@dazinger.net> wrote:
>
> As you like... if it's better in the 'tested by:' line, you can also take my full name: Florian Dazinger.
> I use the e- mail address regularly, so that's ok.
>
Added both Reported-by and Tested-by with your full name.
Thanks,
Song
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-05-26 1:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 6:22 [PATCH] md/raid5: remove an incorect assert in in_chunk_boundary Christoph Hellwig
2021-05-19 6:24 ` Christoph Hellwig
2021-05-19 7:57 ` Guoqing Jiang
2021-05-19 11:01 ` wp1083705-spam02 wp1083705-spam02
2021-05-24 4:38 ` Song Liu
2021-05-24 11:00 ` Florian D.
2021-05-26 1:05 ` Song Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.