All of lore.kernel.org
 help / color / mirror / Atom feed
From: Song Liu <song@kernel.org>
To: Michal Soltys <msoltyspl@yandex.pl>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: Assemblin journaled array fails
Date: Wed, 8 Jul 2020 16:51:56 -0700	[thread overview]
Message-ID: <CAPhsuW6tzdneY9C7kiZTC-qhK-se_JhY2e683PQo09QvAqyP6Q@mail.gmail.com> (raw)
In-Reply-To: <40054126-5009-3633-b7f9-198c2cc53ce7@yandex.pl>

On Wed, Jul 8, 2020 at 4:29 AM Michal Soltys <msoltyspl@yandex.pl> wrote:
>
> On 7/7/20 12:08 AM, Song Liu wrote:
> >>
> >> So, what kind of next step after this ?
> >
> > Sorry for the delay. I read the log again, and found the following
> > line caused this issue:
> >
> > [ +16.088243] r5l_write_super_and_discard_space set MD_SB_CHANGE_PENDING
> >
> > The attached patch should workaround this issue. Could you please give it a try?
>
> Yea, this solved the issue - the raid assembled correctly (so the patch
> is probably a good candidate for lts kernels).

Thanks for testing the patch. I will work on applying it to upstream.

>
> Thanks for helping with this bug.
>
> Underlying filesystems are mountable/usable as well - albeit read-only
> fsck (ext4) or btrfs check do find some minor issues; tough to say at
> this point what was the exact culprit.
>
> In this particular case - imho - one issue remains: the assembly is
> slower than full resync (without bitmap), which outside of some
> performance gains (writeback journal) and write-hole fixing - kind of
> completely defeats the point of having such resync policy in the first
> place.

Totally agreed that we need to improve the recovery speed. I will also look
into that.

Thanks again!
Song

  reply	other threads:[~2020-07-08 23:51 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 10:54 Assemblin journaled array fails Michal Soltys
2020-05-09 11:32 ` Michal Soltys
2020-05-09 13:15 ` antlists
2020-05-09 13:20   ` Michal Soltys
2020-05-09 13:32     ` Michal Soltys
2020-05-09 23:57 ` Michal Soltys
2020-05-11 11:11   ` Michal Soltys
2020-05-12  1:27     ` Song Liu
2020-05-13 10:58       ` Michal Soltys
2020-05-13 16:17         ` Song Liu
2020-05-14 11:07           ` Michal Soltys
2020-05-16  0:15             ` Song Liu
     [not found]               ` <d0340d7b-6b3a-4fd3-e446-5f0967132ef6@yandex.pl>
2020-05-18 23:55                 ` Song Liu
2020-05-20 12:08                   ` Michal Soltys
2020-05-25 16:23                   ` Michal Soltys
2020-05-26 23:37                     ` Song Liu
2020-05-27 13:36                       ` Michal Soltys
2020-05-28 10:18                         ` Michal Soltys
2020-05-28 15:06                           ` Song Liu
2020-05-28 15:36                             ` Michal Soltys
2020-05-29 12:09                             ` Michal Soltys
2020-05-29 21:03                               ` Song Liu
2020-05-29 21:57                                 ` Song Liu
2020-06-03 10:12                                   ` Michal Soltys
2020-06-03 22:07                                     ` Song Liu
2020-06-04 13:58                                       ` Michal Soltys
2020-06-05 12:26                                       ` Michal Soltys
2020-06-09  9:36                                         ` Michal Soltys
2020-06-09 18:36                                           ` Song Liu
2020-06-09 21:51                                             ` Michal Soltys
2020-06-16 11:11                                               ` Michal Soltys
2020-06-17  0:48                                               ` Song Liu
2020-06-17 12:53                                                 ` Michal Soltys
2020-06-17 17:11                                                   ` Song Liu
2020-06-19 11:35                                                     ` Michal Soltys
2020-06-20  0:14                                                       ` Song Liu
2020-06-22 11:12                                                         ` Michal Soltys
2020-06-22 16:37                                                           ` Song Liu
2020-06-23 13:17                                                             ` Michal Soltys
2020-06-23 23:13                                                               ` Song Liu
2020-06-25 16:11                                                                 ` Michal Soltys
2020-07-06  8:07                                                                   ` Michal Soltys
2020-07-06 22:08                                                                     ` Song Liu
2020-07-08 11:29                                                                       ` Michal Soltys
2020-07-08 23:51                                                                         ` Song Liu [this message]
2020-06-26  8:28             ` Guoqing Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPhsuW6tzdneY9C7kiZTC-qhK-se_JhY2e683PQo09QvAqyP6Q@mail.gmail.com \
    --to=song@kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=msoltyspl@yandex.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.