From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B44110FA for ; Thu, 1 Jun 2023 22:36:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA17FC433A1 for ; Thu, 1 Jun 2023 22:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685658961; bh=HByQUJENQcDPWiijaDFhYT8jA4bRcfOqcVglu/ddG6U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FOEYRJKpnW4iKM1qTP1RubJNm9oWcin4d1pqMhfHH1jHWxeA9v7cAr5+A08be7Fvr zIIQ+RK+VnwmRh4dV8eSpzAC9vuNvbbjJOCAUkLs9IEIoqPeldosvmDlneE7uI7zOd MEOs6GaTT4piHutYs3mvFo1SqMwdjh24tg3ZUrqf+ZV0OcZYne8qDSmsAgVG5/lRkC oXr4pi7df6VNXbdn9AQ54C0O6ISTgYI6uFDZwH8n+ZPgRbBtlTQ2kYBiwhgF0xcuce QXcem6qexEf8Xds1Y609C0dKziypJ0zgLG99S8eQ6nOm/bUVZH+kysGTa5OEj33f00 mI/aIAuZGqq9Q== Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-4f3ba703b67so1883165e87.1 for ; Thu, 01 Jun 2023 15:36:01 -0700 (PDT) X-Gm-Message-State: AC+VfDzQslJWM4HcV0FfXMlk4IkvrQktGO20qpPYLdvHvvs07vkb+nBK VBBCCMeneLBmaP4B1JYlkzuH7XNjWWXKpn7Ale8= X-Google-Smtp-Source: ACHHUZ5IpAtCBKLINxhk+Z0SWINwbFkPqmi++HI/k6BNegfGNCzvnzTim5Gy3oJJLp9NHmq3+FFn0pl72eGk9Pzb3ws= X-Received: by 2002:ac2:48ba:0:b0:4ec:8816:f4fc with SMTP id u26-20020ac248ba000000b004ec8816f4fcmr792426lfg.6.1685658959623; Thu, 01 Jun 2023 15:35:59 -0700 (PDT) Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230601101257.530867-1-rppt@kernel.org> <20230601101257.530867-5-rppt@kernel.org> In-Reply-To: <20230601101257.530867-5-rppt@kernel.org> From: Song Liu Date: Thu, 1 Jun 2023 15:35:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/13] mm/jitalloc, arch: convert remaining overrides of module_alloc to jitalloc To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 1, 2023 at 3:13=E2=80=AFAM Mike Rapoport wrot= e: > > From: "Mike Rapoport (IBM)" > > Extend jitalloc parameters to accommodate more complex overrides of > module_alloc() by architectures. > > This includes specification of a fallback range required by arm, arm64 > and powerpc and support for allocation of KASAN shadow required by > arm64, s390 and x86. > > The core implementation of jit_alloc() takes care of suppressing warnings > when the initial allocation fails but there is a fallback range defined. > > Signed-off-by: Mike Rapoport (IBM) [...] > > diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c > index 5af4975caeb5..ecf1f4030317 100644 > --- a/arch/arm64/kernel/module.c > +++ b/arch/arm64/kernel/module.c > @@ -17,56 +17,49 @@ > #include > #include > #include > +#include > #include > #include > #include > #include > > -void *module_alloc(unsigned long size) > +static struct jit_alloc_params jit_alloc_params =3D { > + .alignment =3D MODULE_ALIGN, > + .flags =3D JIT_ALLOC_KASAN_SHADOW, > +}; > + > +struct jit_alloc_params *jit_alloc_arch_params(void) > { > u64 module_alloc_end =3D module_alloc_base + MODULES_VSIZE; module_alloc_base() is initialized in kaslr_init(), which is called after mm_core_init(). We will need some special logic for this. Thanks, Song > - gfp_t gfp_mask =3D GFP_KERNEL; > - void *p; > - > - /* Silence the initial allocation */ > - if (IS_ENABLED(CONFIG_ARM64_MODULE_PLTS)) > - gfp_mask |=3D __GFP_NOWARN; > [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD2AEC77B7E for ; Thu, 1 Jun 2023 22:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=12Jq4jUt+Af7KwANeSGTyHXn6ETSEWyY0B/eeaK6baU=; b=Qe6NF6G/wpbPJl DZwIiC0EMX3NFJKu1Nb367iw48gZlcgkS4hE1VuU4P+x9+Qz9rqCwAkh3q24KWno7v/AS/C+SPnFX c/bXBl2fMS9BXlWX+plV5M7zx4qTvX9Wz7mIT41bYX+Clj1319FW+FPVAlHXSMCY8vpzJlhk+wBAS 9+YvuyoWQMWgO84p+3DoJCfDFyzHv0f4Slq6CT6z5omsrPXzl4dpJXuz0n7A3ZItn52GWhMNvcl5i AlO3JThhcRNxJbEHM2DE2NnwrpVWlIrghx1ak9z5zG1mkAkGnKpNNGprW3vHdMsdwojLWEzCbwhvk k48PARLq25ZLV//0DSqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4qu0-0059G7-0A; Thu, 01 Jun 2023 22:36:16 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4qtx-0059D3-1D; Thu, 01 Jun 2023 22:36:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 00DB964AAD; Thu, 1 Jun 2023 22:36:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D66F8C433AC; Thu, 1 Jun 2023 22:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685658961; bh=HByQUJENQcDPWiijaDFhYT8jA4bRcfOqcVglu/ddG6U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FOEYRJKpnW4iKM1qTP1RubJNm9oWcin4d1pqMhfHH1jHWxeA9v7cAr5+A08be7Fvr zIIQ+RK+VnwmRh4dV8eSpzAC9vuNvbbjJOCAUkLs9IEIoqPeldosvmDlneE7uI7zOd MEOs6GaTT4piHutYs3mvFo1SqMwdjh24tg3ZUrqf+ZV0OcZYne8qDSmsAgVG5/lRkC oXr4pi7df6VNXbdn9AQ54C0O6ISTgYI6uFDZwH8n+ZPgRbBtlTQ2kYBiwhgF0xcuce QXcem6qexEf8Xds1Y609C0dKziypJ0zgLG99S8eQ6nOm/bUVZH+kysGTa5OEj33f00 mI/aIAuZGqq9Q== Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-4f4bdcde899so1889273e87.0; Thu, 01 Jun 2023 15:36:01 -0700 (PDT) X-Gm-Message-State: AC+VfDzOe024bmsgyeJRVANcMW4ro7AOqTEYrLT03gMhZHzNsq8YvYyr VDv/WCy8NamQS3mwTSyMyyBYtXWFwn/5AxhELZ8= X-Google-Smtp-Source: ACHHUZ5IpAtCBKLINxhk+Z0SWINwbFkPqmi++HI/k6BNegfGNCzvnzTim5Gy3oJJLp9NHmq3+FFn0pl72eGk9Pzb3ws= X-Received: by 2002:ac2:48ba:0:b0:4ec:8816:f4fc with SMTP id u26-20020ac248ba000000b004ec8816f4fcmr792426lfg.6.1685658959623; Thu, 01 Jun 2023 15:35:59 -0700 (PDT) MIME-Version: 1.0 References: <20230601101257.530867-1-rppt@kernel.org> <20230601101257.530867-5-rppt@kernel.org> In-Reply-To: <20230601101257.530867-5-rppt@kernel.org> From: Song Liu Date: Thu, 1 Jun 2023 15:35:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/13] mm/jitalloc, arch: convert remaining overrides of module_alloc to jitalloc To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_153613_492119_806E44E5 X-CRM114-Status: GOOD ( 19.79 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdW4gMSwgMjAyMyBhdCAzOjEz4oCvQU0gTWlrZSBSYXBvcG9ydCA8cnBwdEBrZXJu ZWwub3JnPiB3cm90ZToKPgo+IEZyb206ICJNaWtlIFJhcG9wb3J0IChJQk0pIiA8cnBwdEBrZXJu ZWwub3JnPgo+Cj4gRXh0ZW5kIGppdGFsbG9jIHBhcmFtZXRlcnMgdG8gYWNjb21tb2RhdGUgbW9y ZSBjb21wbGV4IG92ZXJyaWRlcyBvZgo+IG1vZHVsZV9hbGxvYygpIGJ5IGFyY2hpdGVjdHVyZXMu Cj4KPiBUaGlzIGluY2x1ZGVzIHNwZWNpZmljYXRpb24gb2YgYSBmYWxsYmFjayByYW5nZSByZXF1 aXJlZCBieSBhcm0sIGFybTY0Cj4gYW5kIHBvd2VycGMgYW5kIHN1cHBvcnQgZm9yIGFsbG9jYXRp b24gb2YgS0FTQU4gc2hhZG93IHJlcXVpcmVkIGJ5Cj4gYXJtNjQsIHMzOTAgYW5kIHg4Ni4KPgo+ IFRoZSBjb3JlIGltcGxlbWVudGF0aW9uIG9mIGppdF9hbGxvYygpIHRha2VzIGNhcmUgb2Ygc3Vw cHJlc3Npbmcgd2FybmluZ3MKPiB3aGVuIHRoZSBpbml0aWFsIGFsbG9jYXRpb24gZmFpbHMgYnV0 IHRoZXJlIGlzIGEgZmFsbGJhY2sgcmFuZ2UgZGVmaW5lZC4KPgo+IFNpZ25lZC1vZmYtYnk6IE1p a2UgUmFwb3BvcnQgKElCTSkgPHJwcHRAa2VybmVsLm9yZz4KClsuLi5dCgo+Cj4gZGlmZiAtLWdp dCBhL2FyY2gvYXJtNjQva2VybmVsL21vZHVsZS5jIGIvYXJjaC9hcm02NC9rZXJuZWwvbW9kdWxl LmMKPiBpbmRleCA1YWY0OTc1Y2FlYjUuLmVjZjFmNDAzMDMxNyAxMDA2NDQKPiAtLS0gYS9hcmNo L2FybTY0L2tlcm5lbC9tb2R1bGUuYwo+ICsrKyBiL2FyY2gvYXJtNjQva2VybmVsL21vZHVsZS5j Cj4gQEAgLTE3LDU2ICsxNyw0OSBAQAo+ICAjaW5jbHVkZSA8bGludXgvbW9kdWxlbG9hZGVyLmg+ Cj4gICNpbmNsdWRlIDxsaW51eC9zY3MuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3ZtYWxsb2MuaD4K PiArI2luY2x1ZGUgPGxpbnV4L2ppdGFsbG9jLmg+Cj4gICNpbmNsdWRlIDxhc20vYWx0ZXJuYXRp dmUuaD4KPiAgI2luY2x1ZGUgPGFzbS9pbnNuLmg+Cj4gICNpbmNsdWRlIDxhc20vc2NzLmg+Cj4g ICNpbmNsdWRlIDxhc20vc2VjdGlvbnMuaD4KPgo+IC12b2lkICptb2R1bGVfYWxsb2ModW5zaWdu ZWQgbG9uZyBzaXplKQo+ICtzdGF0aWMgc3RydWN0IGppdF9hbGxvY19wYXJhbXMgaml0X2FsbG9j X3BhcmFtcyA9IHsKPiArICAgICAgIC5hbGlnbm1lbnQgICAgICA9IE1PRFVMRV9BTElHTiwKPiAr ICAgICAgIC5mbGFncyAgICAgICAgICA9IEpJVF9BTExPQ19LQVNBTl9TSEFET1csCj4gK307Cj4g Kwo+ICtzdHJ1Y3Qgaml0X2FsbG9jX3BhcmFtcyAqaml0X2FsbG9jX2FyY2hfcGFyYW1zKHZvaWQp Cj4gIHsKPiAgICAgICAgIHU2NCBtb2R1bGVfYWxsb2NfZW5kID0gbW9kdWxlX2FsbG9jX2Jhc2Ug KyBNT0RVTEVTX1ZTSVpFOwoKbW9kdWxlX2FsbG9jX2Jhc2UoKSBpcyBpbml0aWFsaXplZCBpbiBr YXNscl9pbml0KCksIHdoaWNoIGlzIGNhbGxlZCBhZnRlcgptbV9jb3JlX2luaXQoKS4gV2Ugd2ls bCBuZWVkIHNvbWUgc3BlY2lhbCBsb2dpYyBmb3IgdGhpcy4KClRoYW5rcywKU29uZwoKPiAtICAg ICAgIGdmcF90IGdmcF9tYXNrID0gR0ZQX0tFUk5FTDsKPiAtICAgICAgIHZvaWQgKnA7Cj4gLQo+ IC0gICAgICAgLyogU2lsZW5jZSB0aGUgaW5pdGlhbCBhbGxvY2F0aW9uICovCj4gLSAgICAgICBp ZiAoSVNfRU5BQkxFRChDT05GSUdfQVJNNjRfTU9EVUxFX1BMVFMpKQo+IC0gICAgICAgICAgICAg ICBnZnBfbWFzayB8PSBfX0dGUF9OT1dBUk47Cj4KClsuLi5dCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGlu dXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD92FC77B7E for ; Thu, 1 Jun 2023 22:36:58 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QXLbY0t9zz3dyd for ; Fri, 2 Jun 2023 08:36:57 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FOEYRJKp; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=song@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FOEYRJKp; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QXLZY18ybz3c9R for ; Fri, 2 Jun 2023 08:36:05 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F36A64AA5 for ; Thu, 1 Jun 2023 22:36:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B439EC433A0 for ; Thu, 1 Jun 2023 22:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685658961; bh=HByQUJENQcDPWiijaDFhYT8jA4bRcfOqcVglu/ddG6U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FOEYRJKpnW4iKM1qTP1RubJNm9oWcin4d1pqMhfHH1jHWxeA9v7cAr5+A08be7Fvr zIIQ+RK+VnwmRh4dV8eSpzAC9vuNvbbjJOCAUkLs9IEIoqPeldosvmDlneE7uI7zOd MEOs6GaTT4piHutYs3mvFo1SqMwdjh24tg3ZUrqf+ZV0OcZYne8qDSmsAgVG5/lRkC oXr4pi7df6VNXbdn9AQ54C0O6ISTgYI6uFDZwH8n+ZPgRbBtlTQ2kYBiwhgF0xcuce QXcem6qexEf8Xds1Y609C0dKziypJ0zgLG99S8eQ6nOm/bUVZH+kysGTa5OEj33f00 mI/aIAuZGqq9Q== Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-4effb818c37so1873976e87.3 for ; Thu, 01 Jun 2023 15:36:01 -0700 (PDT) X-Gm-Message-State: AC+VfDzqEpQkcLEjPwgA6gldQ5saUacKS2kJC0jkzkQN4jH/mIsrIbPb RitDU2weCNJSbS3pQaXCBXiKE/pjKmBS6PlemBA= X-Google-Smtp-Source: ACHHUZ5IpAtCBKLINxhk+Z0SWINwbFkPqmi++HI/k6BNegfGNCzvnzTim5Gy3oJJLp9NHmq3+FFn0pl72eGk9Pzb3ws= X-Received: by 2002:ac2:48ba:0:b0:4ec:8816:f4fc with SMTP id u26-20020ac248ba000000b004ec8816f4fcmr792426lfg.6.1685658959623; Thu, 01 Jun 2023 15:35:59 -0700 (PDT) MIME-Version: 1.0 References: <20230601101257.530867-1-rppt@kernel.org> <20230601101257.530867-5-rppt@kernel.org> In-Reply-To: <20230601101257.530867-5-rppt@kernel.org> From: Song Liu Date: Thu, 1 Jun 2023 15:35:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/13] mm/jitalloc, arch: convert remaining overrides of module_alloc to jitalloc To: Mike Rapoport Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Catalin Marinas , linux-mips@vger.kernel.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , linux-s390@vger.kernel.org, Helge Deller , Huacai Chen , Russell King , "Naveen N. Rao" , linux-trace-kernel@vger.kernel.org, Heiko Carstens , Steven Rostedt , loongarch@lists.linux.dev, Thomas Gleixner , Andrew Morton , linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Kent Overstreet , linux-kernel@vger.kernel.org, Dinh Nguyen , Luis Chamberlain , Palmer Dabbelt , bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" , linux-modules@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jun 1, 2023 at 3:13=E2=80=AFAM Mike Rapoport wrot= e: > > From: "Mike Rapoport (IBM)" > > Extend jitalloc parameters to accommodate more complex overrides of > module_alloc() by architectures. > > This includes specification of a fallback range required by arm, arm64 > and powerpc and support for allocation of KASAN shadow required by > arm64, s390 and x86. > > The core implementation of jit_alloc() takes care of suppressing warnings > when the initial allocation fails but there is a fallback range defined. > > Signed-off-by: Mike Rapoport (IBM) [...] > > diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c > index 5af4975caeb5..ecf1f4030317 100644 > --- a/arch/arm64/kernel/module.c > +++ b/arch/arm64/kernel/module.c > @@ -17,56 +17,49 @@ > #include > #include > #include > +#include > #include > #include > #include > #include > > -void *module_alloc(unsigned long size) > +static struct jit_alloc_params jit_alloc_params =3D { > + .alignment =3D MODULE_ALIGN, > + .flags =3D JIT_ALLOC_KASAN_SHADOW, > +}; > + > +struct jit_alloc_params *jit_alloc_arch_params(void) > { > u64 module_alloc_end =3D module_alloc_base + MODULES_VSIZE; module_alloc_base() is initialized in kaslr_init(), which is called after mm_core_init(). We will need some special logic for this. Thanks, Song > - gfp_t gfp_mask =3D GFP_KERNEL; > - void *p; > - > - /* Silence the initial allocation */ > - if (IS_ENABLED(CONFIG_ARM64_MODULE_PLTS)) > - gfp_mask |=3D __GFP_NOWARN; > [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B296C77B7E for ; Thu, 1 Jun 2023 22:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KMWrzI+h5XIn9H0lkPVrkun5YSiiqd78dG1ng76KOZI=; b=4Mod08xCMcrHqc WXaOVjfoJ6anWLWM9uFdaf3dJ9ZHqXUtNIS6/AV+EQCZ7tgY8QEN6P0bPIBWLSCqzm+Bye0rGtRVi 8sYJ2K66OwmG4lsmNj2kIYTJgW98YsMU1aFgoFf6Kyr/QXjW7SS1IBmZRvB8dOyDFMx5W1yw19Z8T JBQrN1P1pbgWTGI5RXBYPv8jsVlp4fpxFFLFfepAN/aelFFRw+/xzJQcDx0dBNjT6ETCNh88poA5J 5WVMT5CyymVN5sfPBntJYiolElTDO5QhAKygtD4tZGBaDzU4MXbeqEjNdpUI52VKOzmCLk1k/3toF mQu6koPR2uaKmSG3Rv8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4qtz-0059Fz-1i; Thu, 01 Jun 2023 22:36:15 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4qtx-0059D3-1D; Thu, 01 Jun 2023 22:36:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 00DB964AAD; Thu, 1 Jun 2023 22:36:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D66F8C433AC; Thu, 1 Jun 2023 22:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685658961; bh=HByQUJENQcDPWiijaDFhYT8jA4bRcfOqcVglu/ddG6U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FOEYRJKpnW4iKM1qTP1RubJNm9oWcin4d1pqMhfHH1jHWxeA9v7cAr5+A08be7Fvr zIIQ+RK+VnwmRh4dV8eSpzAC9vuNvbbjJOCAUkLs9IEIoqPeldosvmDlneE7uI7zOd MEOs6GaTT4piHutYs3mvFo1SqMwdjh24tg3ZUrqf+ZV0OcZYne8qDSmsAgVG5/lRkC oXr4pi7df6VNXbdn9AQ54C0O6ISTgYI6uFDZwH8n+ZPgRbBtlTQ2kYBiwhgF0xcuce QXcem6qexEf8Xds1Y609C0dKziypJ0zgLG99S8eQ6nOm/bUVZH+kysGTa5OEj33f00 mI/aIAuZGqq9Q== Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-4f4bdcde899so1889273e87.0; Thu, 01 Jun 2023 15:36:01 -0700 (PDT) X-Gm-Message-State: AC+VfDzOe024bmsgyeJRVANcMW4ro7AOqTEYrLT03gMhZHzNsq8YvYyr VDv/WCy8NamQS3mwTSyMyyBYtXWFwn/5AxhELZ8= X-Google-Smtp-Source: ACHHUZ5IpAtCBKLINxhk+Z0SWINwbFkPqmi++HI/k6BNegfGNCzvnzTim5Gy3oJJLp9NHmq3+FFn0pl72eGk9Pzb3ws= X-Received: by 2002:ac2:48ba:0:b0:4ec:8816:f4fc with SMTP id u26-20020ac248ba000000b004ec8816f4fcmr792426lfg.6.1685658959623; Thu, 01 Jun 2023 15:35:59 -0700 (PDT) MIME-Version: 1.0 References: <20230601101257.530867-1-rppt@kernel.org> <20230601101257.530867-5-rppt@kernel.org> In-Reply-To: <20230601101257.530867-5-rppt@kernel.org> From: Song Liu Date: Thu, 1 Jun 2023 15:35:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/13] mm/jitalloc, arch: convert remaining overrides of module_alloc to jitalloc To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_153613_492119_806E44E5 X-CRM114-Status: GOOD ( 19.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdW4gMSwgMjAyMyBhdCAzOjEz4oCvQU0gTWlrZSBSYXBvcG9ydCA8cnBwdEBrZXJu ZWwub3JnPiB3cm90ZToKPgo+IEZyb206ICJNaWtlIFJhcG9wb3J0IChJQk0pIiA8cnBwdEBrZXJu ZWwub3JnPgo+Cj4gRXh0ZW5kIGppdGFsbG9jIHBhcmFtZXRlcnMgdG8gYWNjb21tb2RhdGUgbW9y ZSBjb21wbGV4IG92ZXJyaWRlcyBvZgo+IG1vZHVsZV9hbGxvYygpIGJ5IGFyY2hpdGVjdHVyZXMu Cj4KPiBUaGlzIGluY2x1ZGVzIHNwZWNpZmljYXRpb24gb2YgYSBmYWxsYmFjayByYW5nZSByZXF1 aXJlZCBieSBhcm0sIGFybTY0Cj4gYW5kIHBvd2VycGMgYW5kIHN1cHBvcnQgZm9yIGFsbG9jYXRp b24gb2YgS0FTQU4gc2hhZG93IHJlcXVpcmVkIGJ5Cj4gYXJtNjQsIHMzOTAgYW5kIHg4Ni4KPgo+ IFRoZSBjb3JlIGltcGxlbWVudGF0aW9uIG9mIGppdF9hbGxvYygpIHRha2VzIGNhcmUgb2Ygc3Vw cHJlc3Npbmcgd2FybmluZ3MKPiB3aGVuIHRoZSBpbml0aWFsIGFsbG9jYXRpb24gZmFpbHMgYnV0 IHRoZXJlIGlzIGEgZmFsbGJhY2sgcmFuZ2UgZGVmaW5lZC4KPgo+IFNpZ25lZC1vZmYtYnk6IE1p a2UgUmFwb3BvcnQgKElCTSkgPHJwcHRAa2VybmVsLm9yZz4KClsuLi5dCgo+Cj4gZGlmZiAtLWdp dCBhL2FyY2gvYXJtNjQva2VybmVsL21vZHVsZS5jIGIvYXJjaC9hcm02NC9rZXJuZWwvbW9kdWxl LmMKPiBpbmRleCA1YWY0OTc1Y2FlYjUuLmVjZjFmNDAzMDMxNyAxMDA2NDQKPiAtLS0gYS9hcmNo L2FybTY0L2tlcm5lbC9tb2R1bGUuYwo+ICsrKyBiL2FyY2gvYXJtNjQva2VybmVsL21vZHVsZS5j Cj4gQEAgLTE3LDU2ICsxNyw0OSBAQAo+ICAjaW5jbHVkZSA8bGludXgvbW9kdWxlbG9hZGVyLmg+ Cj4gICNpbmNsdWRlIDxsaW51eC9zY3MuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3ZtYWxsb2MuaD4K PiArI2luY2x1ZGUgPGxpbnV4L2ppdGFsbG9jLmg+Cj4gICNpbmNsdWRlIDxhc20vYWx0ZXJuYXRp dmUuaD4KPiAgI2luY2x1ZGUgPGFzbS9pbnNuLmg+Cj4gICNpbmNsdWRlIDxhc20vc2NzLmg+Cj4g ICNpbmNsdWRlIDxhc20vc2VjdGlvbnMuaD4KPgo+IC12b2lkICptb2R1bGVfYWxsb2ModW5zaWdu ZWQgbG9uZyBzaXplKQo+ICtzdGF0aWMgc3RydWN0IGppdF9hbGxvY19wYXJhbXMgaml0X2FsbG9j X3BhcmFtcyA9IHsKPiArICAgICAgIC5hbGlnbm1lbnQgICAgICA9IE1PRFVMRV9BTElHTiwKPiAr ICAgICAgIC5mbGFncyAgICAgICAgICA9IEpJVF9BTExPQ19LQVNBTl9TSEFET1csCj4gK307Cj4g Kwo+ICtzdHJ1Y3Qgaml0X2FsbG9jX3BhcmFtcyAqaml0X2FsbG9jX2FyY2hfcGFyYW1zKHZvaWQp Cj4gIHsKPiAgICAgICAgIHU2NCBtb2R1bGVfYWxsb2NfZW5kID0gbW9kdWxlX2FsbG9jX2Jhc2Ug KyBNT0RVTEVTX1ZTSVpFOwoKbW9kdWxlX2FsbG9jX2Jhc2UoKSBpcyBpbml0aWFsaXplZCBpbiBr YXNscl9pbml0KCksIHdoaWNoIGlzIGNhbGxlZCBhZnRlcgptbV9jb3JlX2luaXQoKS4gV2Ugd2ls bCBuZWVkIHNvbWUgc3BlY2lhbCBsb2dpYyBmb3IgdGhpcy4KClRoYW5rcywKU29uZwoKPiAtICAg ICAgIGdmcF90IGdmcF9tYXNrID0gR0ZQX0tFUk5FTDsKPiAtICAgICAgIHZvaWQgKnA7Cj4gLQo+ IC0gICAgICAgLyogU2lsZW5jZSB0aGUgaW5pdGlhbCBhbGxvY2F0aW9uICovCj4gLSAgICAgICBp ZiAoSVNfRU5BQkxFRChDT05GSUdfQVJNNjRfTU9EVUxFX1BMVFMpKQo+IC0gICAgICAgICAgICAg ICBnZnBfbWFzayB8PSBfX0dGUF9OT1dBUk47Cj4KClsuLi5dCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==