From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2324E33F4 for ; Fri, 15 Apr 2022 23:52:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C15F6C385B8 for ; Fri, 15 Apr 2022 23:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650066745; bh=errT7JCib6AzTkVoGPltwDcZINvMpoIAWe1b0AzmVjQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qNxv7R7kwGBplr4pFmyq+iyauWnfSUOQxiEV1D253Qu6QckwiUPoV8kS8B7hDvkIF 8r/h9C9qoQH1xiKBFuj/MwKoZ2yrwUVOzdx0QQqGQdu6eIJ91rZ6zdZ3AFGmkUJLMx QeEhdcIHd+4kyqWYYERVkKlTGUBe8Tt33vmkE34mBM0rlflT0tTIeqCHkAPYy2m/Yi XL8JHpBzufzAHD7Lh80CX6Zg+a/JNDywq9F5odVU9gXMoiEOWmSle+Uqx/Gq0yrHeM Rzwu6FWkxKLl9ptrE4BaqBMNgBwR02nEefskx1y9zRueUrC/vgsuzK78JSe9f3Tzpm GAMzI5xhgbiwA== Received: by mail-yb1-f180.google.com with SMTP id m132so16716521ybm.4 for ; Fri, 15 Apr 2022 16:52:25 -0700 (PDT) X-Gm-Message-State: AOAM531AHose9Cu5cVe90Y1WdRA7CxcQWd4GikmshaRVYqmB8pj+1osV vWDk4sbZIwJSbOyZ0hnKrPaqSBwNueJ11aV35jM= X-Google-Smtp-Source: ABdhPJx72bmk61XUaqJvL+i1XHxlM70OjJc/9IRT4lbbDvxH0qPpB5kgaRzVhtGK/RofPmCZoqlatSkJeo/Au/tdM30= X-Received: by 2002:a25:8b81:0:b0:629:17d5:68c1 with SMTP id j1-20020a258b81000000b0062917d568c1mr1296810ybl.449.1650066744755; Fri, 15 Apr 2022 16:52:24 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220414223704.341028-1-alobakin@pm.me> <20220414223704.341028-8-alobakin@pm.me> In-Reply-To: <20220414223704.341028-8-alobakin@pm.me> From: Song Liu Date: Fri, 15 Apr 2022 16:52:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next 07/11] samples: bpf: fix uin64_t format literals To: Alexander Lobakin Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Jonathan Lemon , Nathan Chancellor , Nick Desaulniers , Dmitrii Dolgov <9erthalion6@gmail.com>, Quentin Monnet , Tiezhu Yang , Kumar Kartikeya Dwivedi , Chenbo Feng , Willem de Bruijn , Daniel Wagner , Thomas Graf , Ong Boon Leong , linux-perf-users@vger.kernel.org, open list , Networking , bpf , llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Thu, Apr 14, 2022 at 3:46 PM Alexander Lobakin wrote: > > There's a couple places where uin64_t is being passed as an %ld > format argument, which is incorrect (should be %lld). Fix them. This will cause some warning on some 64-bit compiler, no? Song > > Fixes: 51570a5ab2b7 ("A Sample of using socket cookie and uid for traffic monitoring") > Fixes: 00f660eaf378 ("Sample program using SO_COOKIE") > Signed-off-by: Alexander Lobakin > --- > samples/bpf/cookie_uid_helper_example.c | 12 ++++++------ > samples/bpf/lwt_len_hist_user.c | 4 ++-- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/samples/bpf/cookie_uid_helper_example.c b/samples/bpf/cookie_uid_helper_example.c > index f0df3dda4b1f..1b98debb6019 100644 > --- a/samples/bpf/cookie_uid_helper_example.c > +++ b/samples/bpf/cookie_uid_helper_example.c > @@ -207,9 +207,9 @@ static void print_table(void) > error(1, errno, "fail to get entry value of Key: %u\n", > curN); > } else { > - printf("cookie: %u, uid: 0x%x, Packet Count: %lu," > - " Bytes Count: %lu\n", curN, curEntry.uid, > - curEntry.packets, curEntry.bytes); > + printf("cookie: %u, uid: 0x%x, Packet Count: %llu, Bytes Count: %llu\n", > + curN, curEntry.uid, curEntry.packets, > + curEntry.bytes); > } > } > } > @@ -265,9 +265,9 @@ static void udp_client(void) > if (res < 0) > error(1, errno, "lookup sk stat failed, cookie: %lu\n", > cookie); > - printf("cookie: %lu, uid: 0x%x, Packet Count: %lu," > - " Bytes Count: %lu\n\n", cookie, dataEntry.uid, > - dataEntry.packets, dataEntry.bytes); > + printf("cookie: %llu, uid: 0x%x, Packet Count: %llu, Bytes Count: %llu\n\n", > + cookie, dataEntry.uid, dataEntry.packets, > + dataEntry.bytes); > } > close(s_send); > close(s_rcv); > diff --git a/samples/bpf/lwt_len_hist_user.c b/samples/bpf/lwt_len_hist_user.c > index 430a4b7e353e..4ef22571aa67 100644 > --- a/samples/bpf/lwt_len_hist_user.c > +++ b/samples/bpf/lwt_len_hist_user.c > @@ -44,7 +44,7 @@ int main(int argc, char **argv) > > while (bpf_map_get_next_key(map_fd, &key, &next_key) == 0) { > if (next_key >= MAX_INDEX) { > - fprintf(stderr, "Key %lu out of bounds\n", next_key); > + fprintf(stderr, "Key %llu out of bounds\n", next_key); > continue; > } > > @@ -66,7 +66,7 @@ int main(int argc, char **argv) > > for (i = 1; i <= max_key + 1; i++) { > stars(starstr, data[i - 1], max_value, MAX_STARS); > - printf("%8ld -> %-8ld : %-8ld |%-*s|\n", > + printf("%8ld -> %-8ld : %-8lld |%-*s|\n", > (1l << i) >> 1, (1l << i) - 1, data[i - 1], > MAX_STARS, starstr); > } > -- > 2.35.2 > >