From mboxrd@z Thu Jan 1 00:00:00 1970 From: Song Liu Subject: Re: [bpf-next V2 PATCH 0/3] bpf/xdp: fix generic-XDP and demonstrate VLAN manipulation Date: Tue, 9 Oct 2018 11:47:49 -0700 Message-ID: References: <153907945478.9484.16223890803803124822.stgit@firesoul> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Networking , Daniel Borkmann , yoel@kviknet.dk, Alexei Starovoitov , John Fastabend To: Jesper Dangaard Brouer Return-path: Received: from mail-qk1-f195.google.com ([209.85.222.195]:36939 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbeJJCGW (ORCPT ); Tue, 9 Oct 2018 22:06:22 -0400 Received: by mail-qk1-f195.google.com with SMTP id x8-v6so1625124qka.4 for ; Tue, 09 Oct 2018 11:48:01 -0700 (PDT) In-Reply-To: <153907945478.9484.16223890803803124822.stgit@firesoul> Sender: netdev-owner@vger.kernel.org List-ID: For the series: Acked-by: Song Liu On Tue, Oct 9, 2018 at 3:04 AM Jesper Dangaard Brouer wrote: > > While implementing PoC building blocks for eBPF code XDP+TC that can > manipulate VLANs headers, I discovered a bug in generic-XDP. > > The fix should be backported to stable kernels. Even-though > generic-XDP was introduced in v4.12, I think the bug is not exposed > until v4.14 in the mentined fixes commit. > > --- > > Jesper Dangaard Brouer (3): > net: fix generic XDP to handle if eth header was mangled > bpf: make TC vlan bpf_helpers avail to selftests > selftests/bpf: add XDP selftests for modifying and popping VLAN headers > > > net/core/dev.c | 14 + > tools/testing/selftests/bpf/Makefile | 6 - > tools/testing/selftests/bpf/bpf_helpers.h | 4 > tools/testing/selftests/bpf/test_xdp_vlan.c | 292 ++++++++++++++++++++++++++ > tools/testing/selftests/bpf/test_xdp_vlan.sh | 195 +++++++++++++++++ > 5 files changed, 509 insertions(+), 2 deletions(-) > create mode 100644 tools/testing/selftests/bpf/test_xdp_vlan.c > create mode 100755 tools/testing/selftests/bpf/test_xdp_vlan.sh > > --