From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D271B17F4 for ; Mon, 5 Jun 2023 04:06:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 610BBC433EF for ; Mon, 5 Jun 2023 04:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685937961; bh=WtI1jY3mnr9zb4/0mcezfP7YgsPqPtpWRWa72DAZTTg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=uxKGktXNqn49bEfc54rxrLont7pLs83GyZuzAufBwsGBjuGMKdcRP/bEdwYmfXXxU WvxTYj5OfeXmTt5HLnDLwPgr67Lkt70CP1EvdU2veiDINIXLIDAS+iKL+CqrOBDxNc W/VQJXu20GHLghTy7G8UfIn1gM+F5ueXv0na8lU8CSN0FmokvQ65P4mX8K8i05YG/W fPh72tKYwA3H59nPmnDH3bp9qH5k5y+9C+A7tg1dtcxIc9fAAEgtE2WRW9gNO+56RG rnpEhaZc8TsRLxnuELVYU2NxAebO69dROiM74lzh42BNKszJ2YPFsTB9bCrjTQGdS0 SNLJmYWsBwYSA== Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2b1b30445cfso32412961fa.1 for ; Sun, 04 Jun 2023 21:06:01 -0700 (PDT) X-Gm-Message-State: AC+VfDyB47OlB5s49qQM6MPFNmPDZ5x+NoZcQ1eyzhFLdtrArws6qSqD 3fdifPTqxiFRIYa2WIjVJ2RSGVqVR626WTL/Vts= X-Google-Smtp-Source: ACHHUZ5GrSEK3PQNTobRaaPR4GI9Q/dG/dH9vtDqov4NPtsLbAuvSoOBGIqnwRO1u3fwexaWyE5OrfsdUvjgUci7FZk= X-Received: by 2002:a2e:2419:0:b0:2ad:d6cd:efdd with SMTP id k25-20020a2e2419000000b002add6cdefddmr3089294ljk.32.1685937959380; Sun, 04 Jun 2023 21:05:59 -0700 (PDT) Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230601101257.530867-1-rppt@kernel.org> In-Reply-To: From: Song Liu Date: Sun, 4 Jun 2023 21:05:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/13] mm: jit/text allocator To: Kent Overstreet Cc: Mark Rutland , Mike Rapoport , linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, Puranjay Mohan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jun 4, 2023 at 2:40=E2=80=AFPM Kent Overstreet wrote: > > On Sun, Jun 04, 2023 at 02:22:30PM -0700, Song Liu wrote: > > On Sun, Jun 4, 2023 at 11:02=E2=80=AFAM Kent Overstreet > > wrote: > > > > > > On Fri, Jun 02, 2023 at 11:20:58AM -0700, Song Liu wrote: > > > > IIUC, arm64 uses VMALLOC address space for BPF programs. The reason > > > > is each BPF program uses at least 64kB (one page) out of the 128MB > > > > address space. Puranjay Mohan (CC'ed) is working on enabling > > > > bpf_prog_pack for arm64. Once this work is done, multiple BPF progr= ams > > > > will be able to share a page. Will this improvement remove the need= to > > > > specify a different address range for BPF programs? > > > > > > Can we please stop working on BPF specific sub page allocation and fo= cus > > > on doing this in mm/? This never should have been in BPF in the first > > > place. > > > > That work is mostly independent of the allocator work we are discussing= here. > > The goal Puranjay's work is to enable the arm64 BPF JIT engine to use a > > ROX allocator. The allocator could be the bpf_prog_pack allocator, or j= italloc, > > or module_alloc_type. Puranjay is using bpf_prog_alloc for now. But onc= e > > jitalloc or module_alloc_type (either one) is merged, we will migrate B= PF > > JIT engines (x86_64 and arm64) to the new allocator and then tear down > > bpf_prog_pack. > > > > Does this make sense? > > Yeah, as long as that's the plan. Maybe one of you could tell us what > issues were preventing prog_pack from being used in the first place, it > might be relevant - this is the time to get the new allocator API right. The JIT engine does a lot of writes. Instead of doing many text_poke(), we are using a temporary RW write buffer, and then do text_poke_copy() at the end. To make this work, we need the JIT engine to be able to handle an RW temporary buffer and an RO final memory region. There is nothing preventing prog_pack to work. It is just we need to do the work. Thanks, Song From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00C02C7EE2C for ; Mon, 5 Jun 2023 04:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OrRKiSTdSQO1jhH5gdcNOB2yXMNLy1f+XnZNTUlxB+4=; b=yarHWqrAvNVvit PKMTKZqnnxMhcRGCaUYO1sc86RAJoTqypSyGXbFablnn+Kq9EXCak9CL9SkARo7TPf9I/Ljgxfb2/ MunsgfLuhE7q6NMZq5zJdRA/UzjrSmoekKdpXE25dvDqUCVE4f+OFza7Cb3Dx+60laqdX355Awjs6 g++YBF3tvcMCNrjtoBWC4iVoW+kultF61S6cP0NqufCP1lweipn29nYCKLv/se/c4ZlNAHYwCfm0S zGORwM+hCZEeXVHdqEVi+vjR49ffVpEnzvgV681MklPN2r9KiJNLs1IkK2V5mhzXOIZiW91b3LFFD zTwxcgsZDNLFfTlz99NA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q61Tq-00E1Fs-27; Mon, 05 Jun 2023 04:06:06 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q61Tm-00E1Do-31; Mon, 05 Jun 2023 04:06:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA76D60FE5; Mon, 5 Jun 2023 04:06:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AFCEC433D2; Mon, 5 Jun 2023 04:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685937961; bh=WtI1jY3mnr9zb4/0mcezfP7YgsPqPtpWRWa72DAZTTg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=uxKGktXNqn49bEfc54rxrLont7pLs83GyZuzAufBwsGBjuGMKdcRP/bEdwYmfXXxU WvxTYj5OfeXmTt5HLnDLwPgr67Lkt70CP1EvdU2veiDINIXLIDAS+iKL+CqrOBDxNc W/VQJXu20GHLghTy7G8UfIn1gM+F5ueXv0na8lU8CSN0FmokvQ65P4mX8K8i05YG/W fPh72tKYwA3H59nPmnDH3bp9qH5k5y+9C+A7tg1dtcxIc9fAAEgtE2WRW9gNO+56RG rnpEhaZc8TsRLxnuELVYU2NxAebO69dROiM74lzh42BNKszJ2YPFsTB9bCrjTQGdS0 SNLJmYWsBwYSA== Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2b1afe57bdfso34310281fa.0; Sun, 04 Jun 2023 21:06:01 -0700 (PDT) X-Gm-Message-State: AC+VfDxQpeHsXWwbcdd8UEAI+ppNUW8lmVk9TkNh5yR4j/vzE3RsG+iS PZD23THObF8f8t7Hjx8gOn7AEzGxHh7p46o6bc4= X-Google-Smtp-Source: ACHHUZ5GrSEK3PQNTobRaaPR4GI9Q/dG/dH9vtDqov4NPtsLbAuvSoOBGIqnwRO1u3fwexaWyE5OrfsdUvjgUci7FZk= X-Received: by 2002:a2e:2419:0:b0:2ad:d6cd:efdd with SMTP id k25-20020a2e2419000000b002add6cdefddmr3089294ljk.32.1685937959380; Sun, 04 Jun 2023 21:05:59 -0700 (PDT) MIME-Version: 1.0 References: <20230601101257.530867-1-rppt@kernel.org> In-Reply-To: From: Song Liu Date: Sun, 4 Jun 2023 21:05:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/13] mm: jit/text allocator To: Kent Overstreet Cc: Mark Rutland , Mike Rapoport , linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, Puranjay Mohan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230604_210603_082710_CEDE4799 X-CRM114-Status: GOOD ( 27.40 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gU3VuLCBKdW4gNCwgMjAyMyBhdCAyOjQw4oCvUE0gS2VudCBPdmVyc3RyZWV0CjxrZW50Lm92 ZXJzdHJlZXRAbGludXguZGV2PiB3cm90ZToKPgo+IE9uIFN1biwgSnVuIDA0LCAyMDIzIGF0IDAy OjIyOjMwUE0gLTA3MDAsIFNvbmcgTGl1IHdyb3RlOgo+ID4gT24gU3VuLCBKdW4gNCwgMjAyMyBh dCAxMTowMuKAr0FNIEtlbnQgT3ZlcnN0cmVldAo+ID4gPGtlbnQub3ZlcnN0cmVldEBsaW51eC5k ZXY+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBGcmksIEp1biAwMiwgMjAyMyBhdCAxMToyMDo1OEFN IC0wNzAwLCBTb25nIExpdSB3cm90ZToKPiA+ID4gPiBJSVVDLCBhcm02NCB1c2VzIFZNQUxMT0Mg YWRkcmVzcyBzcGFjZSBmb3IgQlBGIHByb2dyYW1zLiBUaGUgcmVhc29uCj4gPiA+ID4gaXMgZWFj aCBCUEYgcHJvZ3JhbSB1c2VzIGF0IGxlYXN0IDY0a0IgKG9uZSBwYWdlKSBvdXQgb2YgdGhlIDEy OE1CCj4gPiA+ID4gYWRkcmVzcyBzcGFjZS4gUHVyYW5qYXkgTW9oYW4gKENDJ2VkKSBpcyB3b3Jr aW5nIG9uIGVuYWJsaW5nCj4gPiA+ID4gYnBmX3Byb2dfcGFjayBmb3IgYXJtNjQuIE9uY2UgdGhp cyB3b3JrIGlzIGRvbmUsIG11bHRpcGxlIEJQRiBwcm9ncmFtcwo+ID4gPiA+IHdpbGwgYmUgYWJs ZSB0byBzaGFyZSBhIHBhZ2UuIFdpbGwgdGhpcyBpbXByb3ZlbWVudCByZW1vdmUgdGhlIG5lZWQg dG8KPiA+ID4gPiBzcGVjaWZ5IGEgZGlmZmVyZW50IGFkZHJlc3MgcmFuZ2UgZm9yIEJQRiBwcm9n cmFtcz8KPiA+ID4KPiA+ID4gQ2FuIHdlIHBsZWFzZSBzdG9wIHdvcmtpbmcgb24gQlBGIHNwZWNp ZmljIHN1YiBwYWdlIGFsbG9jYXRpb24gYW5kIGZvY3VzCj4gPiA+IG9uIGRvaW5nIHRoaXMgaW4g bW0vPyBUaGlzIG5ldmVyIHNob3VsZCBoYXZlIGJlZW4gaW4gQlBGIGluIHRoZSBmaXJzdAo+ID4g PiBwbGFjZS4KPiA+Cj4gPiBUaGF0IHdvcmsgaXMgbW9zdGx5IGluZGVwZW5kZW50IG9mIHRoZSBh bGxvY2F0b3Igd29yayB3ZSBhcmUgZGlzY3Vzc2luZyBoZXJlLgo+ID4gVGhlIGdvYWwgUHVyYW5q YXkncyB3b3JrIGlzIHRvIGVuYWJsZSB0aGUgYXJtNjQgQlBGIEpJVCBlbmdpbmUgdG8gdXNlIGEK PiA+IFJPWCBhbGxvY2F0b3IuIFRoZSBhbGxvY2F0b3IgY291bGQgYmUgdGhlIGJwZl9wcm9nX3Bh Y2sgYWxsb2NhdG9yLCBvciBqaXRhbGxvYywKPiA+IG9yIG1vZHVsZV9hbGxvY190eXBlLiBQdXJh bmpheSBpcyB1c2luZyBicGZfcHJvZ19hbGxvYyBmb3Igbm93LiBCdXQgb25jZQo+ID4gaml0YWxs b2Mgb3IgbW9kdWxlX2FsbG9jX3R5cGUgKGVpdGhlciBvbmUpIGlzIG1lcmdlZCwgd2Ugd2lsbCBt aWdyYXRlIEJQRgo+ID4gSklUIGVuZ2luZXMgKHg4Nl82NCBhbmQgYXJtNjQpIHRvIHRoZSBuZXcg YWxsb2NhdG9yIGFuZCB0aGVuIHRlYXIgZG93bgo+ID4gYnBmX3Byb2dfcGFjay4KPiA+Cj4gPiBE b2VzIHRoaXMgbWFrZSBzZW5zZT8KPgo+IFllYWgsIGFzIGxvbmcgYXMgdGhhdCdzIHRoZSBwbGFu LiBNYXliZSBvbmUgb2YgeW91IGNvdWxkIHRlbGwgdXMgd2hhdAo+IGlzc3VlcyB3ZXJlIHByZXZl bnRpbmcgcHJvZ19wYWNrIGZyb20gYmVpbmcgdXNlZCBpbiB0aGUgZmlyc3QgcGxhY2UsIGl0Cj4g bWlnaHQgYmUgcmVsZXZhbnQgLSB0aGlzIGlzIHRoZSB0aW1lIHRvIGdldCB0aGUgbmV3IGFsbG9j YXRvciBBUEkgcmlnaHQuCgpUaGUgSklUIGVuZ2luZSBkb2VzIGEgbG90IG9mIHdyaXRlcy4gSW5z dGVhZCBvZiBkb2luZyBtYW55IHRleHRfcG9rZSgpLAp3ZSBhcmUgdXNpbmcgYSB0ZW1wb3Jhcnkg Ulcgd3JpdGUgYnVmZmVyLCBhbmQgdGhlbiBkbyB0ZXh0X3Bva2VfY29weSgpCmF0IHRoZSBlbmQu IFRvIG1ha2UgdGhpcyB3b3JrLCB3ZSBuZWVkIHRoZSBKSVQgZW5naW5lIHRvIGJlIGFibGUgdG8K aGFuZGxlIGFuIFJXIHRlbXBvcmFyeSBidWZmZXIgYW5kIGFuIFJPIGZpbmFsIG1lbW9yeSByZWdp b24uIFRoZXJlCmlzIG5vdGhpbmcgcHJldmVudGluZyBwcm9nX3BhY2sgdG8gd29yay4gSXQgaXMg anVzdCB3ZSBuZWVkIHRvIGRvIHRoZQp3b3JrLgoKVGhhbmtzLApTb25nCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxp c3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D037DC7EE24 for ; Mon, 5 Jun 2023 04:06:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zUEU1wWd4XdDQPpMZGhqudRKsGjxw9/sBJPiMhbEFZY=; b=CQTROhdlqbRfhe OgoB+hO9W2spA1tjVcGkvk63+Nu12ixT0U8nEKdBTYVN3hhqxIr4rkc9xViMKq/PAPTDriFnEUgKu RXor23VM1q00lEtGixiseS74nbRE36OPOZ7lk7T1OAIGzTuXrCX2lO94GMlobBZoy80fO7eRS+9Ta yFILdNV6btRKZldyexTTBku5M4PKahWhW/hht2h1b1yrFScq8EUn8yIMl9I6DNIoP9ggeTrRoTKHY xNy4B5OVJktjV8pTJP9iNO56gNrlj1ici/uV8V2nUNGge0xxqcuIq1yJjkIUU01jQ/Ru/0lJiu8tw G/LKqI46cJ3YhJ46IhtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q61Tq-00E1FS-0R; Mon, 05 Jun 2023 04:06:06 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q61Tm-00E1Do-31; Mon, 05 Jun 2023 04:06:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA76D60FE5; Mon, 5 Jun 2023 04:06:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AFCEC433D2; Mon, 5 Jun 2023 04:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685937961; bh=WtI1jY3mnr9zb4/0mcezfP7YgsPqPtpWRWa72DAZTTg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=uxKGktXNqn49bEfc54rxrLont7pLs83GyZuzAufBwsGBjuGMKdcRP/bEdwYmfXXxU WvxTYj5OfeXmTt5HLnDLwPgr67Lkt70CP1EvdU2veiDINIXLIDAS+iKL+CqrOBDxNc W/VQJXu20GHLghTy7G8UfIn1gM+F5ueXv0na8lU8CSN0FmokvQ65P4mX8K8i05YG/W fPh72tKYwA3H59nPmnDH3bp9qH5k5y+9C+A7tg1dtcxIc9fAAEgtE2WRW9gNO+56RG rnpEhaZc8TsRLxnuELVYU2NxAebO69dROiM74lzh42BNKszJ2YPFsTB9bCrjTQGdS0 SNLJmYWsBwYSA== Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2b1afe57bdfso34310281fa.0; Sun, 04 Jun 2023 21:06:01 -0700 (PDT) X-Gm-Message-State: AC+VfDxQpeHsXWwbcdd8UEAI+ppNUW8lmVk9TkNh5yR4j/vzE3RsG+iS PZD23THObF8f8t7Hjx8gOn7AEzGxHh7p46o6bc4= X-Google-Smtp-Source: ACHHUZ5GrSEK3PQNTobRaaPR4GI9Q/dG/dH9vtDqov4NPtsLbAuvSoOBGIqnwRO1u3fwexaWyE5OrfsdUvjgUci7FZk= X-Received: by 2002:a2e:2419:0:b0:2ad:d6cd:efdd with SMTP id k25-20020a2e2419000000b002add6cdefddmr3089294ljk.32.1685937959380; Sun, 04 Jun 2023 21:05:59 -0700 (PDT) MIME-Version: 1.0 References: <20230601101257.530867-1-rppt@kernel.org> In-Reply-To: From: Song Liu Date: Sun, 4 Jun 2023 21:05:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/13] mm: jit/text allocator To: Kent Overstreet Cc: Mark Rutland , Mike Rapoport , linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Luis Chamberlain , Michael Ellerman , "Naveen N. Rao" , Palmer Dabbelt , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, Puranjay Mohan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230604_210603_082710_CEDE4799 X-CRM114-Status: GOOD ( 27.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCBKdW4gNCwgMjAyMyBhdCAyOjQw4oCvUE0gS2VudCBPdmVyc3RyZWV0CjxrZW50Lm92 ZXJzdHJlZXRAbGludXguZGV2PiB3cm90ZToKPgo+IE9uIFN1biwgSnVuIDA0LCAyMDIzIGF0IDAy OjIyOjMwUE0gLTA3MDAsIFNvbmcgTGl1IHdyb3RlOgo+ID4gT24gU3VuLCBKdW4gNCwgMjAyMyBh dCAxMTowMuKAr0FNIEtlbnQgT3ZlcnN0cmVldAo+ID4gPGtlbnQub3ZlcnN0cmVldEBsaW51eC5k ZXY+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBGcmksIEp1biAwMiwgMjAyMyBhdCAxMToyMDo1OEFN IC0wNzAwLCBTb25nIExpdSB3cm90ZToKPiA+ID4gPiBJSVVDLCBhcm02NCB1c2VzIFZNQUxMT0Mg YWRkcmVzcyBzcGFjZSBmb3IgQlBGIHByb2dyYW1zLiBUaGUgcmVhc29uCj4gPiA+ID4gaXMgZWFj aCBCUEYgcHJvZ3JhbSB1c2VzIGF0IGxlYXN0IDY0a0IgKG9uZSBwYWdlKSBvdXQgb2YgdGhlIDEy OE1CCj4gPiA+ID4gYWRkcmVzcyBzcGFjZS4gUHVyYW5qYXkgTW9oYW4gKENDJ2VkKSBpcyB3b3Jr aW5nIG9uIGVuYWJsaW5nCj4gPiA+ID4gYnBmX3Byb2dfcGFjayBmb3IgYXJtNjQuIE9uY2UgdGhp cyB3b3JrIGlzIGRvbmUsIG11bHRpcGxlIEJQRiBwcm9ncmFtcwo+ID4gPiA+IHdpbGwgYmUgYWJs ZSB0byBzaGFyZSBhIHBhZ2UuIFdpbGwgdGhpcyBpbXByb3ZlbWVudCByZW1vdmUgdGhlIG5lZWQg dG8KPiA+ID4gPiBzcGVjaWZ5IGEgZGlmZmVyZW50IGFkZHJlc3MgcmFuZ2UgZm9yIEJQRiBwcm9n cmFtcz8KPiA+ID4KPiA+ID4gQ2FuIHdlIHBsZWFzZSBzdG9wIHdvcmtpbmcgb24gQlBGIHNwZWNp ZmljIHN1YiBwYWdlIGFsbG9jYXRpb24gYW5kIGZvY3VzCj4gPiA+IG9uIGRvaW5nIHRoaXMgaW4g bW0vPyBUaGlzIG5ldmVyIHNob3VsZCBoYXZlIGJlZW4gaW4gQlBGIGluIHRoZSBmaXJzdAo+ID4g PiBwbGFjZS4KPiA+Cj4gPiBUaGF0IHdvcmsgaXMgbW9zdGx5IGluZGVwZW5kZW50IG9mIHRoZSBh bGxvY2F0b3Igd29yayB3ZSBhcmUgZGlzY3Vzc2luZyBoZXJlLgo+ID4gVGhlIGdvYWwgUHVyYW5q YXkncyB3b3JrIGlzIHRvIGVuYWJsZSB0aGUgYXJtNjQgQlBGIEpJVCBlbmdpbmUgdG8gdXNlIGEK PiA+IFJPWCBhbGxvY2F0b3IuIFRoZSBhbGxvY2F0b3IgY291bGQgYmUgdGhlIGJwZl9wcm9nX3Bh Y2sgYWxsb2NhdG9yLCBvciBqaXRhbGxvYywKPiA+IG9yIG1vZHVsZV9hbGxvY190eXBlLiBQdXJh bmpheSBpcyB1c2luZyBicGZfcHJvZ19hbGxvYyBmb3Igbm93LiBCdXQgb25jZQo+ID4gaml0YWxs b2Mgb3IgbW9kdWxlX2FsbG9jX3R5cGUgKGVpdGhlciBvbmUpIGlzIG1lcmdlZCwgd2Ugd2lsbCBt aWdyYXRlIEJQRgo+ID4gSklUIGVuZ2luZXMgKHg4Nl82NCBhbmQgYXJtNjQpIHRvIHRoZSBuZXcg YWxsb2NhdG9yIGFuZCB0aGVuIHRlYXIgZG93bgo+ID4gYnBmX3Byb2dfcGFjay4KPiA+Cj4gPiBE b2VzIHRoaXMgbWFrZSBzZW5zZT8KPgo+IFllYWgsIGFzIGxvbmcgYXMgdGhhdCdzIHRoZSBwbGFu LiBNYXliZSBvbmUgb2YgeW91IGNvdWxkIHRlbGwgdXMgd2hhdAo+IGlzc3VlcyB3ZXJlIHByZXZl bnRpbmcgcHJvZ19wYWNrIGZyb20gYmVpbmcgdXNlZCBpbiB0aGUgZmlyc3QgcGxhY2UsIGl0Cj4g bWlnaHQgYmUgcmVsZXZhbnQgLSB0aGlzIGlzIHRoZSB0aW1lIHRvIGdldCB0aGUgbmV3IGFsbG9j YXRvciBBUEkgcmlnaHQuCgpUaGUgSklUIGVuZ2luZSBkb2VzIGEgbG90IG9mIHdyaXRlcy4gSW5z dGVhZCBvZiBkb2luZyBtYW55IHRleHRfcG9rZSgpLAp3ZSBhcmUgdXNpbmcgYSB0ZW1wb3Jhcnkg Ulcgd3JpdGUgYnVmZmVyLCBhbmQgdGhlbiBkbyB0ZXh0X3Bva2VfY29weSgpCmF0IHRoZSBlbmQu IFRvIG1ha2UgdGhpcyB3b3JrLCB3ZSBuZWVkIHRoZSBKSVQgZW5naW5lIHRvIGJlIGFibGUgdG8K aGFuZGxlIGFuIFJXIHRlbXBvcmFyeSBidWZmZXIgYW5kIGFuIFJPIGZpbmFsIG1lbW9yeSByZWdp b24uIFRoZXJlCmlzIG5vdGhpbmcgcHJldmVudGluZyBwcm9nX3BhY2sgdG8gd29yay4gSXQgaXMg anVzdCB3ZSBuZWVkIHRvIGRvIHRoZQp3b3JrLgoKVGhhbmtzLApTb25nCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AC50C7EE2C for ; Mon, 5 Jun 2023 04:06:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QZKmw1HTWz3f6Z for ; Mon, 5 Jun 2023 14:06:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=uxKGktXN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=song@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=uxKGktXN; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QZKlw05kjz3cCc for ; Mon, 5 Jun 2023 14:06:03 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA48E60C3D for ; Mon, 5 Jun 2023 04:06:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E194C4339B for ; Mon, 5 Jun 2023 04:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685937961; bh=WtI1jY3mnr9zb4/0mcezfP7YgsPqPtpWRWa72DAZTTg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=uxKGktXNqn49bEfc54rxrLont7pLs83GyZuzAufBwsGBjuGMKdcRP/bEdwYmfXXxU WvxTYj5OfeXmTt5HLnDLwPgr67Lkt70CP1EvdU2veiDINIXLIDAS+iKL+CqrOBDxNc W/VQJXu20GHLghTy7G8UfIn1gM+F5ueXv0na8lU8CSN0FmokvQ65P4mX8K8i05YG/W fPh72tKYwA3H59nPmnDH3bp9qH5k5y+9C+A7tg1dtcxIc9fAAEgtE2WRW9gNO+56RG rnpEhaZc8TsRLxnuELVYU2NxAebO69dROiM74lzh42BNKszJ2YPFsTB9bCrjTQGdS0 SNLJmYWsBwYSA== Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2b1b6865c7cso28305131fa.3 for ; Sun, 04 Jun 2023 21:06:01 -0700 (PDT) X-Gm-Message-State: AC+VfDy5FzrVg5siq9afnVNOl4F/Mz9pJ734P9YlY0AxR/BCi9TU9TD9 F+lanURDiUc+XdOZ560j39xj9RKkBe8SkNTZ4QM= X-Google-Smtp-Source: ACHHUZ5GrSEK3PQNTobRaaPR4GI9Q/dG/dH9vtDqov4NPtsLbAuvSoOBGIqnwRO1u3fwexaWyE5OrfsdUvjgUci7FZk= X-Received: by 2002:a2e:2419:0:b0:2ad:d6cd:efdd with SMTP id k25-20020a2e2419000000b002add6cdefddmr3089294ljk.32.1685937959380; Sun, 04 Jun 2023 21:05:59 -0700 (PDT) MIME-Version: 1.0 References: <20230601101257.530867-1-rppt@kernel.org> In-Reply-To: From: Song Liu Date: Sun, 4 Jun 2023 21:05:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/13] mm: jit/text allocator To: Kent Overstreet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , x86@kernel.org, Catalin Marinas , linux-mips@vger.kernel.org, linux-mm@kvack.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , linux-s390@vger.kernel.org, Helge Deller , Huacai Chen , Russell King , "Naveen N. Rao" , linux-trace-kernel@vger.kernel.org, Heiko Carstens , Steven Rostedt , loongarch@lists.linux.dev, Thomas Gleixner , Andrew Morton , linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Puranjay Mohan , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dinh Nguyen , Luis Chamberlain , Palmer Dabbelt , linux-modules@vger.kernel.org, bpf@vger.k ernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, Jun 4, 2023 at 2:40=E2=80=AFPM Kent Overstreet wrote: > > On Sun, Jun 04, 2023 at 02:22:30PM -0700, Song Liu wrote: > > On Sun, Jun 4, 2023 at 11:02=E2=80=AFAM Kent Overstreet > > wrote: > > > > > > On Fri, Jun 02, 2023 at 11:20:58AM -0700, Song Liu wrote: > > > > IIUC, arm64 uses VMALLOC address space for BPF programs. The reason > > > > is each BPF program uses at least 64kB (one page) out of the 128MB > > > > address space. Puranjay Mohan (CC'ed) is working on enabling > > > > bpf_prog_pack for arm64. Once this work is done, multiple BPF progr= ams > > > > will be able to share a page. Will this improvement remove the need= to > > > > specify a different address range for BPF programs? > > > > > > Can we please stop working on BPF specific sub page allocation and fo= cus > > > on doing this in mm/? This never should have been in BPF in the first > > > place. > > > > That work is mostly independent of the allocator work we are discussing= here. > > The goal Puranjay's work is to enable the arm64 BPF JIT engine to use a > > ROX allocator. The allocator could be the bpf_prog_pack allocator, or j= italloc, > > or module_alloc_type. Puranjay is using bpf_prog_alloc for now. But onc= e > > jitalloc or module_alloc_type (either one) is merged, we will migrate B= PF > > JIT engines (x86_64 and arm64) to the new allocator and then tear down > > bpf_prog_pack. > > > > Does this make sense? > > Yeah, as long as that's the plan. Maybe one of you could tell us what > issues were preventing prog_pack from being used in the first place, it > might be relevant - this is the time to get the new allocator API right. The JIT engine does a lot of writes. Instead of doing many text_poke(), we are using a temporary RW write buffer, and then do text_poke_copy() at the end. To make this work, we need the JIT engine to be able to handle an RW temporary buffer and an RO final memory region. There is nothing preventing prog_pack to work. It is just we need to do the work. Thanks, Song