From: Song Liu <song@kernel.org>
To: Guoqing Jiang <guoqing.jiang@linux.dev>
Cc: Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
linux-raid <linux-raid@vger.kernel.org>,
linux-block@vger.kernel.org
Subject: Re: [PATCH V4] raid1: ensure write behind bio has less than BIO_MAX_VECS sectors
Date: Thu, 26 Aug 2021 09:16:56 -0700 [thread overview]
Message-ID: <CAPhsuW7jYhOCsTcoT54_y12RWLw-wj3iPGO1a=vd37L7khxn3g@mail.gmail.com> (raw)
In-Reply-To: <01dec1bc-5e3a-4237-6280-f0a480e6231f@linux.dev>
On Tue, Aug 24, 2021 at 5:44 PM Guoqing Jiang <guoqing.jiang@linux.dev> wrote:
>
>
>
> On 8/25/21 5:55 AM, Song Liu wrote:
> > On Mon, Aug 23, 2021 at 6:17 PM Guoqing Jiang <guoqing.jiang@linux.dev> wrote:
> >> From: Guoqing Jiang <jiangguoqing@kylinos.cn>
> >>
> >> We can't split write behind bio with more than BIO_MAX_VECS sectors,
> >> otherwise the below call trace was triggered because we could allocate
> >> oversized write behind bio later.
> >>
> >> [ 8.097936] bvec_alloc+0x90/0xc0
> >> [ 8.098934] bio_alloc_bioset+0x1b3/0x260
> >> [ 8.099959] raid1_make_request+0x9ce/0xc50 [raid1]
> >> [ 8.100988] ? __bio_clone_fast+0xa8/0xe0
> >> [ 8.102008] md_handle_request+0x158/0x1d0 [md_mod]
> >> [ 8.103050] md_submit_bio+0xcd/0x110 [md_mod]
> >> [ 8.104084] submit_bio_noacct+0x139/0x530
> >> [ 8.105127] submit_bio+0x78/0x1d0
> >> [ 8.106163] ext4_io_submit+0x48/0x60 [ext4]
> >> [ 8.107242] ext4_writepages+0x652/0x1170 [ext4]
> >> [ 8.108300] ? do_writepages+0x41/0x100
> >> [ 8.109338] ? __ext4_mark_inode_dirty+0x240/0x240 [ext4]
> >> [ 8.110406] do_writepages+0x41/0x100
> >> [ 8.111450] __filemap_fdatawrite_range+0xc5/0x100
> >> [ 8.112513] file_write_and_wait_range+0x61/0xb0
> >> [ 8.113564] ext4_sync_file+0x73/0x370 [ext4]
> >> [ 8.114607] __x64_sys_fsync+0x33/0x60
> >> [ 8.115635] do_syscall_64+0x33/0x40
> >> [ 8.116670] entry_SYSCALL_64_after_hwframe+0x44/0xae
> >>
> >> Thanks for the comment from Christoph.
> >>
> >> [1]. https://bugs.archlinux.org/task/70992
> >>
> >> Reported-by: Jens Stutte <jens@chianterastutte.eu>
> >> Tested-by: Jens Stutte <jens@chianterastutte.eu>
> >> Reviewed-by: Christoph Hellwig <hch@lst.de>
> >> Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
> > I am confused. Which tree does this apply to?
>
> Sorry, I forgot to mention it in this version (actually it is v4). It
> depends
> on commit 018eca456c4b4dca56aaf1ec27f309c74d0fe246 in block tree
> for-next branch, so it would be better to be picked by block tree for now
> to avoid compile issue, or after you rebase md tree from block tree with
> that commit included.
I replaced PAGE_SECTORS with (PAGE_SIZE >> 9). And applied it to md-next.
Thanks,
Song
prev parent reply other threads:[~2021-08-26 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 1:16 [PATCH] raid1: ensure write behind bio has less than BIO_MAX_VECS sectors Guoqing Jiang
2021-08-24 21:55 ` Song Liu
2021-08-25 0:44 ` [PATCH V4] " Guoqing Jiang
2021-08-26 16:16 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW7jYhOCsTcoT54_y12RWLw-wj3iPGO1a=vd37L7khxn3g@mail.gmail.com' \
--to=song@kernel.org \
--cc=axboe@kernel.dk \
--cc=guoqing.jiang@linux.dev \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.