All of lore.kernel.org
 help / color / mirror / Atom feed
From: Song Liu <song@kernel.org>
To: Nathan Fontenot <nafonten@amd.com>,
	Hans de Goede <hdegoede@redhat.com>,
	"Chatradhi, Naveen Krishna" <nchatrad@amd.com>
Cc: platform-driver-x86@vger.kernel.org, carlos.bilbao@amd.com,
	siva.sathappan@amd.com, suma.hegde@amd.com
Subject: Re: [PATCH v4 1/2] platforms/x86: Add AMD system management interface
Date: Tue, 15 Feb 2022 10:21:25 -0800	[thread overview]
Message-ID: <CAPhsuW7mDRswhVjYf+4iinO+sph_rQ1JykEof+apoiSOVwOXXQ@mail.gmail.com> (raw)
In-Reply-To: <e1249c0a-6729-c02b-45b2-80d0fde07f7b@amd.com>

Hi Naveen Krishna,

On Tue, Feb 15, 2022 at 9:24 AM Nathan Fontenot <nafonten@amd.com> wrote:
>
> On 2/14/22 11:21, Song Liu wrote:
> > On Mon, Feb 14, 2022 at 7:32 AM Chatradhi, Naveen Krishna
> > <nchatrad@amd.com> wrote:
> >>
> >> Hi Song,
> >>
> >> On 2/11/2022 3:10 AM, Song Liu wrote:
> > [...]
> >>
> >> HSMP mailbox messages are evolving and each platform defines a supported
> >> list of messages.
> >>
> >> On a given platform these messages are described in the PPR.
> >>
> >> Eg: Milan PPR has "7 Host System Management Port (HSMP)", is made public
> >>
> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.amd.com%2Fsystem%2Ffiles%2FTechDocs%2F55898_B1_pub_0.50.zip&amp;data=04%7C01%7CNathan.Fontenot%40amd.com%7C6026990f93ed41d04d0608d9efde79a1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637804561503265585%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=o5BR%2FgHpjnNVa9zVu75I3RyzO8WNB4L7FMEvLNbzZVY%3D&amp;reserved=0
> >>
> >>
> >> Bringing detailed description of these messages from PPR into the kernel
> >> would be a
> >>
> >> duplicating effort. Which will also bring in challenges such as
> >> maintaining the details
> >>
> >> for every supported platform and submitting kernel patches for every
> >> platform.
> >>
> >>
> >> We would like to avoid bringing more details of these messages to the
> >> kernel documentation.
> >>
> >> Such a structure can be described as part of esmi_oob_library to ease
> >> user space tool development.
> >
> > I agree there is  extra effort to adding extra logic and documentations to
> > the kernel. How about we ship current version with a few minor changes:
> > 1). msg_desc_table is in the header, so please prefix it with hsmp_
> > 2) as Nathan suggested, add more comments to msg_desc_table. Maybe
> > something like:
> > /*
> >  * HSMP_GET_FCLK_MCLK,
> >  * output arg0 = fclk (MHz); arg1 = mclk (MHz)
> >  */
>
> Agreed, this is the type of update I was thinking of.
>
> -Nathan
>
> > {0, 2, GET},
> >
> > Besides these, I have a question. Per the hardware design, args and
> > reponse in hsmp_message share the same registers. Shall we make
> > them in/out argments in hsmp_message and save 256 bytes per
> > hsmp_message?

Do these make sense to you? We are hoping to back port these changes
to unblock our tests. But we need them to be applied to pdx86 first.

Thanks,
Song

  reply	other threads:[~2022-02-15 18:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 18:44 [PATCH v4 1/2] platforms/x86: Add AMD system management interface Naveen Krishna Chatradhi
2022-02-09 18:44 ` [PATCH v4 2/2] Documentation: Add x86/amd_hsmp driver Naveen Krishna Chatradhi
2022-02-09 21:08 ` [PATCH v4 1/2] platforms/x86: Add AMD system management interface Nathan Fontenot
2022-02-10  1:10   ` Song Liu
2022-02-10 19:52     ` Nathan Fontenot
2022-02-10 20:32       ` Song Liu
2022-02-10 20:42         ` Nathan Fontenot
2022-02-10 21:40           ` Song Liu
2022-02-14 15:32             ` Chatradhi, Naveen Krishna
2022-02-14 17:21               ` Song Liu
2022-02-15 17:24                 ` Nathan Fontenot
2022-02-15 18:21                   ` Song Liu [this message]
2022-02-16 13:42                     ` Chatradhi, Naveen Krishna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPhsuW7mDRswhVjYf+4iinO+sph_rQ1JykEof+apoiSOVwOXXQ@mail.gmail.com \
    --to=song@kernel.org \
    --cc=carlos.bilbao@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=nafonten@amd.com \
    --cc=nchatrad@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=siva.sathappan@amd.com \
    --cc=suma.hegde@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.