From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7623F33F4 for ; Fri, 15 Apr 2022 23:35:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E580C385B0 for ; Fri, 15 Apr 2022 23:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650065738; bh=36GzXrQ0XGK7C5vbiiV0ktcyeA7F6rACtEbIBGiF3Gw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iXx1eEWaz8brLgqBJN4vsW6VTYCngf+8+P/Pbrf8jCHrG4tLTi8FilS/Z2Jt+RP1Y oq1vksA8qipJ2z9lb/HcIm4p8uXzJsqFw+LJ/8i5gB8tnLgyZcSV/NIuFkA3RzNc0Y IEldDb2ClV6PGqzy9WADWOQBKtMkHJAosOlamjfsRjIk+PD814CmsnOPx2Ket3be5V LZxdK6yHLNdcOJywv1/c1mlRu2BG6ozc873sCU/dZVsCrz2Zs+NQ1gHgQgA1/DsmrE 7lnh4b+TlTXwDcvqJOI/z57239ge+muXztey2O8amqG/xmb9zsZRR7ABqeF/azmouX gneMLqDOmab/A== Received: by mail-yb1-f175.google.com with SMTP id g34so16721777ybj.1 for ; Fri, 15 Apr 2022 16:35:38 -0700 (PDT) X-Gm-Message-State: AOAM530S//q4UOPcB+jkDEDVCTRj31SfnovU/d19X/Vhu8lOzhhYOini US7Vsgfup0jmpmxmHJJXBGPqGEtxVwrmnH+soPI= X-Google-Smtp-Source: ABdhPJxrwFIMGcUH1SzkmYhvn2SYkuUhhUDS9HkrDN7TjOG46VNAAeaBmpGAeK1C2yKWnd3B7VrliNvHZy3iO+A3fnY= X-Received: by 2002:a05:6902:114c:b0:641:87a7:da90 with SMTP id p12-20020a056902114c00b0064187a7da90mr1420300ybu.561.1650065737268; Fri, 15 Apr 2022 16:35:37 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220414223704.341028-1-alobakin@pm.me> <20220414223704.341028-5-alobakin@pm.me> In-Reply-To: <20220414223704.341028-5-alobakin@pm.me> From: Song Liu Date: Fri, 15 Apr 2022 16:35:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next 04/11] samples: bpf: add 'asm/mach-generic' include path for every MIPS To: Alexander Lobakin Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Jonathan Lemon , Nathan Chancellor , Nick Desaulniers , Dmitrii Dolgov <9erthalion6@gmail.com>, Quentin Monnet , Tiezhu Yang , Kumar Kartikeya Dwivedi , Chenbo Feng , Willem de Bruijn , Daniel Wagner , Thomas Graf , Ong Boon Leong , linux-perf-users@vger.kernel.org, open list , Networking , bpf , llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" On Thu, Apr 14, 2022 at 3:45 PM Alexander Lobakin wrote: > > Fix the following: > > In file included from samples/bpf/tracex2_kern.c:7: > In file included from ./include/linux/skbuff.h:13: > In file included from ./include/linux/kernel.h:22: > In file included from ./include/linux/bitops.h:33: > In file included from ./arch/mips/include/asm/bitops.h:20: > In file included from ./arch/mips/include/asm/barrier.h:11: > ./arch/mips/include/asm/addrspace.h:13:10: fatal error: 'spaces.h' file not found > #include > ^~~~~~~~~~ > > 'arch/mips/include/asm/mach-generic' should always be included as > many other MIPS include files rely on this. > Move it from under CONFIG_MACH_LOONGSON64 to let it be included > for every MIPS. > > Fixes: 058107abafc7 ("samples/bpf: Add include dir for MIPS Loongson64 to fix build errors") > Signed-off-by: Alexander Lobakin Acked-by: Song Liu > --- > samples/bpf/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile > index 8fff5ad3444b..97203c0de252 100644 > --- a/samples/bpf/Makefile > +++ b/samples/bpf/Makefile > @@ -193,8 +193,8 @@ ifeq ($(ARCH), mips) > TPROGS_CFLAGS += -D__SANE_USERSPACE_TYPES__ > ifdef CONFIG_MACH_LOONGSON64 > BPF_EXTRA_CFLAGS += -I$(srctree)/arch/mips/include/asm/mach-loongson64 > -BPF_EXTRA_CFLAGS += -I$(srctree)/arch/mips/include/asm/mach-generic > endif > +BPF_EXTRA_CFLAGS += -I$(srctree)/arch/mips/include/asm/mach-generic > endif > > TPROGS_CFLAGS += -Wall -O2 > -- > 2.35.2 > >