All of lore.kernel.org
 help / color / mirror / Atom feed
From: Song Liu <song@kernel.org>
To: Lidong Zhong <lidong.zhong@suse.com>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] md: adding a new flag MD_DELETING
Date: Thu, 3 Jun 2021 18:23:50 -0700	[thread overview]
Message-ID: <CAPhsuW7uWNg05ps1b2qmD5P5=0x=_0ChV0e=hGZ7Occxeh2t-g@mail.gmail.com> (raw)
In-Reply-To: <20210428082903.14783-1-lidong.zhong@suse.com>

On Wed, Apr 28, 2021 at 1:31 AM Lidong Zhong <lidong.zhong@suse.com> wrote:
>
> The mddev data structure is freed in mddev_delayed_delete(), which is
> schedualed after the array is deconfigured completely when stopping. So
> there is a race window between md_open() and do_md_stop(), which leads
> to /dev/mdX can still be opened by userspace even it's not accessible
> any more. As a result, a DeviceDisappeared event will not be able to be
> monitored by mdadm in monitor mode. This patch tries to fix it by adding
> this new flag MD_DELETING.
>
> Signed-off-by: Lidong Zhong <lidong.zhong@suse.com>

Sorry for the delay. I missed this one.

As I try to apply the patch, I found the patch is somehow corrupted. It contains
special patterns like:

 =09if ((err =3D mutex_lock_interruptible(&mddev->open_mutex)))
 =09=09goto out;
=20
-=09if (test_bit(MD_CLOSING, &mddev->flags)) {
+=09if (test_bit(MD_CLOSING, &mddev->flags) ||
+            (test_bit(MD_DELETING, &mddev->flags) && mddev->pers =3D=3D NU=
LL)) {

Could you please try resend it?

Thanks,
Song

  parent reply	other threads:[~2021-06-04  1:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  8:29 [PATCH] md: adding a new flag MD_DELETING Lidong Zhong
2021-05-08  7:41 ` Zhong Lidong
2021-05-11  6:39   ` Song Liu
2021-06-04  1:23 ` Song Liu [this message]
2021-06-04  4:55   ` Zhong Lidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPhsuW7uWNg05ps1b2qmD5P5=0x=_0ChV0e=hGZ7Occxeh2t-g@mail.gmail.com' \
    --to=song@kernel.org \
    --cc=lidong.zhong@suse.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.