* [Buildroot] [PATCH 1/2] package/liboping: remove -Werror build flag
[not found] <20200124143609.14313-1-nroach44@gmail.com>
@ 2020-01-25 20:04 ` Fabrice Fontaine
2020-01-26 0:15 ` Nathaniel Roach
0 siblings, 1 reply; 8+ messages in thread
From: Fabrice Fontaine @ 2020-01-25 20:04 UTC (permalink / raw)
To: buildroot
Dear Nathaniel,
Le ven. 24 janv. 2020 ? 15:36, Nathaniel Roach <nroach44@gmail.com> a ?crit :
>
> Same as https://bugs.gentoo.org/675344 - when building, GCC
> will fail the build due to a truncation warning.
Can you be more specific on the build failure? For example, by
providing a link on autobuilder?
Otherwise, I would prefer an upstreamable solution such as adding a
--disable-werror option or adding a patch that fixes the issue.
There is a pending PR on a truncation error on upstream github:
https://github.com/octo/liboping/pull/50.
Is it related to your build failure? In this case, I would suggest to
retrieve this commit.
>
> Remove -Wall and -Werror from Makefile.am and run automake
> to apply the change
>
> Signed-off-by: Nathaniel Roach <nroach44@gmail.com>
> ---
> package/liboping/0002-no-werror.patch | 14 ++++++++++++++
> package/liboping/liboping.mk | 1 +
> 2 files changed, 15 insertions(+)
> create mode 100644 package/liboping/0002-no-werror.patch
>
> diff --git a/package/liboping/0002-no-werror.patch b/package/liboping/0002-no-werror.patch
> new file mode 100644
> index 0000000000..febb2c0335
> --- /dev/null
> +++ b/package/liboping/0002-no-werror.patch
> @@ -0,0 +1,14 @@
> +--- a/src/Makefile.am
> ++++ b/src/Makefile.am
> +@@ -2,10 +2,6 @@ AUTOMAKE_OPTIONS = foreign no-dependencies
> +
> + SUBDIRS = mans
> +
> +-if COMPILER_IS_GCC
> +-AM_CFLAGS = -Wall -Werror
> +-endif
> +-
> + include_HEADERS = oping.h
> + lib_LTLIBRARIES = liboping.la
> +
> +
> diff --git a/package/liboping/liboping.mk b/package/liboping/liboping.mk
> index 4aa3e30ee8..6e3530fdb0 100644
> --- a/package/liboping/liboping.mk
> +++ b/package/liboping/liboping.mk
> @@ -11,6 +11,7 @@ LIBOPING_INSTALL_STAGING = YES
> LIBOPING_CONF_OPTS = --without-perl-bindings
> LIBOPING_LICENSE = LGPL-2.1+, GPL-2.0
> LIBOPING_LICENSE_FILES = COPYING
> +LIBOPING_AUTORECONF = YES
>
> ifeq ($(BR2_PACKAGE_NCURSES),y)
> LIBOPING_DEPENDENCIES += ncurses
> --
> 2.20.1
>
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2] package/liboping: remove -Werror build flag
2020-01-25 20:04 ` [Buildroot] [PATCH 1/2] package/liboping: remove -Werror build flag Fabrice Fontaine
@ 2020-01-26 0:15 ` Nathaniel Roach
2020-01-26 9:03 ` Fabrice Fontaine
0 siblings, 1 reply; 8+ messages in thread
From: Nathaniel Roach @ 2020-01-26 0:15 UTC (permalink / raw)
To: buildroot
Hi Fabrice,
On 26/1/20 4:04 am, Fabrice Fontaine wrote:
> Dear Nathaniel,
>
> Le ven. 24 janv. 2020 ? 15:36, Nathaniel Roach <nroach44@gmail.com> a ?crit :
>> Same as https://bugs.gentoo.org/675344 - when building, GCC
>> will fail the build due to a truncation warning.
> Can you be more specific on the build failure? For example, by
> providing a link on autobuilder?
> Otherwise, I would prefer an upstreamable solution such as adding a
> --disable-werror option or adding a patch that fixes the issue.
> There is a pending PR on a truncation error on upstream github:
> https://github.com/octo/liboping/pull/50.
> Is it related to your build failure? In this case, I would suggest to
> retrieve this commit.
The error is detailed in the Gentoo bug linked above, and this was their
fix for it. There is one single build failure on the autobuilders, and
it's got the same error:
http://autobuild.buildroot.org/?reason=liboping-1.10.0
In my case the error is more prevalent, probably due to the parallel build:
>>> liboping 1.10.0 Building
PATH="/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin:/home/nroach44/media/code/buildroot/buildroot-git/output/host/sbin:/home/nroach44/apps/native/wine/latest/usr/local/bin/:/home/nroach44/apps/bin:/usr/sbin:/sbin:/home/nroach44/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games"
/usr/bin/make -j5? -C
/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/
make[1]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0'
Making all in src
make[2]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
/usr/bin/make? all-recursive
make[3]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
Making all in mans
make[4]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
make[4]: Entering directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
/bin/bash ../libtool? --tag=CC?? --mode=compile
/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
-DHAVE_CONFIG_H -I.?? -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64? -O3?? -c -o
liboping_la-liboping.lo `test -f 'liboping.c' || echo './'`liboping.c
/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
-DHAVE_CONFIG_H -I.?? -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64? -O3?? -c -o oping.o oping.c
/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
-DHAVE_CONFIG_H -I.?? -DUSE_NCURSES=1? -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Werror
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3??
-c -o noping-oping.o `test -f 'oping.c' || echo './'`oping.c
libtool: compile:
/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
-DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -c liboping.c -fPIC
-DPIC -o .libs/liboping_la-liboping.o
liboping.c: In function 'ping_set_ttl':
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:829:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:842:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c: In function 'ping_set_qos':
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:869:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:885:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [Makefile:582: liboping_la-liboping.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[3]: *** [Makefile:645: all-recursive] Error 1
make[3]: Leaving directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[2]: *** [Makefile:419: all] Error 2
make[2]: Leaving directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[1]: *** [Makefile:382: all-recursive] Error 1
make[1]: Leaving directory
'/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0'
make: *** [package/pkg-generic.mk:260:
/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/.stamp_built]
Error 2
I hadn't come across the patch you linked, as the exact error isn't
posted within it.
I don't mind patching it either way.
>> Remove -Wall and -Werror from Makefile.am and run automake
>> to apply the change
>>
>> Signed-off-by: Nathaniel Roach <nroach44@gmail.com>
>> ---
>> package/liboping/0002-no-werror.patch | 14 ++++++++++++++
>> package/liboping/liboping.mk | 1 +
>> 2 files changed, 15 insertions(+)
>> create mode 100644 package/liboping/0002-no-werror.patch
>>
>> diff --git a/package/liboping/0002-no-werror.patch b/package/liboping/0002-no-werror.patch
>> new file mode 100644
>> index 0000000000..febb2c0335
>> --- /dev/null
>> +++ b/package/liboping/0002-no-werror.patch
>> @@ -0,0 +1,14 @@
>> +--- a/src/Makefile.am
>> ++++ b/src/Makefile.am
>> +@@ -2,10 +2,6 @@ AUTOMAKE_OPTIONS = foreign no-dependencies
>> +
>> + SUBDIRS = mans
>> +
>> +-if COMPILER_IS_GCC
>> +-AM_CFLAGS = -Wall -Werror
>> +-endif
>> +-
>> + include_HEADERS = oping.h
>> + lib_LTLIBRARIES = liboping.la
>> +
>> +
>> diff --git a/package/liboping/liboping.mk b/package/liboping/liboping.mk
>> index 4aa3e30ee8..6e3530fdb0 100644
>> --- a/package/liboping/liboping.mk
>> +++ b/package/liboping/liboping.mk
>> @@ -11,6 +11,7 @@ LIBOPING_INSTALL_STAGING = YES
>> LIBOPING_CONF_OPTS = --without-perl-bindings
>> LIBOPING_LICENSE = LGPL-2.1+, GPL-2.0
>> LIBOPING_LICENSE_FILES = COPYING
>> +LIBOPING_AUTORECONF = YES
>>
>> ifeq ($(BR2_PACKAGE_NCURSES),y)
>> LIBOPING_DEPENDENCIES += ncurses
>> --
>> 2.20.1
>>
> Best Regards,
>
> Fabrice
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2] package/liboping: remove -Werror build flag
2020-01-26 0:15 ` Nathaniel Roach
@ 2020-01-26 9:03 ` Fabrice Fontaine
2020-02-03 21:11 ` Peter Korsgaard
0 siblings, 1 reply; 8+ messages in thread
From: Fabrice Fontaine @ 2020-01-26 9:03 UTC (permalink / raw)
To: buildroot
Hi Nathaniel,
Le dim. 26 janv. 2020 ? 01:16, Nathaniel Roach
<nroach44@nroach44.id.au> a ?crit :
>
> Hi Fabrice,
>
> On 26/1/20 4:04 am, Fabrice Fontaine wrote:
> > Dear Nathaniel,
> >
> > Le ven. 24 janv. 2020 ? 15:36, Nathaniel Roach <nroach44@gmail.com> a ?crit :
> >> Same as https://bugs.gentoo.org/675344 - when building, GCC
> >> will fail the build due to a truncation warning.
> > Can you be more specific on the build failure? For example, by
> > providing a link on autobuilder?
> > Otherwise, I would prefer an upstreamable solution such as adding a
> > --disable-werror option or adding a patch that fixes the issue.
> > There is a pending PR on a truncation error on upstream github:
> > https://github.com/octo/liboping/pull/50.
> > Is it related to your build failure? In this case, I would suggest to
> > retrieve this commit.
>
> The error is detailed in the Gentoo bug linked above, and this was their
> fix for it. There is one single build failure on the autobuilders, and
> it's got the same error:
> http://autobuild.buildroot.org/?reason=liboping-1.10.0
This error was raised in December 5th 2018 and has been fixed by
retrieving an upstream commit instead of disabling -Werror (see
https://patchwork.ozlabs.org/patch/1009066).
There was no more autobuilder failures after this patch was applied.
So this is strange that you still get a failure on your local machine.
Are you using the master branch or one of the official release (fix
was committed to 2018.08.x and 2018.11.x releases)?
>
> In my case the error is more prevalent, probably due to the parallel build:
>
> >>> liboping 1.10.0 Building
> PATH="/home/nroach44/media/code/buildroot/buildroot-git/output/host/bin:/home/nroach44/media/code/buildroot/buildroot-git/output/host/sbin:/home/nroach44/apps/native/wine/latest/usr/local/bin/:/home/nroach44/apps/bin:/usr/sbin:/sbin:/home/nroach44/.local/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games"
> /usr/bin/make -j5 -C
> /home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/
> make[1]: Entering directory
> '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0'
> Making all in src
> make[2]: Entering directory
> '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
> /usr/bin/make all-recursive
> make[3]: Entering directory
> '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
> Making all in mans
> make[4]: Entering directory
> '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
> make[4]: Nothing to be done for 'all'.
> make[4]: Leaving directory
> '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
> make[4]: Entering directory
> '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
> /bin/bash ../libtool --tag=CC --mode=compile
> /home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
> -DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> -D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -c -o
> liboping_la-liboping.lo `test -f 'liboping.c' || echo './'`liboping.c
> /home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
> -DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> -D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -c -o oping.o oping.c
> /home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
> -DHAVE_CONFIG_H -I. -DUSE_NCURSES=1 -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Werror
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3
> -c -o noping-oping.o `test -f 'oping.c' || echo './'`oping.c
> libtool: compile:
> /home/nroach44/media/code/buildroot/buildroot-git/output/host/bin/x86_64-nr44-linux-gnu-gcc
> -DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> -D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -c liboping.c -fPIC
> -DPIC -o .libs/liboping_la-liboping.o
> liboping.c: In function 'ping_set_ttl':
> liboping.c:207:9: error: '%s' directive output may be truncated writing
> up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
> "%s: %s", function, message);
> ^~
> liboping.c:829:6:
> sstrerror (ret, errbuf, sizeof (errbuf)));
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
> a destination of size 256
> snprintf (obj->errmsg, sizeof (obj->errmsg),
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> "%s: %s", function, message);
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> liboping.c:207:9: error: '%s' directive output may be truncated writing
> up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
> "%s: %s", function, message);
> ^~
> liboping.c:842:6:
> sstrerror (ret, errbuf, sizeof (errbuf)));
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
> a destination of size 256
> snprintf (obj->errmsg, sizeof (obj->errmsg),
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> "%s: %s", function, message);
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> liboping.c: In function 'ping_set_qos':
> liboping.c:207:9: error: '%s' directive output may be truncated writing
> up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
> "%s: %s", function, message);
> ^~
> liboping.c:869:6:
> sstrerror (ret, errbuf, sizeof (errbuf)));
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
> a destination of size 256
> snprintf (obj->errmsg, sizeof (obj->errmsg),
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> "%s: %s", function, message);
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> liboping.c:207:9: error: '%s' directive output may be truncated writing
> up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
> "%s: %s", function, message);
> ^~
> liboping.c:885:6:
> sstrerror (ret, errbuf, sizeof (errbuf)));
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
> a destination of size 256
> snprintf (obj->errmsg, sizeof (obj->errmsg),
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> "%s: %s", function, message);
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[4]: *** [Makefile:582: liboping_la-liboping.lo] Error 1
> make[4]: *** Waiting for unfinished jobs....
> make[4]: Leaving directory
> '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
> make[3]: *** [Makefile:645: all-recursive] Error 1
> make[3]: Leaving directory
> '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
> make[2]: *** [Makefile:419: all] Error 2
> make[2]: Leaving directory
> '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
> make[1]: *** [Makefile:382: all-recursive] Error 1
> make[1]: Leaving directory
> '/home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0'
> make: *** [package/pkg-generic.mk:260:
> /home/nroach44/media/code/buildroot/buildroot-git/output/build/liboping-1.10.0/.stamp_built]
> Error 2
>
>
> I hadn't come across the patch you linked, as the exact error isn't
> posted within it.
>
>
> I don't mind patching it either way.
>
> >> Remove -Wall and -Werror from Makefile.am and run automake
> >> to apply the change
> >>
> >> Signed-off-by: Nathaniel Roach <nroach44@gmail.com>
> >> ---
> >> package/liboping/0002-no-werror.patch | 14 ++++++++++++++
> >> package/liboping/liboping.mk | 1 +
> >> 2 files changed, 15 insertions(+)
> >> create mode 100644 package/liboping/0002-no-werror.patch
> >>
> >> diff --git a/package/liboping/0002-no-werror.patch b/package/liboping/0002-no-werror.patch
> >> new file mode 100644
> >> index 0000000000..febb2c0335
> >> --- /dev/null
> >> +++ b/package/liboping/0002-no-werror.patch
> >> @@ -0,0 +1,14 @@
> >> +--- a/src/Makefile.am
> >> ++++ b/src/Makefile.am
> >> +@@ -2,10 +2,6 @@ AUTOMAKE_OPTIONS = foreign no-dependencies
> >> +
> >> + SUBDIRS = mans
> >> +
> >> +-if COMPILER_IS_GCC
> >> +-AM_CFLAGS = -Wall -Werror
> >> +-endif
> >> +-
> >> + include_HEADERS = oping.h
> >> + lib_LTLIBRARIES = liboping.la
> >> +
> >> +
> >> diff --git a/package/liboping/liboping.mk b/package/liboping/liboping.mk
> >> index 4aa3e30ee8..6e3530fdb0 100644
> >> --- a/package/liboping/liboping.mk
> >> +++ b/package/liboping/liboping.mk
> >> @@ -11,6 +11,7 @@ LIBOPING_INSTALL_STAGING = YES
> >> LIBOPING_CONF_OPTS = --without-perl-bindings
> >> LIBOPING_LICENSE = LGPL-2.1+, GPL-2.0
> >> LIBOPING_LICENSE_FILES = COPYING
> >> +LIBOPING_AUTORECONF = YES
> >>
> >> ifeq ($(BR2_PACKAGE_NCURSES),y)
> >> LIBOPING_DEPENDENCIES += ncurses
> >> --
> >> 2.20.1
> >>
> > Best Regards,
> >
> > Fabrice
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2] package/liboping: remove -Werror build flag
2020-01-26 9:03 ` Fabrice Fontaine
@ 2020-02-03 21:11 ` Peter Korsgaard
2020-02-04 10:01 ` Nathaniel Roach
2020-02-05 12:08 ` Nathaniel Roach
0 siblings, 2 replies; 8+ messages in thread
From: Peter Korsgaard @ 2020-02-03 21:11 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
Hi,
>> > Can you be more specific on the build failure? For example, by
>> > providing a link on autobuilder?
>> > Otherwise, I would prefer an upstreamable solution such as adding a
>> > --disable-werror option or adding a patch that fixes the issue.
>> > There is a pending PR on a truncation error on upstream github:
>> > https://github.com/octo/liboping/pull/50.
>> > Is it related to your build failure? In this case, I would suggest to
>> > retrieve this commit.
>>
>> The error is detailed in the Gentoo bug linked above, and this was their
>> fix for it. There is one single build failure on the autobuilders, and
>> it's got the same error:
>> http://autobuild.buildroot.org/?reason=liboping-1.10.0
> This error was raised in December 5th 2018 and has been fixed by
> retrieving an upstream commit instead of disabling -Werror (see
> https://patchwork.ozlabs.org/patch/1009066).
> There was no more autobuilder failures after this patch was applied.
> So this is strange that you still get a failure on your local machine.
> Are you using the master branch or one of the official release (fix
> was committed to 2018.08.x and 2018.11.x releases)?
Any comments on that? In the mean time I have marked the patch as not
applicable in patchwork.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2] package/liboping: remove -Werror build flag
2020-02-03 21:11 ` Peter Korsgaard
@ 2020-02-04 10:01 ` Nathaniel Roach
2020-02-05 12:08 ` Nathaniel Roach
1 sibling, 0 replies; 8+ messages in thread
From: Nathaniel Roach @ 2020-02-04 10:01 UTC (permalink / raw)
To: buildroot
HI Peter, Fabrice,
On 4/2/20 5:11 am, Peter Korsgaard wrote:
>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Hi,
>
> >> > Can you be more specific on the build failure? For example, by
> >> > providing a link on autobuilder?
> >> > Otherwise, I would prefer an upstreamable solution such as adding a
> >> > --disable-werror option or adding a patch that fixes the issue.
> >> > There is a pending PR on a truncation error on upstream github:
> >> > https://github.com/octo/liboping/pull/50.
> >> > Is it related to your build failure? In this case, I would suggest to
> >> > retrieve this commit.
> >>
> >> The error is detailed in the Gentoo bug linked above, and this was their
> >> fix for it. There is one single build failure on the autobuilders, and
> >> it's got the same error:
> >> http://autobuild.buildroot.org/?reason=liboping-1.10.0
> > This error was raised in December 5th 2018 and has been fixed by
> > retrieving an upstream commit instead of disabling -Werror (see
> > https://patchwork.ozlabs.org/patch/1009066).
> > There was no more autobuilder failures after this patch was applied.
> > So this is strange that you still get a failure on your local machine.
> > Are you using the master branch or one of the official release (fix
> > was committed to 2018.08.x and 2018.11.x releases)?
>
> Any comments on that? In the mean time I have marked the patch as not
> applicable in patchwork.
Apologies for the delays, I'm going to have to test with the BR
toolchain instead of my ct-ng one.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2] package/liboping: remove -Werror build flag
2020-02-03 21:11 ` Peter Korsgaard
2020-02-04 10:01 ` Nathaniel Roach
@ 2020-02-05 12:08 ` Nathaniel Roach
1 sibling, 0 replies; 8+ messages in thread
From: Nathaniel Roach @ 2020-02-05 12:08 UTC (permalink / raw)
To: buildroot
HI Peter, Fabrice,
On 4/2/20 5:11 am, Peter Korsgaard wrote:
>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Hi,
>
> >> > Can you be more specific on the build failure? For example, by
> >> > providing a link on autobuilder?
> >> > Otherwise, I would prefer an upstreamable solution such as adding a
> >> > --disable-werror option or adding a patch that fixes the issue.
> >> > There is a pending PR on a truncation error on upstream github:
> >> > https://github.com/octo/liboping/pull/50.
> >> > Is it related to your build failure? In this case, I would suggest to
> >> > retrieve this commit.
> >>
> >> The error is detailed in the Gentoo bug linked above, and this was their
> >> fix for it. There is one single build failure on the autobuilders, and
> >> it's got the same error:
> >> http://autobuild.buildroot.org/?reason=liboping-1.10.0
> > This error was raised in December 5th 2018 and has been fixed by
> > retrieving an upstream commit instead of disabling -Werror (see
> > https://patchwork.ozlabs.org/patch/1009066).
> > There was no more autobuilder failures after this patch was applied.
> > So this is strange that you still get a failure on your local machine.
> > Are you using the master branch or one of the official release (fix
> > was committed to 2018.08.x and 2018.11.x releases)?
>
> Any comments on that? In the mean time I have marked the patch as not
> applicable in patchwork.
>
I'm working off origin/master. When using the following defconfig:
BR2_x86_64=y
BR2_x86_core2=y
BR2_DL_DIR="<snip>"
BR2_OPTIMIZE_3=y
BR2_PIC_PIE=y
BR2_SSP_REGULAR=y
BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_PACKAGE_GLIBC_UTILS=y
BR2_BINUTILS_VERSION_2_33_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_TOOLCHAIN_BUILDROOT_FORTRAN=y
BR2_GCC_ENABLE_LTO=y
BR2_GCC_ENABLE_GRAPHITE=y
BR2_TARGET_GENERIC_PASSWD_SHA512=y
BR2_INIT_SYSTEMD=y
BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES=y
BR2_SYSTEM_BIN_SH_BASH=y
BR2_TARGET_GENERIC_GETTY_PORT="tty1"
BR2_ENABLE_LOCALE_WHITELIST="C en_US en_AU"
BR2_GENERATE_LOCALE="C en_AU"
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="<snip>"
BR2_LINUX_KERNEL_INSTALL_TARGET=y
BR2_PACKAGE_LIBOPING=y
The build will fail with:
>>> liboping 1.10.0 Building
PATH="/srv/data/build/buildroot/buildroot-git/output/host/bin:/srv/data/build/buildroot/buildroot-git/output/host/sbin:/usr/lib/ccache:/home/nroach44/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games"
/usr/bin/make -j13? -C
/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/
make[1]: Entering directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0'
Making all in src
make[2]: Entering directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
/usr/bin/make? all-recursive
make[3]: Entering directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
Making all in mans
make[4]: Entering directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src/mans'
make[4]: Entering directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
/bin/bash ../libtool? --tag=CC?? --mode=compile
/srv/data/build/buildroot/buildroot-git/output/host/bin/x86_64-buildroot-linux-gnu-gcc
-DHAVE_CONFIG_H -I.?? -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64? -O3?? -c -o
liboping_la-liboping.lo `test -f 'liboping.c' || echo './'`liboping.c
libtool: compile:
/srv/data/build/buildroot/buildroot-git/output/host/bin/x86_64-buildroot-linux-gnu-gcc
-DHAVE_CONFIG_H -I. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64 -Wall -Werror -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O3 -c liboping.c -fPIC
-DPIC -o .libs/liboping_la-liboping.o
liboping.c: In function 'ping_set_ttl':
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:829:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:842:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c: In function 'ping_set_qos':
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:869:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:207:9: error: '%s' directive output may be truncated writing
up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
??? "%s: %s", function, message);
???????? ^~
liboping.c:885:6:
????? sstrerror (ret, errbuf, sizeof (errbuf)));
????? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
liboping.c:206:2: note: 'snprintf' output between 15 and 270 bytes into
a destination of size 256
? snprintf (obj->errmsg, sizeof (obj->errmsg),
? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
??? "%s: %s", function, message);
??? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [Makefile:582: liboping_la-liboping.lo] Error 1
make[4]: Leaving directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[3]: *** [Makefile:645: all-recursive] Error 1
make[3]: Leaving directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[2]: *** [Makefile:419: all] Error 2
make[2]: Leaving directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/src'
make[1]: *** [Makefile:382: all-recursive] Error 1
make[1]: Leaving directory
'/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0'
make: *** [package/pkg-generic.mk:260:
/srv/data/build/buildroot/buildroot-git/output/build/liboping-1.10.0/.stamp_built]
Error 2
I'm building on Debian 10. When I turn SSP to none, it will build fine.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2] package/liboping: remove -Werror build flag
2020-01-25 15:32 Nathaniel Roach
@ 2020-01-25 15:35 ` Nathaniel Roach
0 siblings, 0 replies; 8+ messages in thread
From: Nathaniel Roach @ 2020-01-25 15:35 UTC (permalink / raw)
To: buildroot
Patch is standalone, title can be amended if no other changes are needed
On 25/1/20 11:32 pm, Nathaniel Roach wrote:
> Same as https://bugs.gentoo.org/675344 - when building, GCC
> will fail the build due to a truncation warning.
>
> Remove -Wall and -Werror from Makefile.am and run automake
> to apply the change
>
> Signed-off-by: Nathaniel Roach <nroach44@nroach44.id.au>
> ---
> package/liboping/0002-no-werror.patch | 14 ++++++++++++++
> package/liboping/liboping.mk | 1 +
> 2 files changed, 15 insertions(+)
> create mode 100644 package/liboping/0002-no-werror.patch
>
> diff --git a/package/liboping/0002-no-werror.patch b/package/liboping/0002-no-werror.patch
> new file mode 100644
> index 0000000000..febb2c0335
> --- /dev/null
> +++ b/package/liboping/0002-no-werror.patch
> @@ -0,0 +1,14 @@
> +--- a/src/Makefile.am
> ++++ b/src/Makefile.am
> +@@ -2,10 +2,6 @@ AUTOMAKE_OPTIONS = foreign no-dependencies
> +
> + SUBDIRS = mans
> +
> +-if COMPILER_IS_GCC
> +-AM_CFLAGS = -Wall -Werror
> +-endif
> +-
> + include_HEADERS = oping.h
> + lib_LTLIBRARIES = liboping.la
> +
> +
> diff --git a/package/liboping/liboping.mk b/package/liboping/liboping.mk
> index 4aa3e30ee8..6e3530fdb0 100644
> --- a/package/liboping/liboping.mk
> +++ b/package/liboping/liboping.mk
> @@ -11,6 +11,7 @@ LIBOPING_INSTALL_STAGING = YES
> LIBOPING_CONF_OPTS = --without-perl-bindings
> LIBOPING_LICENSE = LGPL-2.1+, GPL-2.0
> LIBOPING_LICENSE_FILES = COPYING
> +LIBOPING_AUTORECONF = YES
>
> ifeq ($(BR2_PACKAGE_NCURSES),y)
> LIBOPING_DEPENDENCIES += ncurses
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/2] package/liboping: remove -Werror build flag
@ 2020-01-25 15:32 Nathaniel Roach
2020-01-25 15:35 ` Nathaniel Roach
0 siblings, 1 reply; 8+ messages in thread
From: Nathaniel Roach @ 2020-01-25 15:32 UTC (permalink / raw)
To: buildroot
Same as https://bugs.gentoo.org/675344 - when building, GCC
will fail the build due to a truncation warning.
Remove -Wall and -Werror from Makefile.am and run automake
to apply the change
Signed-off-by: Nathaniel Roach <nroach44@nroach44.id.au>
---
package/liboping/0002-no-werror.patch | 14 ++++++++++++++
package/liboping/liboping.mk | 1 +
2 files changed, 15 insertions(+)
create mode 100644 package/liboping/0002-no-werror.patch
diff --git a/package/liboping/0002-no-werror.patch b/package/liboping/0002-no-werror.patch
new file mode 100644
index 0000000000..febb2c0335
--- /dev/null
+++ b/package/liboping/0002-no-werror.patch
@@ -0,0 +1,14 @@
+--- a/src/Makefile.am
++++ b/src/Makefile.am
+@@ -2,10 +2,6 @@ AUTOMAKE_OPTIONS = foreign no-dependencies
+
+ SUBDIRS = mans
+
+-if COMPILER_IS_GCC
+-AM_CFLAGS = -Wall -Werror
+-endif
+-
+ include_HEADERS = oping.h
+ lib_LTLIBRARIES = liboping.la
+
+
diff --git a/package/liboping/liboping.mk b/package/liboping/liboping.mk
index 4aa3e30ee8..6e3530fdb0 100644
--- a/package/liboping/liboping.mk
+++ b/package/liboping/liboping.mk
@@ -11,6 +11,7 @@ LIBOPING_INSTALL_STAGING = YES
LIBOPING_CONF_OPTS = --without-perl-bindings
LIBOPING_LICENSE = LGPL-2.1+, GPL-2.0
LIBOPING_LICENSE_FILES = COPYING
+LIBOPING_AUTORECONF = YES
ifeq ($(BR2_PACKAGE_NCURSES),y)
LIBOPING_DEPENDENCIES += ncurses
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-02-05 12:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200124143609.14313-1-nroach44@gmail.com>
2020-01-25 20:04 ` [Buildroot] [PATCH 1/2] package/liboping: remove -Werror build flag Fabrice Fontaine
2020-01-26 0:15 ` Nathaniel Roach
2020-01-26 9:03 ` Fabrice Fontaine
2020-02-03 21:11 ` Peter Korsgaard
2020-02-04 10:01 ` Nathaniel Roach
2020-02-05 12:08 ` Nathaniel Roach
2020-01-25 15:32 Nathaniel Roach
2020-01-25 15:35 ` Nathaniel Roach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.