All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/qpid-proton: needs threads
@ 2021-03-29 10:18 Luca Ceresoli
  2021-03-29 10:18 ` [Buildroot] [PATCH 2/2] package/qpid-proton: needs C++ Luca Ceresoli
  2021-03-29 10:57 ` [Buildroot] [PATCH 1/2] package/qpid-proton: needs threads Fabrice Fontaine
  0 siblings, 2 replies; 5+ messages in thread
From: Luca Ceresoli @ 2021-03-29 10:18 UTC (permalink / raw)
  To: buildroot

qpid-proton needs threads since commit d4c0fde91da0 ("package/qpid-proton:
bump to version 0.33.0"), otherwise it fails with:

  /home/buildroot/autobuild/run/instance-0/output-1/build/qpid-proton-0.33.0/c/src/proactor/epoll-internal.h:37:10: fatal error: pthread.h: No such file or directory
     37 | #include <pthread.h>
        |          ^~~~~~~~~~~
  compilation terminated.

Fixes:
  - http://autobuild.buildroot.net/results/8e3/8e3dc1086f58fe3426ab4ac9ea314a3d4e932652/
  - http://autobuild.buildroot.net/results/e4f/e4f09ea5504ef7746a9e124cade483e430a844bb/
  - http://autobuild.buildroot.net/results/e6c/e6c122cabc6a21be0277a25aee2df92d74965385/

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 package/qpid-proton/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/qpid-proton/Config.in b/package/qpid-proton/Config.in
index b49a2afa7eb4..05ba452c5c48 100644
--- a/package/qpid-proton/Config.in
+++ b/package/qpid-proton/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_QPID_PROTON
 	bool "qpid-proton"
 	depends on !BR2_STATIC_LIBS # build a shared library
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	help
@@ -13,5 +14,5 @@ config BR2_PACKAGE_QPID_PROTON
 
 	  https://qpid.apache.org/proton/
 
-comment "qpid-proton needs a toolchain w/ dynamic library"
-	depends on BR2_STATIC_LIBS
+comment "qpid-proton needs a toolchain w/ dynamic library, threads"
+	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] package/qpid-proton: needs C++
  2021-03-29 10:18 [Buildroot] [PATCH 1/2] package/qpid-proton: needs threads Luca Ceresoli
@ 2021-03-29 10:18 ` Luca Ceresoli
  2021-03-29 11:21   ` Fabrice Fontaine
  2021-03-29 10:57 ` [Buildroot] [PATCH 1/2] package/qpid-proton: needs threads Fabrice Fontaine
  1 sibling, 1 reply; 5+ messages in thread
From: Luca Ceresoli @ 2021-03-29 10:18 UTC (permalink / raw)
  To: buildroot

qpid-proton needs C++ since commit d4c0fde91da0 ("package/qpid-proton: bump
to version 0.33.0"), otherwise it fails with:

  CMake Error at cpp/CMakeLists.txt:22 (enable_language):
    The CMAKE_CXX_COMPILER:

      /home/murray/temp/f5eafd10f45fde1e3655928e3469eec8cdc4945d/output/host/bin/arm-linux-g++

    is not a full path to an existing compiler tool.

Fixes:
  - http://autobuild.buildroot.net/results/e54/e54531509e2268ce3e6f1b6fd087163397e69110/
  - http://autobuild.buildroot.net/results/f5e/f5eafd10f45fde1e3655928e3469eec8cdc4945d/

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 package/qpid-proton/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/qpid-proton/Config.in b/package/qpid-proton/Config.in
index 05ba452c5c48..989de661933c 100644
--- a/package/qpid-proton/Config.in
+++ b/package/qpid-proton/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_QPID_PROTON
 	bool "qpid-proton"
 	depends on !BR2_STATIC_LIBS # build a shared library
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	help
@@ -14,5 +15,5 @@ config BR2_PACKAGE_QPID_PROTON
 
 	  https://qpid.apache.org/proton/
 
-comment "qpid-proton needs a toolchain w/ dynamic library, threads"
-	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
+comment "qpid-proton needs a toolchain w/ dynamic library, threads, C++"
+	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] package/qpid-proton: needs threads
  2021-03-29 10:18 [Buildroot] [PATCH 1/2] package/qpid-proton: needs threads Luca Ceresoli
  2021-03-29 10:18 ` [Buildroot] [PATCH 2/2] package/qpid-proton: needs C++ Luca Ceresoli
@ 2021-03-29 10:57 ` Fabrice Fontaine
  2021-03-30  9:20   ` Luca Ceresoli
  1 sibling, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2021-03-29 10:57 UTC (permalink / raw)
  To: buildroot

Dear Luca,

Le lun. 29 mars 2021 ? 12:18, Luca Ceresoli <luca@lucaceresoli.net> a ?crit :
>
> qpid-proton needs threads since commit d4c0fde91da0 ("package/qpid-proton:
> bump to version 0.33.0"), otherwise it fails with:
>
>   /home/buildroot/autobuild/run/instance-0/output-1/build/qpid-proton-0.33.0/c/src/proactor/epoll-internal.h:37:10: fatal error: pthread.h: No such file or directory
>      37 | #include <pthread.h>
>         |          ^~~~~~~~~~~
>   compilation terminated.
Thanks for taking care of this build failure, another option would be
to explicitly set PROACTOR to none.
>
> Fixes:
>   - http://autobuild.buildroot.net/results/8e3/8e3dc1086f58fe3426ab4ac9ea314a3d4e932652/
>   - http://autobuild.buildroot.net/results/e4f/e4f09ea5504ef7746a9e124cade483e430a844bb/
>   - http://autobuild.buildroot.net/results/e6c/e6c122cabc6a21be0277a25aee2df92d74965385/
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
>  package/qpid-proton/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/package/qpid-proton/Config.in b/package/qpid-proton/Config.in
> index b49a2afa7eb4..05ba452c5c48 100644
> --- a/package/qpid-proton/Config.in
> +++ b/package/qpid-proton/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_QPID_PROTON
>         bool "qpid-proton"
>         depends on !BR2_STATIC_LIBS # build a shared library
> +       depends on BR2_TOOLCHAIN_HAS_THREADS
>         select BR2_PACKAGE_UTIL_LINUX
>         select BR2_PACKAGE_UTIL_LINUX_LIBUUID
>         help
> @@ -13,5 +14,5 @@ config BR2_PACKAGE_QPID_PROTON
>
>           https://qpid.apache.org/proton/
>
> -comment "qpid-proton needs a toolchain w/ dynamic library"
> -       depends on BR2_STATIC_LIBS
> +comment "qpid-proton needs a toolchain w/ dynamic library, threads"
> +       depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
> --
> 2.25.1
>
Best Regards,

Fabrice

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] package/qpid-proton: needs C++
  2021-03-29 10:18 ` [Buildroot] [PATCH 2/2] package/qpid-proton: needs C++ Luca Ceresoli
@ 2021-03-29 11:21   ` Fabrice Fontaine
  0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2021-03-29 11:21 UTC (permalink / raw)
  To: buildroot

Dear Luca,

Le lun. 29 mars 2021 ? 12:18, Luca Ceresoli <luca@lucaceresoli.net> a ?crit :
>
> qpid-proton needs C++ since commit d4c0fde91da0 ("package/qpid-proton: bump
> to version 0.33.0"), otherwise it fails with:
>
>   CMake Error at cpp/CMakeLists.txt:22 (enable_language):
>     The CMAKE_CXX_COMPILER:
>
>       /home/murray/temp/f5eafd10f45fde1e3655928e3469eec8cdc4945d/output/host/bin/arm-linux-g++
>
>     is not a full path to an existing compiler tool.
Thanks for taking care of this build failure, however I think that C++
is not really needed and there is probably  "just" an issue with
CMakeLists.txt which wrongly enable C++ because it thinks that C++ is
available:

check_language (CXX)
if (CMAKE_CXX_COMPILER)
  enable_language(CXX)

Perhaps, there is some kind of bug with check_language. I'll investigate.
>
> Fixes:
>   - http://autobuild.buildroot.net/results/e54/e54531509e2268ce3e6f1b6fd087163397e69110/
>   - http://autobuild.buildroot.net/results/f5e/f5eafd10f45fde1e3655928e3469eec8cdc4945d/
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
>  package/qpid-proton/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/package/qpid-proton/Config.in b/package/qpid-proton/Config.in
> index 05ba452c5c48..989de661933c 100644
> --- a/package/qpid-proton/Config.in
> +++ b/package/qpid-proton/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_QPID_PROTON
>         bool "qpid-proton"
>         depends on !BR2_STATIC_LIBS # build a shared library
>         depends on BR2_TOOLCHAIN_HAS_THREADS
> +       depends on BR2_INSTALL_LIBSTDCPP
>         select BR2_PACKAGE_UTIL_LINUX
>         select BR2_PACKAGE_UTIL_LINUX_LIBUUID
>         help
> @@ -14,5 +15,5 @@ config BR2_PACKAGE_QPID_PROTON
>
>           https://qpid.apache.org/proton/
>
> -comment "qpid-proton needs a toolchain w/ dynamic library, threads"
> -       depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
> +comment "qpid-proton needs a toolchain w/ dynamic library, threads, C++"
> +       depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
> --
> 2.25.1
>
Best Regards,

Fabrice

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] package/qpid-proton: needs threads
  2021-03-29 10:57 ` [Buildroot] [PATCH 1/2] package/qpid-proton: needs threads Fabrice Fontaine
@ 2021-03-30  9:20   ` Luca Ceresoli
  0 siblings, 0 replies; 5+ messages in thread
From: Luca Ceresoli @ 2021-03-30  9:20 UTC (permalink / raw)
  To: buildroot

Hi Fabrice,

On 29/03/21 12:57, Fabrice Fontaine wrote:
> Dear Luca,
> 
> Le lun. 29 mars 2021 ? 12:18, Luca Ceresoli <luca@lucaceresoli.net> a ?crit :
>>
>> qpid-proton needs threads since commit d4c0fde91da0 ("package/qpid-proton:
>> bump to version 0.33.0"), otherwise it fails with:
>>
>>   /home/buildroot/autobuild/run/instance-0/output-1/build/qpid-proton-0.33.0/c/src/proactor/epoll-internal.h:37:10: fatal error: pthread.h: No such file or directory
>>      37 | #include <pthread.h>
>>         |          ^~~~~~~~~~~
>>   compilation terminated.
> Thanks for taking care of this build failure, another option would be
> to explicitly set PROACTOR to none.

I guess you're right, it's good if you can have a better fix! Frankly, I
checked quite quickly across the code and didn't find a simple way to do
a better fix, but I don't know much of this package as I'm not using it.

This applies to both patches. Marked them as "Changes requested" in
patchwork.

-- 
Luca

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-30  9:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29 10:18 [Buildroot] [PATCH 1/2] package/qpid-proton: needs threads Luca Ceresoli
2021-03-29 10:18 ` [Buildroot] [PATCH 2/2] package/qpid-proton: needs C++ Luca Ceresoli
2021-03-29 11:21   ` Fabrice Fontaine
2021-03-29 10:57 ` [Buildroot] [PATCH 1/2] package/qpid-proton: needs threads Fabrice Fontaine
2021-03-30  9:20   ` Luca Ceresoli

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.