From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] block/export/fuse.c: fix musl build
Date: Mon, 25 Oct 2021 11:50:02 +0200 [thread overview]
Message-ID: <CAPi7W82b_4n4gENnOG78wm6nvOvusNOxhiHZDHg72cyCL5zAnQ@mail.gmail.com> (raw)
In-Reply-To: <YXZ5xOMH1kMfegZ3@redhat.com>
Le lun. 25 oct. 2021 à 11:33, Kevin Wolf <kwolf@redhat.com> a écrit :
>
> Am 22.10.2021 um 11:52 hat Fabrice Fontaine geschrieben:
> > Include linux/falloc.h if CONFIG_FALLOCATE_ZERO_RANGE is defined to fix
> > https://gitlab.com/qemu-project/qemu/-/commit/50482fda98bd62e072c30b7ea73c985c4e9d9bbb
> > and avoid the following build failure on musl:
> >
> > ../block/export/fuse.c: In function 'fuse_fallocate':
> > ../block/export/fuse.c:643:21: error: 'FALLOC_FL_ZERO_RANGE' undeclared (first use in this function)
> > 643 | else if (mode & FALLOC_FL_ZERO_RANGE) {
> > | ^~~~~~~~~~~~~~~~~~~~
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/be24433a429fda681fb66698160132c1c99bc53b
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> This patches makes sense to me, but does this mean that commit 50482fda
> was completely untested and the build still failed after the patch?
First iteration of this patch was tested (and applied on buildroot
side): https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg01394.html.
Unfortunately, second iteration (which was merged) was not tested:
https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg01440.html.
>
> If so, is at least this one tested and builds successfully now?
Yes, this patch builds fine.
>
> Kevin
>
Fabrice
next prev parent reply other threads:[~2021-10-25 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 9:52 [PATCH] block/export/fuse.c: fix musl build Fabrice Fontaine
2021-10-25 6:31 ` Michael Tokarev
2021-10-25 7:08 ` Fabrice Fontaine
2021-10-25 9:32 ` Kevin Wolf
2021-10-25 9:50 ` Fabrice Fontaine [this message]
2021-10-25 11:01 ` Philippe Mathieu-Daudé
2021-10-25 11:05 ` Philippe Mathieu-Daudé
2021-10-25 13:42 ` Kevin Wolf
-- strict thread matches above, loose matches on Subject: below --
2021-08-09 8:50 Fabrice Fontaine
2021-08-09 9:37 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPi7W82b_4n4gENnOG78wm6nvOvusNOxhiHZDHg72cyCL5zAnQ@mail.gmail.com \
--to=fontaine.fabrice@gmail.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.