All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/6] package/collectd: add buddyinfo option
Date: Tue, 14 Apr 2020 19:02:37 +0200	[thread overview]
Message-ID: <CAPi7W831KMEOOe5bVqmmhxVT+ug87C5+Akya7xo8RLPK8MpNHA@mail.gmail.com> (raw)
In-Reply-To: <CALFsTFWYW3rLQunMO3EkDy3_FJMX+KPi2HhNdEsOmMnQCkHtEg@mail.gmail.com>

Hi Asaf

Le mar. 14 avr. 2020 ? 18:51, Asaf Kahlon <asafka7@gmail.com> a ?crit :
>
> Hello,
>
> On Tue, Apr 14, 2020 at 7:36 PM Fabrice Fontaine
> <fontaine.fabrice@gmail.com> wrote:
> >
> > buddyinfo is available since version 5.11.0 and
> > https://github.com/collectd/collectd/commit/cb19ecf90d89a79836b8b5236d2b66277dd79c5f
> >
> > It is currently enabled by default
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/collectd/Config.in   | 5 +++++
> >  package/collectd/collectd.mk | 1 +
> >  2 files changed, 6 insertions(+)
> >
> > diff --git a/package/collectd/Config.in b/package/collectd/Config.in
> > index 15c871025c..1f55271a97 100644
> > --- a/package/collectd/Config.in
> > +++ b/package/collectd/Config.in
> > @@ -128,6 +128,11 @@ config BR2_PACKAGE_COLLECTD_BIND
> >         help
> >           Collects BIND DNS statistics.
> >
> > +config BR2_PACKAGE_BUDDYINFO
> I guess you meant to call this "BR2_PACKAGE_COLLECTD_BUDDYINFO".
Indeed, thanks for spotting this. I made two many patches on collectd
... I'll send a v2.
>
> > +       bool "buddyinfo"
> > +       help
> > +         Statistics from buddyinfo file about memory fragmentation.
> > +
> >  config BR2_PACKAGE_COLLECTD_CAPABILITIES
> >         bool "capabilities"
> >         select BR2_PACKAGE_JANSSON
> > diff --git a/package/collectd/collectd.mk b/package/collectd/collectd.mk
> > index f04ccdb2ff..6bd1754ad7 100644
> > --- a/package/collectd/collectd.mk
> > +++ b/package/collectd/collectd.mk
> > @@ -51,6 +51,7 @@ COLLECTD_CONF_OPTS += \
> >         $(if $(BR2_PACKAGE_COLLECTD_APCUPS),--enable-apcups,--disable-apcups) \
> >         $(if $(BR2_PACKAGE_COLLECTD_BATTERY),--enable-battery,--disable-battery) \
> >         $(if $(BR2_PACKAGE_COLLECTD_BIND),--enable-bind,--disable-bind) \
> > +       $(if $(BR2_PACKAGE_COLLECTD_BUDDYINFO),--enable-buddyinfo,--disable-buddyinfo) \
> >         $(if $(BR2_PACKAGE_COLLECTD_CAPABILITIES),--enable-capabilities,--disable-capabilities) \
> >         $(if $(BR2_PACKAGE_COLLECTD_CEPH),--enable-ceph,--disable-ceph) \
> >         $(if $(BR2_PACKAGE_COLLECTD_CHRONY),--enable-chrony,--disable-chrony) \
> > --
> > 2.25.1
> >
> Regards,
> Asaf.
Best Regards,

Fabrice

      reply	other threads:[~2020-04-14 17:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 16:37 [Buildroot] [PATCH 1/6] package/collectd: drop autoreconf Fabrice Fontaine
2020-04-14 16:37 ` [Buildroot] [PATCH 2/6] package/collectd: remove lvm Fabrice Fontaine
2020-04-14 16:37 ` [Buildroot] [PATCH 3/6] package/collectd: add DPDK_TELEMETRY option Fabrice Fontaine
2020-04-14 16:37 ` [Buildroot] [PATCH 4/6] package/collectd: add InfluxDB support Fabrice Fontaine
2020-04-14 16:37 ` [Buildroot] [PATCH 5/6] package/collectd: add capabilities option Fabrice Fontaine
2020-04-15  5:47   ` Thomas Petazzoni
2020-04-15  6:17     ` Fabrice Fontaine
2020-04-14 16:38 ` [Buildroot] [PATCH 6/6] package/collectd: add buddyinfo option Fabrice Fontaine
2020-04-14 16:51   ` Asaf Kahlon
2020-04-14 17:02     ` Fabrice Fontaine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPi7W831KMEOOe5bVqmmhxVT+ug87C5+Akya7xo8RLPK8MpNHA@mail.gmail.com \
    --to=fontaine.fabrice@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.