Re: [PATCH v4 0/6][Outreachy] commit: Implementation of "amend!" commit

[Eric Sunshine <sunshine@sunshineco.com>]

On Wed, Mar 10, 2021 at 2:43 PM Charvi Mendiratta <charvi077@gmail.com> wrote:
> Changes from v3 :
> (Thanks to Junio C Hamano and Eric Sunshine for the reviews and suggesting the
> improvements required in the previous patches )
>
> * Now `--fixup=reword:` aliases `--fixup=amend: --only`. Added the respective
> test and updated documentation.
> * Modified prepared_amend_commit() in commit.c.
> * Renamed the subject_length() to commit_subject_length() [v3 - 1/6]
> * Modified the --fixup=[amend|reword] documentation
> * Also, updated the commit messages and some other minor cleanup.

Thanks for re-rolling. I left some relatively minor comments on patch
[2/6] and some substantial documentation-related comments on [6/6].
(If you take my suggested documentation rewrites verbatim, you can
have my Signed-off-by: along with them.)

One final request: Please consider using the --range-diff or
--interdiff options or both when preparing your series with
git-format-patch. Doing so can really help reviewers focus on the
changes made from re-roll to re-roll without having to painstakingly
re-read each patch in the series -- even if a patch didn't change --
thus saving time.