All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: "Stephen P. Smith" <ischis2@cox.net>
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	Alexander Kuleshov <kuleshovmail@gmail.com>
Subject: Re: [PATCH v4] format-patch: introduce format.outputDirectory configuration
Date: Sun, 10 Jan 2016 23:00:59 -0500	[thread overview]
Message-ID: <CAPig+cRjBockaXKacYA-pxWQe_gzAAvjAwonQKn1kSANHORt1A@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cSoEYof0quiG=P4SRiOb7FeNDnVsGdzGoxO=oLcgfGBUA@mail.gmail.com>

On Sun, Jan 10, 2016 at 10:55 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sun, Jan 10, 2016 at 7:30 PM, Stephen P. Smith <ischis2@cox.net> wrote:
>> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
>> @@ -1445,4 +1445,20 @@ test_expect_success 'From line has expected format' '
>> +test_expect_success 'format-patch format.outputDirectory option' '
>> +       test_config format.outputDirectory patches &&
>> +       rm -fr patches &&
>> +       git format-patch master..side &&
>> +       ls patches >actual &&
>> +       test_line_count = 3 actual
>> +'
>
> Now that you've moved the new tests to the bottom of the script, this
> test fails. This is because, at this point, there are 18 commits in
> the range 'master..side', not 3 as when the test was at the top of the
> script. You could change the 3 to an 18, however, that would be
> fragile: if someone inserts or modifies tests above this one, then a
> hard-coded 18 might become stale. One possible fix would be:
>
>     test $(git rev-list master..side | wc -l) -eq $(ls patches)

That would be $(ls patches | wc -l), of course.

  reply	other threads:[~2016-01-11  4:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-19 18:28 [PATCH v2] format-patch: introduce format.outputDirectory configuration Alexander Kuleshov
2015-06-19 20:34 ` Eric Sunshine
2015-09-21 22:41   ` Junio C Hamano
2015-09-22  0:05     ` Eric Sunshine
2015-10-28 17:59     ` Junio C Hamano
2016-01-10  2:30   ` [PATCH v3] " Stephen P. Smith
2016-01-10  3:47     ` Eric Sunshine
2016-01-11  0:30       ` [PATCH v4] " Stephen P. Smith
2016-01-11  3:55         ` Eric Sunshine
2016-01-11  4:00           ` Eric Sunshine [this message]
2016-01-13  4:48             ` [PATCH v5] " Stephen P. Smith
2016-01-13  6:52               ` Eric Sunshine
2016-01-13 13:20                 ` [PATCH v6] " Stephen P. Smith
2016-01-13 18:27                   ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cRjBockaXKacYA-pxWQe_gzAAvjAwonQKn1kSANHORt1A@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ischis2@cox.net \
    --cc=kuleshovmail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.