From: Eric Sunshine <sunshine@sunshineco.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t: fix whitespace around &&
Date: Sun, 15 Mar 2020 14:38:24 -0400 [thread overview]
Message-ID: <CAPig+cSE-c8ax8MyPg3QsDhgvRWt1HGRkV3x6WXJWEUbJQ_yJA@mail.gmail.com> (raw)
In-Reply-To: <0ad0600c-d1fc-0f44-dae1-7bd0fc22b3e8@gmail.com>
On Sun, Mar 15, 2020 at 2:35 PM Andrei Rybak <rybak.a.v@gmail.com> wrote:
> On 2020-03-15 19:20, Eric Sunshine wrote:
> > On Sun, Mar 15, 2020 at 2:09 PM Andrei Rybak <rybak.a.v@gmail.com> wrote:
> >> - echo "To be changed and have mode changed" > 07-change-mode-change &&
> >> + echo "To be changed and have mode changed" > 07-change-mode-change &&
> >
> > The commit message talks about dropping whitespace after the '>'
> > redirection operator (and some of the changes in this patch do so),
> > however, this change neglects that cleanup.
>
> Good catch. t9500-gitweb-standalone-no-errors.sh has 35 of these vs 19
> redirects with correct formatting, so it might be better to fix those redirects
> in a separate patch. What do you think?
Yes, fixing it in a separate patch makes sense.
next prev parent reply other threads:[~2020-03-15 18:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 18:09 [PATCH] t: fix whitespace around && Andrei Rybak
2020-03-15 18:20 ` Eric Sunshine
2020-03-15 18:35 ` Andrei Rybak
2020-03-15 18:38 ` Eric Sunshine [this message]
2020-03-22 21:14 ` [PATCH v2 1/2] t9500: remove spaces after redirect operators Andrei Rybak
2020-03-22 21:14 ` [PATCH v2 2/2] t: fix whitespace around && Andrei Rybak
2020-03-22 23:45 ` Junio C Hamano
2021-06-07 13:13 [PATCH] " Andrei Rybak
2021-06-07 14:10 ` Derrick Stolee
2021-06-07 18:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cSE-c8ax8MyPg3QsDhgvRWt1HGRkV3x6WXJWEUbJQ_yJA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=rybak.a.v@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.