From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 031F61F453 for ; Wed, 3 Oct 2018 07:49:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727355AbeJCOgp convert rfc822-to-8bit (ORCPT ); Wed, 3 Oct 2018 10:36:45 -0400 Received: from mail-qt1-f170.google.com ([209.85.160.170]:33803 "EHLO mail-qt1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726883AbeJCOgp (ORCPT ); Wed, 3 Oct 2018 10:36:45 -0400 Received: by mail-qt1-f170.google.com with SMTP id x23-v6so4938337qtr.1 for ; Wed, 03 Oct 2018 00:49:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9BZm1h2hbY6X91cR83HNjs7mh+cogK7ZdbykIBMUuHk=; b=dq2R1uMcCJEuhknIWuDAbhR6PG3ppAeykQeZ7Wb0lkmWvgFhwbRlkj0OQV1BUe3ouh Emr7uXED1SuMW5ixM9eHU7ohCdFX7WHndY98yKIgSybjxMs/uRfY3AV9tMROuMrLlKoB hlzupdQNuHwFhCMy913ngjjqrBm1y2HdTKph2+SMtuyo7jMfGTm9pKlBXTxegXZmM/RP Atd1LSAgxvkfsD5JmcpxjKpxagwd++yjQB8NThTSxo892vu/Cpr5wJjmk8HcoKgYh1+L xPw8Lekfed0Vv2b2CtikjuY1XPOlhYSn23OUEDG8uvbLAGF6wZiYvNh3gmX/A9aiDJDd aNyQ== X-Gm-Message-State: ABuFfoiUkp7eBxDApAtyyf3Du8ZbRtcBB7Q5BeEicGynkHvIs6av74Ia Cr6jz0zDNqzWRVeqLf29MwHzjwZTmyUv0N0Xrv0= X-Google-Smtp-Source: ACcGV60TCZcppBfoG/HSAAfWuzR/1bX2/gO7qlp/h6ihgAgxHSn8/I4gcEkQEVw28SluKvybTx6zaBLss5aZ1Mw2axw= X-Received: by 2002:a0c:b3d6:: with SMTP id b22-v6mr181371qvf.203.1538552970379; Wed, 03 Oct 2018 00:49:30 -0700 (PDT) MIME-Version: 1.0 References: <20180922180500.4689-1-pclouds@gmail.com> <20180929191029.13994-1-pclouds@gmail.com> <20180929191029.13994-9-pclouds@gmail.com> In-Reply-To: From: Eric Sunshine Date: Wed, 3 Oct 2018 03:49:20 -0400 Message-ID: Subject: Re: [PATCH v2 8/8] reflog expire: cover reflog from all worktrees To: =?UTF-8?B?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?= Cc: Git List , Elijah Newren , Jeff King , Junio C Hamano , Stefan Beller Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Oct 2, 2018 at 12:16 PM Duy Nguyen wrote: > On Sun, Sep 30, 2018 at 7:36 AM Eric Sunshine wrote: > > On Sat, Sep 29, 2018 at 3:11 PM Nguyễn Thái Ngọc Duy wrote: > > > +--single-worktree:: > > > + By default when `--all` is specified, reflogs from all working > > > + trees are processed. This option limits the processing to reflogs > > > + from the current working tree only. > > > > Bikeshedding: I wonder if this should be named "--this-worktree" or > > "--this-worktree-only" or if it should somehow be orthogonal to --all > > rather than modifying it. (Genuine questions. I don't have the > > answers.) > > It follows a precedent (made by me :p) which is rev-list > --single-worktree. I doubt that option is widely used though so we > could still rename it if there's a better name. I made > --single-worktree to contrast "all worktrees" by default. Even if it's > "this/current worktree" it still has to somehow say "everything in > this worktree" so I felt modifying --all was a good idea. Precedent overrides bikeshedding, so leaving it as-is is fine.