From: Eric Sunshine <sunshine@sunshineco.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2 0/3] config: free resources of `struct config_store_data`
Date: Wed, 23 May 2018 03:01:35 -0400 [thread overview]
Message-ID: <CAPig+cSR=GnXvOcsxZmskmdQTM+59SpUis28y7RfhfA_-MGi3w@mail.gmail.com> (raw)
In-Reply-To: <cover.1526812503.git.martin.agren@gmail.com>
On Sun, May 20, 2018 at 6:42 AM, Martin Ågren <martin.agren@gmail.com> wrote:
> On 14 May 2018 at 05:03, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Sun, May 13, 2018 at 5:58 AM, Martin Ågren <martin.agren@gmail.com> wrote:
>>> How about the following two patches as patches 2/3 and 3/3? I would also
>>> need to mention in the commit message of this patch (1/3) that the
>>> function will soon learn to clean up more members.
>>
>> Yep, making this a multi-part patch series and updating the commit
>> message of the patch which introduces config_store_data_clear(), as
>> you suggest, makes sense. The patch series could be organized
>> differently -- such as first moving freeing of 'value_regex' into new
>> config_store_data_clear(), then freeing additional fields in later
>> patches -- but I don't think it matters much in practice, so the
>> current organization is likely good enough.
>
> I tried such a re-ordering but wasn't entirely happy about the result
> (maybe I didn't try hard enough), so here are these patches again, as a
> proper series and with improved commit messages.
The re-roll looks good; it address my concern about v1. Thanks.
next prev parent reply other threads:[~2018-05-23 7:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-13 8:23 [PATCH] config: free resources of `struct config_store_data` Martin Ågren
2018-05-13 8:59 ` Eric Sunshine
2018-05-13 9:58 ` Martin Ågren
2018-05-13 9:58 ` [PATCH 2/1] config: let `config_store_data_clear()` handle `value_regex` Martin Ågren
2018-05-14 3:05 ` Eric Sunshine
2018-05-20 10:50 ` [PATCH] regex: do not call `regfree()` if compilation fails Martin Ågren
2018-05-21 18:43 ` Stefan Beller
2018-05-22 2:20 ` Eric Sunshine
2018-05-22 11:00 ` Martin Ågren
2018-05-13 9:58 ` [PATCH 3/1] config: let `config_store_data_clear()` handle `key` Martin Ågren
2018-05-14 3:03 ` [PATCH] config: free resources of `struct config_store_data` Eric Sunshine
2018-05-20 10:42 ` [PATCH v2 0/3] " Martin Ågren
2018-05-20 10:42 ` [PATCH v2 1/3] " Martin Ågren
2018-05-20 10:42 ` [PATCH v2 2/3] config: let `config_store_data_clear()` handle `value_regex` Martin Ågren
2018-05-20 10:42 ` [PATCH v2 3/3] config: let `config_store_data_clear()` handle `key` Martin Ågren
2018-05-23 7:03 ` Eric Sunshine
2018-05-23 7:01 ` Eric Sunshine [this message]
2018-05-13 18:40 ` [PATCH] config: free resources of `struct config_store_data` Martin Ågren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cSR=GnXvOcsxZmskmdQTM+59SpUis28y7RfhfA_-MGi3w@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.