Re: [PATCH v8] ls-files: introduce "--format" option

From: Eric Sunshine <sunshine@sunshineco.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com>,
	"Git List" <git@vger.kernel.org>,
	"Christian Couder" <christian.couder@gmail.com>,
	"Phillip Wood" <phillip.wood123@gmail.com>,
	"Torsten Bögershausen" <tboegi@web.de>,
	"ZheNing Hu" <adlternative@gmail.com>
Subject: Re: [PATCH v8] ls-files: introduce "--format" option
Date: Thu, 21 Jul 2022 13:22:17 -0400	[thread overview]
Message-ID: <CAPig+cTAnVjk9gepW33AW9SSpCTJ7FpNSaB_7M-wV+tTe6D04A@mail.gmail.com> (raw)
In-Reply-To: <220721.86ilnqtq8f.gmgdl@evledraar.gmail.com>

On Thu, Jul 21, 2022 at 12:07 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> On Wed, Jul 20 2022, Junio C Hamano wrote:
> > "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
> > It's been quite many iterations, so I'll just comment on the range-diff.
> >
> >>      -+                      usage_msg_opt("--format cannot used with -s, -o, -k, -t"
> >>      ++                      usage_msg_opt("--format cannot used with -s, -o, -k, -t, "
> >>       +                                    "--resolve-undo, --deduplicate, --eol",
> >>       +                                    ls_files_usage, builtin_ls_files_options);
> >
> > Looks good.
>
> Although a nit I didn't spot before: missing _() & this should be marked
> for translation, surely...

Probably also want: s/cannot used/cannot be used/