From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: "John A. Leuenhagen" <john@zlima12.com>,
Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] clone: allow "--bare" with "-o"
Date: Thu, 22 Sep 2022 01:58:36 -0400 [thread overview]
Message-ID: <CAPig+cTEF=jBoW07_eLQ_BAWxULfWtehVa-JbJKpS+8rPenSiQ@mail.gmail.com> (raw)
In-Reply-To: <YyvzVdfQVdysvMp2@coredump.intra.peff.net>
On Thu, Sep 22, 2022 at 1:33 AM Jeff King <peff@peff.net> wrote:
> [...]
> Let's allow the options to be used together, and switch the "forbid"
> test in t5606 to check that we use the requested name. That test came
> much later in 349cff76de (clone: add tests for --template and some
> disallowed option pairs, 2020-09-29), and does not offer any logic
> beyond "let's test what the code currently does".
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> diff --git a/t/t5606-clone-options.sh b/t/t5606-clone-options.sh
> @@ -42,11 +42,12 @@ test_expect_success 'rejects invalid -o/--origin' '
> +test_expect_success 'clone --bare -o' '
> + git clone -o foo --bare parent clone-bare-o &&
> + (cd parent && pwd) >expect &&
> + git -C clone-bare-o config remote.foo.url >actual &&
> + test_cmp expect actual
> '
Is this safe on Microsoft Windows? My understanding from t/README:
When a test checks for an absolute path that a git command
generated, construct the expected value using $(pwd) rather than
$PWD, $TEST_DIRECTORY, or $TRASH_DIRECTORY. It makes a difference
on Windows, where the shell (MSYS bash) mangles absolute path
names. For details, see the commit message of 4114156ae9.
was that you should use $(pwd) rather than raw `pwd` when comparing
against a path generated by Git. Is there a gap in my understanding
here?
next prev parent reply other threads:[~2022-09-22 5:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 19:23 fatal: options '--bare' and '--origin foo' cannot be used together John A. Leuenhagen
2022-09-22 4:55 ` Jeff King
2022-09-22 5:31 ` Jeff King
2022-09-22 5:32 ` [PATCH 1/2] clone: allow "--bare" with "-o" Jeff King
2022-09-22 5:58 ` Eric Sunshine [this message]
2022-09-22 6:18 ` Jeff King
2022-09-22 6:26 ` Eric Sunshine
2022-09-22 6:35 ` Jeff King
2022-09-22 6:40 ` Eric Sunshine
2022-09-22 6:26 ` Jeff King
2022-09-22 5:33 ` [PATCH 2/2] remote: handle rename of remote without fetch refspec Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTEF=jBoW07_eLQ_BAWxULfWtehVa-JbJKpS+8rPenSiQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@zlima12.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.