From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: Stefan Beller <sbeller@google.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] CodingGuidelines: mention "static" and "extern"
Date: Thu, 8 Feb 2018 18:14:06 -0500 [thread overview]
Message-ID: <CAPig+cT_ddVSEvdnMTNhtxWJMm4=DLyq8-hSDXa5X0i6rXa3xA@mail.gmail.com> (raw)
In-Reply-To: <20180208213806.GA6381@sigill.intra.peff.net>
On Thu, Feb 8, 2018 at 4:38 PM, Jeff King <peff@peff.net> wrote:
> Subject: [PATCH] CodingGuidelines: mention "static" and "extern"
> [...]
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> @@ -386,6 +386,11 @@ For C programs:
> + - Variables and functions local to a given source file should be marked
> + with "static". Variables that are visible to other source files
> + must be declared with "extern" in header files. However, function
> + declarations should not use "extern", as that is already the default.
Perhaps:
... as that is already the default, unless declarations in the
header are already "extern", in which case consistency
may favor mirroring existing usage.
or something.
next prev parent reply other threads:[~2018-02-08 23:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 20:15 [PATCH] color.h: document and modernize header Stefan Beller
2018-02-08 20:43 ` Jeff King
2018-02-08 21:04 ` Stefan Beller
2018-02-08 21:38 ` [PATCH] CodingGuidelines: mention "static" and "extern" Jeff King
2018-02-08 21:43 ` Stefan Beller
2018-02-08 23:14 ` Eric Sunshine [this message]
2018-02-09 19:07 ` Jonathan Tan
2018-02-09 19:33 ` Jeff King
2018-02-08 22:26 ` [PATCH] color.h: document and modernize header Eric Sunshine
2018-02-08 22:28 ` Jeff King
2018-02-12 20:19 ` Stefan Beller
2018-02-12 22:14 ` Eric Sunshine
2018-02-13 1:41 ` Stefan Beller
2018-02-13 3:55 ` Eric Sunshine
2018-02-14 7:23 ` Eric Sunshine
2018-02-14 17:58 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cT_ddVSEvdnMTNhtxWJMm4=DLyq8-hSDXa5X0i6rXa3xA@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.