From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADCFAC433FE for ; Tue, 15 Mar 2022 12:43:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245326AbiCOMon (ORCPT ); Tue, 15 Mar 2022 08:44:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235627AbiCOMom (ORCPT ); Tue, 15 Mar 2022 08:44:42 -0400 Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6369033EAD for ; Tue, 15 Mar 2022 05:43:30 -0700 (PDT) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-2dbd97f9bfcso199606887b3.9 for ; Tue, 15 Mar 2022 05:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zM7PG/RdRHw9f6iBibZ0hDNw+hF+S/2aL5rwx9V5Hc4=; b=nR1qrXaPmooiwTywf1pOo2XV8jI1aj+ALhV1WYrZn8Bzit9fW9AkhOG0+z7MOxAjh1 iqTMLE8f8HzEoR35CgDLZzU0x1YPDlaLtonEqs9Iy91kn52Z/+eCH6IkbFQPKpsL45/t ihJl/3hcliojHC4Bba1/Y7IsjIJX9NCsJ/zUG5GKDT/Wcn7YD0Uwgq2a0kK4ye807Bc5 78oVtw5/voG4BakSHOOLW+RH2YpWTZMd21BFkVgioDCwuQq/aj2Wu9gsTzuO67FFaNIu VT9DNke3Hl0zWtAQr554hmchGXyzYveuj+5IJd0+2DUzQ8gqm4qCnQ4KtLqSAJuenwaI eFvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zM7PG/RdRHw9f6iBibZ0hDNw+hF+S/2aL5rwx9V5Hc4=; b=gtkdhmjulxjFxsz7Kr/+cs9u0Uj2uppqcB8XLiHQpwu38V4C9Tsr/tO7tQdF84zjnK 6ZdJs17kqQqV4eQ1FJpO02mdb9MVdLEsVtvb5tVBoM705Qi/R1M+Gr/8uLzPwpqFQ8l7 HNI9jSBMPCyuLzI1SPajA30gegQYI3wNmCr2wdcv1Wn/2mTuTSyVnH9OhxrBzj/PnZyR xJMyyp3GvjDVILbFVkt+gEQvBBJ4sMEKq6uA/vkSh+po6Ip+FRLWpxj5GtQwY/foO3Qk qI401eO0oAoKCc1VipLWqHMdV5iEQFJGrJP3v9pKbrXm3ukZjq0rfnR96IgXf5OxCTGQ A6iA== X-Gm-Message-State: AOAM530x0DAbkGiaXPM2wNCs+8AXu1W2+DLF/OXTfarpddiZ5mg7K7JF 7PqEtSccqggh8JBvrCJ0wC8JqhJVTa9tepnnnNnfEn4PWvoyuA== X-Google-Smtp-Source: ABdhPJyazqAxW0/G7WqBT80tfyS+1LBtCC3BjhRKfI/GlPsN1UNW//Fy3MNB2ipKA2wpPQtmC2JXOlJLZOMZ75di+uk= X-Received: by 2002:a81:1182:0:b0:2dc:4e58:da41 with SMTP id 124-20020a811182000000b002dc4e58da41mr24091863ywr.268.1647348209540; Tue, 15 Mar 2022 05:43:29 -0700 (PDT) MIME-Version: 1.0 References: <20220311083323.887372-1-s.hauer@pengutronix.de> <20220311083323.887372-23-s.hauer@pengutronix.de> <9ec29d9b-8197-98fb-c612-5c842e4212c4@rock-chips.com> In-Reply-To: <9ec29d9b-8197-98fb-c612-5c842e4212c4@rock-chips.com> From: Daniel Stone Date: Tue, 15 Mar 2022 12:43:18 +0000 Message-ID: Subject: Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver To: Andy Yan Cc: Sascha Hauer , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Andy, On Tue, 15 Mar 2022 at 06:46, Andy Yan wrote: > On 3/11/22 16:33, Sascha Hauer wrote: > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with weston-simple-dmabuf-egl on > > weston using the (yet to be upstreamed) panfrost driver support. > > Do we need some modification to test AFBC by weston-simple-dma-egl ? > > I have a buildroot system with weston-10.0.9 and mesa 21.3.5. > > After launch weston, I run weston-simple-dmabuf-egl, but from the output > > of sys/kernel/debug/dri/0/state, the weston is still use Smart0-win0, > which is > > a non-AFBC window. > > Do i need to modify the vop2 driver to set one Cluster window as primary > plane? Are you using the open-source Panfrost driver, or the proprietary Arm DDK? The DDK was previously using some non-standard modifier tokens which have since been corrected upstream. You can see from running `weston-debug drm-backend` (if you start Weston with `--debug`) the output as it tries to put client surfaces on to overlay planes, and why it can or cannot. For Weston's own composited output (used when it cannot place client surfaces on to planes), it will just use whatever the KMS driver declares as the primary plane. Weston does not have any logic to say 'oh, this plane is AFBC and AFBC is better, so I will use this as my primary plane': we just follow what the kernel tells us. Cheers, Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7336C433EF for ; Tue, 15 Mar 2022 12:43:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HVq5C53lFf1jrwd6ooavfOX1A2Yi2IkfXfvhXPpAbN4=; b=V45VHOKimRUXue Q7NfLLFYaDGA9k9brSwgZ7YLEZ/uuD/tuED5y8AvPwncBDA2mmGecfgIK+um3sk9+314zkMZ6aRje MrTfaQqhhtieI/8ImJnnwXiD4ABjXCWWxZKyqGkw82/9UYGMD0IDAzknfyU+ZVpzzlmnQypvOG2nd GHOIaGV9fbxc7CVUVBbGpqPhnaTBgWMnHzJ3sm7dVjUIAkHb5jasvCw8zPuBWRu+PuM6+nc8Ww5u5 Vjjf0SfyenTbpuh6AL15Q+JpuTrTYzrcK9/XgUuDFS6mCEARAVox6ZVf5gtYQYPChKDspvinv93q4 vHs5hfs0WkRqZ+plXbXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU6WU-009321-1S; Tue, 15 Mar 2022 12:43:34 +0000 Received: from mail-yw1-x112f.google.com ([2607:f8b0:4864:20::112f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU6WR-00930z-0O for linux-rockchip@lists.infradead.org; Tue, 15 Mar 2022 12:43:32 +0000 Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-2e57826a10bso41650957b3.7 for ; Tue, 15 Mar 2022 05:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zM7PG/RdRHw9f6iBibZ0hDNw+hF+S/2aL5rwx9V5Hc4=; b=nR1qrXaPmooiwTywf1pOo2XV8jI1aj+ALhV1WYrZn8Bzit9fW9AkhOG0+z7MOxAjh1 iqTMLE8f8HzEoR35CgDLZzU0x1YPDlaLtonEqs9Iy91kn52Z/+eCH6IkbFQPKpsL45/t ihJl/3hcliojHC4Bba1/Y7IsjIJX9NCsJ/zUG5GKDT/Wcn7YD0Uwgq2a0kK4ye807Bc5 78oVtw5/voG4BakSHOOLW+RH2YpWTZMd21BFkVgioDCwuQq/aj2Wu9gsTzuO67FFaNIu VT9DNke3Hl0zWtAQr554hmchGXyzYveuj+5IJd0+2DUzQ8gqm4qCnQ4KtLqSAJuenwaI eFvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zM7PG/RdRHw9f6iBibZ0hDNw+hF+S/2aL5rwx9V5Hc4=; b=waENW9SzEYnDv09ZViZKAwrK948CRyEKSHjuyTyYwpsvwWWMFwUo5SzzLVMP6jupMf T1c6JFpJkxntFHyZ2ldXRqUk9GcYLmfsErWDXPQ+HjG3byfUxcUE/WPgfphhywoblt1E wJkqsoigKNsSyhT5IRE7t8/1bhR3HXwh9SWT2/8LPcW3I/Qc/LvESBb1LeJQay7zS53X seVpQIxNy2ct86unsBIKN7r/Mazi8MEM2PHUDl0eVU7mwNC693NVqTnLBaFddcr0dRDE Rk72TdRogtTqhwVJ6nyPl06lzc8F1urFHNSnWh6OzlDY62LWYHY/c8hj2n4mBwJjrBas xdRw== X-Gm-Message-State: AOAM531BUPZ/s+kld25UZZmZY++x4eOtQiU/QTKp3P8/WP4c8m1ghTqI tRywW8pf0qeTtFhyo8+cWTaNSTBu4FKnUrGPt3FcUQ== X-Google-Smtp-Source: ABdhPJyazqAxW0/G7WqBT80tfyS+1LBtCC3BjhRKfI/GlPsN1UNW//Fy3MNB2ipKA2wpPQtmC2JXOlJLZOMZ75di+uk= X-Received: by 2002:a81:1182:0:b0:2dc:4e58:da41 with SMTP id 124-20020a811182000000b002dc4e58da41mr24091863ywr.268.1647348209540; Tue, 15 Mar 2022 05:43:29 -0700 (PDT) MIME-Version: 1.0 References: <20220311083323.887372-1-s.hauer@pengutronix.de> <20220311083323.887372-23-s.hauer@pengutronix.de> <9ec29d9b-8197-98fb-c612-5c842e4212c4@rock-chips.com> In-Reply-To: <9ec29d9b-8197-98fb-c612-5c842e4212c4@rock-chips.com> From: Daniel Stone Date: Tue, 15 Mar 2022 12:43:18 +0000 Message-ID: Subject: Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver To: Andy Yan Cc: Sascha Hauer , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_054331_120603_2623D25C X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Andy, On Tue, 15 Mar 2022 at 06:46, Andy Yan wrote: > On 3/11/22 16:33, Sascha Hauer wrote: > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with weston-simple-dmabuf-egl on > > weston using the (yet to be upstreamed) panfrost driver support. > > Do we need some modification to test AFBC by weston-simple-dma-egl ? > > I have a buildroot system with weston-10.0.9 and mesa 21.3.5. > > After launch weston, I run weston-simple-dmabuf-egl, but from the output > > of sys/kernel/debug/dri/0/state, the weston is still use Smart0-win0, > which is > > a non-AFBC window. > > Do i need to modify the vop2 driver to set one Cluster window as primary > plane? Are you using the open-source Panfrost driver, or the proprietary Arm DDK? The DDK was previously using some non-standard modifier tokens which have since been corrected upstream. You can see from running `weston-debug drm-backend` (if you start Weston with `--debug`) the output as it tries to put client surfaces on to overlay planes, and why it can or cannot. For Weston's own composited output (used when it cannot place client surfaces on to planes), it will just use whatever the KMS driver declares as the primary plane. Weston does not have any logic to say 'oh, this plane is AFBC and AFBC is better, so I will use this as my primary plane': we just follow what the kernel tells us. Cheers, Daniel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F3BCC433EF for ; Tue, 15 Mar 2022 12:43:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCF2610E3F1; Tue, 15 Mar 2022 12:43:31 +0000 (UTC) Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72EB410E3F1 for ; Tue, 15 Mar 2022 12:43:30 +0000 (UTC) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-2db2add4516so200382277b3.1 for ; Tue, 15 Mar 2022 05:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zM7PG/RdRHw9f6iBibZ0hDNw+hF+S/2aL5rwx9V5Hc4=; b=nR1qrXaPmooiwTywf1pOo2XV8jI1aj+ALhV1WYrZn8Bzit9fW9AkhOG0+z7MOxAjh1 iqTMLE8f8HzEoR35CgDLZzU0x1YPDlaLtonEqs9Iy91kn52Z/+eCH6IkbFQPKpsL45/t ihJl/3hcliojHC4Bba1/Y7IsjIJX9NCsJ/zUG5GKDT/Wcn7YD0Uwgq2a0kK4ye807Bc5 78oVtw5/voG4BakSHOOLW+RH2YpWTZMd21BFkVgioDCwuQq/aj2Wu9gsTzuO67FFaNIu VT9DNke3Hl0zWtAQr554hmchGXyzYveuj+5IJd0+2DUzQ8gqm4qCnQ4KtLqSAJuenwaI eFvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zM7PG/RdRHw9f6iBibZ0hDNw+hF+S/2aL5rwx9V5Hc4=; b=R5g+k/QgQBYkDshP5ZVlPVJda+nhlNZXr8SInzM2w6ij+Xo5aqAqyIBSIP4NaF2rkT 5KBftGURMma4AjFfZtSvDSwXoAUyBpVvattCvkKtPDteLzxelSn0DA7EnwHTY21uyTJX oGaeL3x6SsXTaypqTCOfhONtFRJYBE4ppw7IQ1YsSrc7y1Gg5pRmEEj/kGVAgIK1WNZX ozdpbDd6PyAW+mCg2nUeLXO0PeQRYxBFNtVErTk7ROFpchXMTYSah0KeCOvU6eJsoNKO eNvOhvi6jBRZX+1f6ih7xxVbX4zeVjd3Th3kGTWlmCXbOdDJSFcdyfLJQuLj5m8V/2D1 oWLw== X-Gm-Message-State: AOAM533NAd/Ch0WuUD4XW6um/8xkW+ttUZ1Oktg+WZwRQp6693HTL5tF xudS6UQGLtKAYjZyWS55prnXdvLYG/4avDKKEFnSTg== X-Google-Smtp-Source: ABdhPJyazqAxW0/G7WqBT80tfyS+1LBtCC3BjhRKfI/GlPsN1UNW//Fy3MNB2ipKA2wpPQtmC2JXOlJLZOMZ75di+uk= X-Received: by 2002:a81:1182:0:b0:2dc:4e58:da41 with SMTP id 124-20020a811182000000b002dc4e58da41mr24091863ywr.268.1647348209540; Tue, 15 Mar 2022 05:43:29 -0700 (PDT) MIME-Version: 1.0 References: <20220311083323.887372-1-s.hauer@pengutronix.de> <20220311083323.887372-23-s.hauer@pengutronix.de> <9ec29d9b-8197-98fb-c612-5c842e4212c4@rock-chips.com> In-Reply-To: <9ec29d9b-8197-98fb-c612-5c842e4212c4@rock-chips.com> From: Daniel Stone Date: Tue, 15 Mar 2022 12:43:18 +0000 Message-ID: Subject: Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver To: Andy Yan Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sascha Hauer , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Andy, On Tue, 15 Mar 2022 at 06:46, Andy Yan wrote: > On 3/11/22 16:33, Sascha Hauer wrote: > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with weston-simple-dmabuf-egl on > > weston using the (yet to be upstreamed) panfrost driver support. > > Do we need some modification to test AFBC by weston-simple-dma-egl ? > > I have a buildroot system with weston-10.0.9 and mesa 21.3.5. > > After launch weston, I run weston-simple-dmabuf-egl, but from the output > > of sys/kernel/debug/dri/0/state, the weston is still use Smart0-win0, > which is > > a non-AFBC window. > > Do i need to modify the vop2 driver to set one Cluster window as primary > plane? Are you using the open-source Panfrost driver, or the proprietary Arm DDK? The DDK was previously using some non-standard modifier tokens which have since been corrected upstream. You can see from running `weston-debug drm-backend` (if you start Weston with `--debug`) the output as it tries to put client surfaces on to overlay planes, and why it can or cannot. For Weston's own composited output (used when it cannot place client surfaces on to planes), it will just use whatever the KMS driver declares as the primary plane. Weston does not have any logic to say 'oh, this plane is AFBC and AFBC is better, so I will use this as my primary plane': we just follow what the kernel tells us. Cheers, Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62352C433F5 for ; Tue, 15 Mar 2022 12:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dshOsuD7XnbL+M0Uqkp9F9l32F2Ot1GFYkZMjFD0dzE=; b=bXzoEnDMiFd2h8 KVXqjjaFEwj7HskdGzjDjAqjy//TMmlyrYT+qAqy8u/LZQD1HCtM7vvvdxAOHZeBPo1k+7J8bwZQM NOxmr5zfBP+fkMaPfYM6EOQ0MKcrwD5tJ8nx9b7B7ZrR6SJejMnEI2ZNjj0Ju/dmTYAG/bLK2Z+YK OixT5Bvf1EkSjxolx5yOs65UYUQ4FS0mhsUOiNHz56Kny8JgnQFWvnvps2ecjesot/eUeqDDZ/FjD DYCoFO4+oCMuTJiSY8WAaEjqnIjnE7kDE2ebUyvUNPHo7KIgB39i2qysSC4GoXUtpcgtH5EFt7uK7 Q3mjtgh+KKsqVsBqUZyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU6WV-009326-7t; Tue, 15 Mar 2022 12:43:35 +0000 Received: from mail-yw1-x1135.google.com ([2607:f8b0:4864:20::1135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU6WR-009310-0d for linux-arm-kernel@lists.infradead.org; Tue, 15 Mar 2022 12:43:32 +0000 Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-2d07ae0b1c0so200084607b3.2 for ; Tue, 15 Mar 2022 05:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zM7PG/RdRHw9f6iBibZ0hDNw+hF+S/2aL5rwx9V5Hc4=; b=nR1qrXaPmooiwTywf1pOo2XV8jI1aj+ALhV1WYrZn8Bzit9fW9AkhOG0+z7MOxAjh1 iqTMLE8f8HzEoR35CgDLZzU0x1YPDlaLtonEqs9Iy91kn52Z/+eCH6IkbFQPKpsL45/t ihJl/3hcliojHC4Bba1/Y7IsjIJX9NCsJ/zUG5GKDT/Wcn7YD0Uwgq2a0kK4ye807Bc5 78oVtw5/voG4BakSHOOLW+RH2YpWTZMd21BFkVgioDCwuQq/aj2Wu9gsTzuO67FFaNIu VT9DNke3Hl0zWtAQr554hmchGXyzYveuj+5IJd0+2DUzQ8gqm4qCnQ4KtLqSAJuenwaI eFvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zM7PG/RdRHw9f6iBibZ0hDNw+hF+S/2aL5rwx9V5Hc4=; b=21z7f1S50ctMsWsxEASgPzMQx70vRxgoXGiFbjzWxh+IobvkxD5KE4FeflfVh9DMGu LjDi8EE+tN9oMTEs8tc4CbTNnqdYpkSWUFk000tmnxgUCXBjVnJzxmTYSyPhgEyr209o +zUpLB6fwTrSHahk6eIG1ewzfjbciO504OF7X3d0OBuCvfIvNvy3BuqAnmgIVzXxHnX4 Nt8AxWKDIPJogSJbBIhibwjIgk9k4ZuFHa1L2Jo3XAIWHt7yY3fZ5+qtxcnnO63jlFKy Qph/N/R/pbklWqrhRb+P79CZzMG0PT3ZeXhDAKe2XdnxRYG971LrucO2lLJO46Q6PVUF wEBw== X-Gm-Message-State: AOAM532JVxpDZ4sUsK+7wd9hbEhBnYxUWLNszctp1s21lAwcTQ4K2+g7 nlEHyz6vuGPdpQ1T+Qw1MGkp1DzoorVs1ivSuRk3rQ== X-Google-Smtp-Source: ABdhPJyazqAxW0/G7WqBT80tfyS+1LBtCC3BjhRKfI/GlPsN1UNW//Fy3MNB2ipKA2wpPQtmC2JXOlJLZOMZ75di+uk= X-Received: by 2002:a81:1182:0:b0:2dc:4e58:da41 with SMTP id 124-20020a811182000000b002dc4e58da41mr24091863ywr.268.1647348209540; Tue, 15 Mar 2022 05:43:29 -0700 (PDT) MIME-Version: 1.0 References: <20220311083323.887372-1-s.hauer@pengutronix.de> <20220311083323.887372-23-s.hauer@pengutronix.de> <9ec29d9b-8197-98fb-c612-5c842e4212c4@rock-chips.com> In-Reply-To: <9ec29d9b-8197-98fb-c612-5c842e4212c4@rock-chips.com> From: Daniel Stone Date: Tue, 15 Mar 2022 12:43:18 +0000 Message-ID: Subject: Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver To: Andy Yan Cc: Sascha Hauer , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_054331_120495_1B595FB3 X-CRM114-Status: GOOD ( 21.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Tue, 15 Mar 2022 at 06:46, Andy Yan wrote: > On 3/11/22 16:33, Sascha Hauer wrote: > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with weston-simple-dmabuf-egl on > > weston using the (yet to be upstreamed) panfrost driver support. > > Do we need some modification to test AFBC by weston-simple-dma-egl ? > > I have a buildroot system with weston-10.0.9 and mesa 21.3.5. > > After launch weston, I run weston-simple-dmabuf-egl, but from the output > > of sys/kernel/debug/dri/0/state, the weston is still use Smart0-win0, > which is > > a non-AFBC window. > > Do i need to modify the vop2 driver to set one Cluster window as primary > plane? Are you using the open-source Panfrost driver, or the proprietary Arm DDK? The DDK was previously using some non-standard modifier tokens which have since been corrected upstream. You can see from running `weston-debug drm-backend` (if you start Weston with `--debug`) the output as it tries to put client surfaces on to overlay planes, and why it can or cannot. For Weston's own composited output (used when it cannot place client surfaces on to planes), it will just use whatever the KMS driver declares as the primary plane. Weston does not have any logic to say 'oh, this plane is AFBC and AFBC is better, so I will use this as my primary plane': we just follow what the kernel tells us. Cheers, Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel