From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 224BEC433F5 for ; Wed, 23 Mar 2022 14:00:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 54AE710E6E3; Wed, 23 Mar 2022 14:00:33 +0000 (UTC) Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B94510E6E7 for ; Wed, 23 Mar 2022 14:00:32 +0000 (UTC) Received: by mail-yb1-xb31.google.com with SMTP id t11so2843582ybi.6 for ; Wed, 23 Mar 2022 07:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WXmsudQE/TvO9iiY9zNu+1IylJ/3Toy3swSwCKBPOo8=; b=pLPt4Nny0j0BQLv4HIqLC3M+OAARYiL7j99SY2OpCpU5uMTMP73/MrCrJe1qGuG6z3 LbV9s/x/7bxnISY8mUpG0XzF0ugw7k3K5bL0znrMDaptTcAwr3wXVL/rAU3TUvGERTD0 eyT4equSyxkz8pweRVpOnMFupFINS4YY5vYVvclUw7yLdVECrnJSCQmBZf4YZ5ueD/wB Xfl5u508JiydNzfJJdCPoUIPVOX3K3/9Wrg5Cir5Q8sIc89cdmO1mP0CYlkCldvzXm7M dP3/kJWAlV9wrMuz86UIBwBIBlyFGomcM0amaSo6CvWxcGg7aUeB3LtGuTwO1GdAQfnH hE5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WXmsudQE/TvO9iiY9zNu+1IylJ/3Toy3swSwCKBPOo8=; b=rhRQyGGk+y3lve8XFVClXBxIieN0V7RTqNWjvx2b1WyIMonZr7L+KmgjiLye474uU8 l/Eo3MIU9vRcrB1ao+N44/i1WeGhHLO7yOFBgSi6+4LJKUxMZXSDfAgyUUu+y7aH71B3 0bHLCdzepjNF2wwhAMohGDnw2yWvz5vQGxpHC0pdQz0chNWo6hgHDkNeUEo+JQ3RMfp/ LVx+Fj9ReURx2VD+3ebzY/qQemLDOyQU0xcebVZ8fsESa0vPuZsHxrtbAw/L4mqM+T0w W78gwF0LCFUWWA9TTuxYtPOKCymqqzA33gV+vQcgk7AQHUprnRoFPoNv6LTPE5Z7oyPM an/w== X-Gm-Message-State: AOAM533S9MSdnNsqNwuVHYZrGSO3OfBdnerxvqw6phIQhM7vM80pIIal gJ0CujbvXyt36NLELJtywqxbRtSD+X+zX7qLw4+YUQ== X-Google-Smtp-Source: ABdhPJyHa7eOvNnyaHxUf07xuixSXY4plTAI+F72p+vYBKR20PiTxHWvuY2S3ZZhmuCa01nJPpnMNsM9vx/1eBu5XnY= X-Received: by 2002:a25:ccd2:0:b0:633:786a:b105 with SMTP id l201-20020a25ccd2000000b00633786ab105mr87355ybf.28.1648044031330; Wed, 23 Mar 2022 07:00:31 -0700 (PDT) MIME-Version: 1.0 References: <20220323062552.228429-1-Arunpravin.PaneerSelvam@amd.com> <7addb3e7-d265-c1a7-d449-7d0056f06d63@molgen.mpg.de> <6f0888a2-f74d-f41f-d593-a8362e7dc673@molgen.mpg.de> <398f8851-d37b-4020-24ce-8f2ab9723e40@amd.com> In-Reply-To: <398f8851-d37b-4020-24ce-8f2ab9723e40@amd.com> From: Daniel Stone Date: Wed, 23 Mar 2022 14:00:20 +0000 Message-ID: Subject: Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu) To: =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Menzel , Arunpravin Paneer Selvam , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com, matthew.auld@intel.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 23 Mar 2022 at 08:19, Christian K=C3=B6nig wrote: > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > Sorry, I disagree. The motivation needs to be part of the commit > > message. For example see recent discussion on the LWN article > > *Donenfeld: Random number generator enhancements for Linux 5.17 and > > 5.18* [1]. > > > > How much the commit message should be extended, I do not know, but the > > current state is insufficient (too terse). > > Well the key point is it's not about you to judge that. > > If you want to complain about the commit message then come to me with > that and don't request information which isn't supposed to be publicly > available. > > So to make it clear: The information is intentionally hold back and not > made public. In that case, the code isn't suitable to be merged into upstream trees; it can be resubmitted when it can be explained. Cheers, Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24751C433F5 for ; Wed, 23 Mar 2022 14:00:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8613510E6E4; Wed, 23 Mar 2022 14:00:33 +0000 (UTC) Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F4C910E6E4 for ; Wed, 23 Mar 2022 14:00:32 +0000 (UTC) Received: by mail-yb1-xb2b.google.com with SMTP id u103so2822322ybi.9 for ; Wed, 23 Mar 2022 07:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WXmsudQE/TvO9iiY9zNu+1IylJ/3Toy3swSwCKBPOo8=; b=pLPt4Nny0j0BQLv4HIqLC3M+OAARYiL7j99SY2OpCpU5uMTMP73/MrCrJe1qGuG6z3 LbV9s/x/7bxnISY8mUpG0XzF0ugw7k3K5bL0znrMDaptTcAwr3wXVL/rAU3TUvGERTD0 eyT4equSyxkz8pweRVpOnMFupFINS4YY5vYVvclUw7yLdVECrnJSCQmBZf4YZ5ueD/wB Xfl5u508JiydNzfJJdCPoUIPVOX3K3/9Wrg5Cir5Q8sIc89cdmO1mP0CYlkCldvzXm7M dP3/kJWAlV9wrMuz86UIBwBIBlyFGomcM0amaSo6CvWxcGg7aUeB3LtGuTwO1GdAQfnH hE5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WXmsudQE/TvO9iiY9zNu+1IylJ/3Toy3swSwCKBPOo8=; b=hiTthYmQzG4fT8aiUlmQPsW7jz7IDd6a6IbLHdxElaSV6/wnhiHcezTbxKSYJ8HDtZ /piA/jN7W7+5RMKaBim6W9UO1TcBcC8SRoCVf5eb3Voeofx+xTZPMPbP8KLxU/B+9d/g MxkyAeEsUmKCmgUMjxY461CRpvNxtosZE6FZUvcvcvLqcgVDFJaVRu9L7u7kt7+NSRyk uJmN7rUoLmXjExhCU97jglZ5yg+DOdFz3ZGO9ykAhiMV9LimnemUdDQIPHKdh+zO8lMf PA+0tQ1m7/TnDBMdxEQFPntR29/7nX19xnRugWnT/m1jTlsQX0jmGBSo2SmgywT9m7Z4 c0RQ== X-Gm-Message-State: AOAM531t6xrLDNjTKwMqUUVDSlQIDVs+iLM+qapcYuqlzBkD/xP5Rngg LLhfPxkcklO/lYfmdqVC4Sky3i6i5UqSwNACnNSFnQ== X-Google-Smtp-Source: ABdhPJyHa7eOvNnyaHxUf07xuixSXY4plTAI+F72p+vYBKR20PiTxHWvuY2S3ZZhmuCa01nJPpnMNsM9vx/1eBu5XnY= X-Received: by 2002:a25:ccd2:0:b0:633:786a:b105 with SMTP id l201-20020a25ccd2000000b00633786ab105mr87355ybf.28.1648044031330; Wed, 23 Mar 2022 07:00:31 -0700 (PDT) MIME-Version: 1.0 References: <20220323062552.228429-1-Arunpravin.PaneerSelvam@amd.com> <7addb3e7-d265-c1a7-d449-7d0056f06d63@molgen.mpg.de> <6f0888a2-f74d-f41f-d593-a8362e7dc673@molgen.mpg.de> <398f8851-d37b-4020-24ce-8f2ab9723e40@amd.com> In-Reply-To: <398f8851-d37b-4020-24ce-8f2ab9723e40@amd.com> From: Daniel Stone Date: Wed, 23 Mar 2022 14:00:20 +0000 Message-ID: To: =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu) X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Menzel , Arunpravin Paneer Selvam , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com, matthew.auld@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 23 Mar 2022 at 08:19, Christian K=C3=B6nig wrote: > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > Sorry, I disagree. The motivation needs to be part of the commit > > message. For example see recent discussion on the LWN article > > *Donenfeld: Random number generator enhancements for Linux 5.17 and > > 5.18* [1]. > > > > How much the commit message should be extended, I do not know, but the > > current state is insufficient (too terse). > > Well the key point is it's not about you to judge that. > > If you want to complain about the commit message then come to me with > that and don't request information which isn't supposed to be publicly > available. > > So to make it clear: The information is intentionally hold back and not > made public. In that case, the code isn't suitable to be merged into upstream trees; it can be resubmitted when it can be explained. Cheers, Daniel