From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Stone Subject: Re: [PATCH 06/31] drm/i915: Fix IPS disable sequence. Date: Thu, 12 Nov 2015 11:24:28 +0000 Message-ID: References: <1446749423-4789-1-git-send-email-rodrigo.vivi@intel.com> <1446749423-4789-7-git-send-email-rodrigo.vivi@intel.com> <1447284734.1865.11.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 668736E164 for ; Thu, 12 Nov 2015 03:24:30 -0800 (PST) Received: by wmww144 with SMTP id w144so196067141wmw.1 for ; Thu, 12 Nov 2015 03:24:28 -0800 (PST) In-Reply-To: <1447284734.1865.11.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org SGksCgpPbiAxMSBOb3ZlbWJlciAyMDE1IGF0IDIzOjMxLCBWaXZpLCBSb2RyaWdvIDxyb2RyaWdv LnZpdmlAaW50ZWwuY29tPiB3cm90ZToKPiBPbiBUdWUsIDIwMTUtMTEtMTAgYXQgMTY6MzQgKzAw MDAsIERhbmllbCBTdG9uZSB3cm90ZToKPj4gT24gNSBOb3ZlbWJlciAyMDE1IGF0IDE4OjQ5LCBS b2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4+IHdyb3RlOgo+PiA+ICt2b2lk IGludGVsX2lwc19kaXNhYmxlX2lmX2Fsb25lKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+PiA+ ICt7Cj4+ID4gKyAgICAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+YmFzZS5kZXY7 Cj4+ID4gKyAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRl dl9wcml2YXRlOwo+PiA+ICsgICAgICAgYm9vbCBpcHNfZW5hYmxlZDsKPj4gPiArICAgICAgIHN0 cnVjdCBpbnRlbF9wbGFuZSAqaW50ZWxfcGxhbmU7Cj4+ID4gKwo+PiA+ICsgICAgICAgbXV0ZXhf bG9jaygmZGV2X3ByaXYtPmRpc3BsYXlfaXBzLmxvY2spOwo+PiA+ICsgICAgICAgaXBzX2VuYWJs ZWQgPSBkZXZfcHJpdi0+ZGlzcGxheV9pcHMuZW5hYmxlZDsKPj4gPiArICAgICAgIG11dGV4X3Vu bG9jaygmZGV2X3ByaXYtPmRpc3BsYXlfaXBzLmxvY2spOwo+PiA+ICsKPj4gPiArICAgICAgIGlm ICghaXBzX2VuYWJsZWQpCj4+ID4gKyAgICAgICAgICAgICAgIHJldHVybjsKPj4gPiArCj4+ID4g KyAgICAgICBmb3JfZWFjaF9pbnRlbF9wbGFuZV9vbl9jcnRjKGRldiwgY3J0YywgaW50ZWxfcGxh bmUpIHsKPj4gPiArICAgICAgICAgICAgICAgZW51bSBwbGFuZSBwbGFuZSA9IGludGVsX3BsYW5l LT5wbGFuZTsKPj4gPiArCj4+ID4gKyAgICAgICAgICAgICAgIGlmIChwbGFuZSAhPSBQTEFORV9B ICYmCj4+ID4gKyAgICAgICAgICAgICAgICAgICAhIShJOTE1X1JFQUQoRFNQQ05UUihwbGFuZSkp ICYKPj4gPiBESVNQTEFZX1BMQU5FX0VOQUJMRSkpCj4+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgcmV0dXJuOwo+PiA+ICsgICAgICAgICAgICAgICBpbnRlbF9pcHNfZGlzYWJsZShjcnRjKTsK Pj4gPiArICAgICAgIH0KPj4gPiArfQo+Pgo+PiBSYXRoZXIgdGhhbiByZWFkaW5nIHRoZSByZWdp c3RlcnMsIHRoaXMgc2hvdWxkIGp1c3QgaW5zcGVjdAo+PiBwbGFuZV9zdGF0ZS0+dmlzaWJsZS4g UmVhZGluZyB0aGUgcmVnaXN0ZXJzIGludHJvZHVjZXMgdGhlIHNhbWUgYnVnCj4+IGFzCj4+IEkg bWVudGlvbmVkIHRoZSBsYXN0IG1haWwsIGJ1dCBpbiBhIGRpZmZlcmVudCB3YXk6Cj4+ICAgLSBJ UFMgaXMgZW5hYmxlZAo+PiAgIC0gcHJpbWFyeSBhbmQgb3ZlcmxheSBwbGFuZXMgYXJlIGJvdGgg ZW5hYmxlZAo+PiAgIC0gdXNlciBjb21taXRzIGFuIGF0b21pYyBzdGF0ZSB3aGljaCBkaXNhYmxl cyBib3RoIHByaW1hcnkgYW5kCj4+IG92ZXJsYXkgcGxhbmVzLCBzbyBJUFMgbXVzdCBiZSBkaXNh YmxlZAo+PiAgIC0gZGlzYWJsaW5nIHRoZSBwcmltYXJ5IHBsYW5lIGNhbGxzIHRoaXMgZnVuY3Rp b24sIHdoaWNoIHNlZXMgdGhhdAo+PiB0aGUgb3ZlcmxheSBwbGFuZSBpcyBzdGlsbCBhY3RpdmUs IHNvIElQUyBjYW4gcmVtYWluIGVuYWJsZWQKPj4gICAtIHRoZSBvdmVybGF5IHBsYW5lIGdldHMg ZGlzYWJsZWQsIHdpdGggSVBTIHN0aWxsIGFjdGl2ZQo+PiAgIC0gOigKPgo+IFlvdSBhcmUgYWJz b2x1dGVseSByaWdodCBvbiB0aGlzIGNhc2UuLi4gOi8gVGhhbmtzIGZvciBzcG90dGluZyB0aGlz Cj4gY2FzZS4KPgo+IFNvIEkgd2FzIGNvbnNpZGVyaW5nIHlvdXIgaWRlYSBmb3IgdGhlIHVuaWZp ZWQgcGxhY2UgYnV0IEkgZW5kZWQgdXAgaW4KPiBzb21lIGNvbmNlcm5zIHF1ZXN0aW9ucyBoZXJl Lgo+Cj4gRmlyc3QgaXMgdGhlIGRpc2FibGUgbXVzdCBvY2N1ciBvbiBwcmUtdXBkYXRlIGFuZCBl bmFibGUgb24gcG9zdAo+IC11cGRhdGUsIHNvIEkgd291bGQgcHJlZmVyIHRvIHN0aWxsIGxldCB0 aGVtIHNwcmVhZCBhbmQgcmVhY3RpdmUuCgpSaWdodCwgdGhleSBoYXZlIHRvIGJlIHNlcGFyYXRl IC0gd2hpY2ggYXBwbGllcyBkb3VibHkgZm9yIGFzeW5jCm1vZGVzZXRzIGFzIHdlbGwuCgo+IEJ1 dCBub3cgSSBiZWxpZXZlIHRoYXQgd2UgbmVlZCB0byBkZXRhY2ggdGhlIGF0b21pYwo+IC0+aXBz X3tlbmFibGUsZGlzYWJsZX0gZnJvbSBwcmltYXJ5IGFuZCBkbyBmb3IgZXZlcnkgcGxhbmUgb24v b2ZmLiBTbwo+IGlmIHdlIGFyZSBlbmFibGluZyBhbnkgcGxhbmUgd2UganVzdCBjYWxsIGlwc19l bmFibGUoKS4KPiBBbmQgaWYgcGxhbmUgaXMgYmVpbmcgZGlzYWJsZWQgYW5kIHRoZXJlIGlzIG5v IG90aGVyIHBsYW5lLT52aXNpYmxlIGluCj4gdGhpcyBjcnRjIHdlIGNhbGwgaW50ZWxfZGlzYWJs ZSgpLgo+Cj4gQnV0IEkgd29uZGVyIGhvdyB0byBza2lwIHRoZSBwbGFuZSBpdHNlbGYgb24gZm9y X2VhY2hfcGxhbmVfaW5fc3RhdGUuLi4KPiBPciBzaG91bGQgSSBqdXN0IGNvdW50ZXIgdGhlIG51 bWJlciBvZiBzdGF0ZS0+dmlzaWJsZSBhbmQgZGlzYWJsZSBpZiA8PQo+IDEgYW5kIGxldCBlbmFi bGUgaWYgd2UgY291bnQgbW9yZSB0aGFuIDEgdmlzaWJsZSBwbGFuZS4gQW55IGJldHRlcgo+IGlk ZWE/CgpZZWFoLCBleGFjdGx5IHRoYXQsIGJ1dCBldmVuIGVhc2llcjogYm9vbCBpcHNfdGFyZ2V0 X3N0YXRlID0KISFjcnRjX3N0YXRlLT5wbGFuZV9tYXNrOwoKU28gbXkgaWRlYSB3b3VsZCBiZSB0 aGF0LCBpbiBwcmVwYXJlX2NvbW1pdCwgeW91IGNhbGN1bGF0ZSB0aGUgdGFyZ2V0CnN0YXRlIGJh c2VkIG9uIHRoZSB1cGRhdGVkIHBsYW5lX21hc2suIFdoZW4gYWN0dWFsbHkgY29tbWl0dGluZyB0 aGUKc3RhdGUsIGNhbGwgaW50ZWxfaXBzX2Rpc2FibGUoKSBpbiBpbnRlbF9wcmVfcGxhbmVfdXBk YXRlIChpZgohaXBzX3RhcmdldF9zdGF0ZSAmJiBpbnRlbF9jcnRjLT5pcHNfZW5hYmxlZCksIGFu ZCBpbnRlbF9pcHNfZW5hYmxlKCkKYWZ0ZXIgdGhlIGNvbW1pdCBoYXMgZmluaXNoZWQgKGlmIGlw c190YXJnZXRfc3RhdGUgJiYKIWludGVsX2NydGMtPmlwc19lbmFibGVkKS4gVGhhdCBzcGxpdCB3 b3VsZCBiZSBhIHJlYWxseSBnb29kIGZpdCBmb3IKYXN5bmMvYXRvbWljLCB3aGVyZSB3ZSBuZWVk IHRvIGNhbGN1bGF0ZSB0aGUgdGFyZ2V0IHN0YXRlIGluIGFkdmFuY2UsCmFuZCBvbmx5IGFwcGx5 IGl0IHNvbWUgdGltZSBsYXRlci4gU2FtZSBnb2VzIGZvciBQU1IuCgpCYXNpY2FsbHksIGFueSB3 b3JrIHdlIG5lZWQgdG8gZG8gZm9yIG1vZGVzZXQgbmVlZHMgdG8gYmUgcXVpdGUKc3RhdGljYWxs eSBjYWxjdWxhdGVkIGluIHRoZSBwcmVwYXJlIHN0YWdlLCBzbyB3ZSBjYW4gYXBwbHkgaXQgZnJv bQp0aGUgY29tbWl0IHN0YWdlLCB3aXRob3V0IG5lZWRpbmcgdG8gcHVsbCBhbnkgZnVydGhlciBz dGF0ZSBwb2ludGVycwood2UgY2FuJ3QgZG8gdGhpcyB3aXRoIGFzeW5jKSwgYW5kIGNlcnRhaW5s eSB3aXRob3V0IHJlZmVyZW5jZSB0byB0aGUKYWN0dWFsIGhhcmR3YXJlIGNvbmZpZ3VyYXRpb24g KGUuZy4gaW5zcGVjdGluZyByZWdpc3RlcnMpLgoKQ2hlZXJzLApEYW5pZWwKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK