From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479FAC433F5 for ; Mon, 7 Mar 2022 13:09:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238608AbiCGNKk (ORCPT ); Mon, 7 Mar 2022 08:10:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235991AbiCGNKk (ORCPT ); Mon, 7 Mar 2022 08:10:40 -0500 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE6635BD2F for ; Mon, 7 Mar 2022 05:09:45 -0800 (PST) Received: by mail-yb1-xb33.google.com with SMTP id g26so30748127ybj.10 for ; Mon, 07 Mar 2022 05:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yepItlJ9qbYQk7lxa3ZiJXu15xaq36AuyzFPOK3vAVY=; b=AeUDdq/AWNd2nmTFTAWaAJ2SF2Vbyvv/+rKo46RmbS5jRVcFwjQ6vFH+O7bo/bjKe5 pC6cp64tslJfdYfAUTd11w9i4XiJTUMRq97HJvLdXTY+EPvG9SEdthY6UZ2xKsBUEMBB gyDKihc4SgMxyZHwQVVs8qsMRewQwhiE6ZvjNB1ekCxcMCzJ2BIcUIdNfzfeE+lb7kFJ 7ZUE5uusKonMkMdus5SXpoMl2koYoSUEDiw3fbc1rXKNqqovWetKdQgEd5N7dPiGaYCd MF9d+0HNsWyxtEfnEk7KS522ZgZ7dXgWSneMYVdPVApAweOFpWo6iEr4DXEsLnVTZrg7 R7qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yepItlJ9qbYQk7lxa3ZiJXu15xaq36AuyzFPOK3vAVY=; b=8BcFz0O3HqQGq9QETb3aqaZs5YACCdteTch1H/J+mnPUtboCW7L/Q+xWo38FPMPYbH L6HhrhV70XM+wm5Vo5cEfxNIq7kBykMyA9pPN+Yo3pCVhkaMQhuaao8slYydaDWY4Dg7 qE+KissiIWzqxFUlodfnvm0MZsJbJfQAqoLOkmPSiVN7TSTvvZkZTG/GbPHfg3rxaYts nE5OZZeZozFjvEnJHhaHqtifP80QyvGF4FxPmivQgO8Hf+z6kgIXLCHOPMW19oiwUX/U 88Y739pEeZGqqFgGTpqS8ODosVVJsrTf3jgrrgEZAZoMSn2fYPLLtiMydUaGLhdsoDe/ aVQg== X-Gm-Message-State: AOAM533KxRUqwyHvb3R/vPRDzTnrHiIu1ALIGl2/vuyEG/MIK3Re0KlY i3Z/lTzEPu9qVdAa++W+5+udaKZEQvyK8w9lr3dCPA== X-Google-Smtp-Source: ABdhPJy19ZfRbc1jCqoWnTYWtbGO16Ywu+DUbMK4m78jIaXZssJbqdhjy3kb9cJjfLA+Obyy/2vWB4gu/RRxGIBBSts= X-Received: by 2002:a25:2bc5:0:b0:628:71cf:99c with SMTP id r188-20020a252bc5000000b0062871cf099cmr7771635ybr.553.1646658584984; Mon, 07 Mar 2022 05:09:44 -0800 (PST) MIME-Version: 1.0 References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-23-s.hauer@pengutronix.de> In-Reply-To: From: Daniel Stone Date: Mon, 7 Mar 2022 13:09:33 +0000 Message-ID: Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver To: Andy Yan Cc: Sascha Hauer , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Andy, On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote: > On 2/25/22 15:51, Sascha Hauer wrote: > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This driver has been derived from the downstream Rockchip Kernel and > > heavily modified: > > > > - All nonstandard DRM properties have been removed > > - dropped struct vop2_plane_state and pass around less data between > > functions > > - Dropped all DRM_FORMAT_* not known on upstream > > - rework register access to get rid of excessively used macros > > - Drop all waiting for framesyncs > > > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with weston-simple-dmabuf-egl on > > weston using the (yet to be upstreamed) panfrost driver support. > > When run a weston 10.0.0: > > # export XDG_RUNTIME_DIR=/tmp > # weston --backend=drm-backend.so --use-pixma --tty=2 > --continue=without-input > > I got the following error: > > drm_atomic_check_only [PLANE:31:Smart0-win0] CRTC set but no FB Can you please start Weston with --logger-scopes=log,drm-backend and attach the output? Cheers, Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA222C433F5 for ; Mon, 7 Mar 2022 13:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bV0txB0acoaBFNfcqa15GC9U07mgJ70KuuCKLJCAGQg=; b=fNdLpFaTC6WGBC 6yutFbe2jDVojpa23z2YEZU9DTSSJVDzETlHHbFTShAjwgtyudI/AQ/4POhG9IM2uFII6qf+qCfHY O5g/SSGXD+4sE2jlQIOI5DkzJcoHb5Z3M5dwn5ocjYQz04mdF7CAUNEkvmdTX1wRnXs2a9SdC1s1x S3ZnEC7f26bs0bSxBC55q9bn64bMxywZLVpC3LtEe1xi3VN0MMyeJvcDosjC14EkYZNXvxqdKfoR3 bl09JdFig3S2VDoXG/4At9WvNIN0rNsjej5jMYnx2XgwHKMzSUy2rqyA17pobXWrf2ZreZrBAXezw YZR6o8tyk4KK7rxTXD8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRD7l-000E66-3U; Mon, 07 Mar 2022 13:10:05 +0000 Received: from mail-yb1-xb2c.google.com ([2607:f8b0:4864:20::b2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRD7T-000Dzk-0p for linux-rockchip@lists.infradead.org; Mon, 07 Mar 2022 13:09:48 +0000 Received: by mail-yb1-xb2c.google.com with SMTP id b35so30735156ybi.13 for ; Mon, 07 Mar 2022 05:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yepItlJ9qbYQk7lxa3ZiJXu15xaq36AuyzFPOK3vAVY=; b=AeUDdq/AWNd2nmTFTAWaAJ2SF2Vbyvv/+rKo46RmbS5jRVcFwjQ6vFH+O7bo/bjKe5 pC6cp64tslJfdYfAUTd11w9i4XiJTUMRq97HJvLdXTY+EPvG9SEdthY6UZ2xKsBUEMBB gyDKihc4SgMxyZHwQVVs8qsMRewQwhiE6ZvjNB1ekCxcMCzJ2BIcUIdNfzfeE+lb7kFJ 7ZUE5uusKonMkMdus5SXpoMl2koYoSUEDiw3fbc1rXKNqqovWetKdQgEd5N7dPiGaYCd MF9d+0HNsWyxtEfnEk7KS522ZgZ7dXgWSneMYVdPVApAweOFpWo6iEr4DXEsLnVTZrg7 R7qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yepItlJ9qbYQk7lxa3ZiJXu15xaq36AuyzFPOK3vAVY=; b=p61qZXfkoW1xLk5/d69TK8TbT/8Lp7ABt/bjRBgcvDWaLM0/GeuuGC6AjutG7v2edc mRUbXTPzfS/jbjR8s9jS7SfO04fCGoun2PNkV1kUv7J6jQTxBx5MU9Bep++0sH2odILn bvqvliy4C7Ltg3S2oQWAwQwN9unlwAyFrUFg/VXk1qgx2eezQpU39utYleRefQmYxUBQ ib41Qe2KV/D1+fqbeJ7qjAERwqOtwRyoVQ7c0VOqr+s5HVhUqtLjRAigJGL+03kW6KK+ OY7L5vDjRHTTThp7dVmFaua7NaEGXwP3CMYPLwyly6v3PbXnIBnQ27nDDQIYkz31PqFo 4eZw== X-Gm-Message-State: AOAM533m25QYAeYYIc4NbzpW+MUFRFCZla9FGkpoU9xZEEqcq19N6w/q OROnxiijlVL0vw3zLwoZ+SoHTv1S1kSi5S09tieCtg== X-Google-Smtp-Source: ABdhPJy19ZfRbc1jCqoWnTYWtbGO16Ywu+DUbMK4m78jIaXZssJbqdhjy3kb9cJjfLA+Obyy/2vWB4gu/RRxGIBBSts= X-Received: by 2002:a25:2bc5:0:b0:628:71cf:99c with SMTP id r188-20020a252bc5000000b0062871cf099cmr7771635ybr.553.1646658584984; Mon, 07 Mar 2022 05:09:44 -0800 (PST) MIME-Version: 1.0 References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-23-s.hauer@pengutronix.de> In-Reply-To: From: Daniel Stone Date: Mon, 7 Mar 2022 13:09:33 +0000 Message-ID: Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver To: Andy Yan Cc: Sascha Hauer , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_050947_094467_4EE9163C X-CRM114-Status: GOOD ( 17.78 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Andy, On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote: > On 2/25/22 15:51, Sascha Hauer wrote: > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This driver has been derived from the downstream Rockchip Kernel and > > heavily modified: > > > > - All nonstandard DRM properties have been removed > > - dropped struct vop2_plane_state and pass around less data between > > functions > > - Dropped all DRM_FORMAT_* not known on upstream > > - rework register access to get rid of excessively used macros > > - Drop all waiting for framesyncs > > > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with weston-simple-dmabuf-egl on > > weston using the (yet to be upstreamed) panfrost driver support. > > When run a weston 10.0.0: > > # export XDG_RUNTIME_DIR=/tmp > # weston --backend=drm-backend.so --use-pixma --tty=2 > --continue=without-input > > I got the following error: > > drm_atomic_check_only [PLANE:31:Smart0-win0] CRTC set but no FB Can you please start Weston with --logger-scopes=log,drm-backend and attach the output? Cheers, Daniel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87524C433EF for ; Mon, 7 Mar 2022 13:09:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 76D6110F859; Mon, 7 Mar 2022 13:09:46 +0000 (UTC) Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB15410F859 for ; Mon, 7 Mar 2022 13:09:45 +0000 (UTC) Received: by mail-yb1-xb2d.google.com with SMTP id l2so11299334ybe.8 for ; Mon, 07 Mar 2022 05:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yepItlJ9qbYQk7lxa3ZiJXu15xaq36AuyzFPOK3vAVY=; b=AeUDdq/AWNd2nmTFTAWaAJ2SF2Vbyvv/+rKo46RmbS5jRVcFwjQ6vFH+O7bo/bjKe5 pC6cp64tslJfdYfAUTd11w9i4XiJTUMRq97HJvLdXTY+EPvG9SEdthY6UZ2xKsBUEMBB gyDKihc4SgMxyZHwQVVs8qsMRewQwhiE6ZvjNB1ekCxcMCzJ2BIcUIdNfzfeE+lb7kFJ 7ZUE5uusKonMkMdus5SXpoMl2koYoSUEDiw3fbc1rXKNqqovWetKdQgEd5N7dPiGaYCd MF9d+0HNsWyxtEfnEk7KS522ZgZ7dXgWSneMYVdPVApAweOFpWo6iEr4DXEsLnVTZrg7 R7qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yepItlJ9qbYQk7lxa3ZiJXu15xaq36AuyzFPOK3vAVY=; b=bx4bn/Q/NJMcWJIlXVwVdeRYONczcwbrVmUz+aBRz1TZdIO/fT8qUVeWF0ZeQqUsTW Ye22k8VSdqfJl9bth3Zq1aRoax0a+C2XKiuA73MDutq+DZb7R0azWfFyiiZ3Y+xNR5ez tDP5RCNpRtcQJbpD3Gf9o6e0wzY/vwCD01cLqpED7YWI7X+xQhwdKblJHAC2G6Jzz92X OSpz+uzsW9di2DxndFjc6RFFlS0fe4A5HiK/l8zAkq+rZk9s0bBaPUylN/sYTZQIIl2H DEtXGAaYzIwyoIspXn5pWYXDaYTSZP+zWrtfouseK7FCrdBhrMfjfCwacAEpIQtFN7Wj 6PAA== X-Gm-Message-State: AOAM530aag6oME+6KySiDoDWmYx48eQIo6VZj15+l/YKWU4pHz7ZFAS+ g9xQXcRqiaUnUgpYpYe/01ozXbDWcwWWZybtQ5w4yg== X-Google-Smtp-Source: ABdhPJy19ZfRbc1jCqoWnTYWtbGO16Ywu+DUbMK4m78jIaXZssJbqdhjy3kb9cJjfLA+Obyy/2vWB4gu/RRxGIBBSts= X-Received: by 2002:a25:2bc5:0:b0:628:71cf:99c with SMTP id r188-20020a252bc5000000b0062871cf099cmr7771635ybr.553.1646658584984; Mon, 07 Mar 2022 05:09:44 -0800 (PST) MIME-Version: 1.0 References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-23-s.hauer@pengutronix.de> In-Reply-To: From: Daniel Stone Date: Mon, 7 Mar 2022 13:09:33 +0000 Message-ID: Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver To: Andy Yan Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sascha Hauer , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Andy, On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote: > On 2/25/22 15:51, Sascha Hauer wrote: > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This driver has been derived from the downstream Rockchip Kernel and > > heavily modified: > > > > - All nonstandard DRM properties have been removed > > - dropped struct vop2_plane_state and pass around less data between > > functions > > - Dropped all DRM_FORMAT_* not known on upstream > > - rework register access to get rid of excessively used macros > > - Drop all waiting for framesyncs > > > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with weston-simple-dmabuf-egl on > > weston using the (yet to be upstreamed) panfrost driver support. > > When run a weston 10.0.0: > > # export XDG_RUNTIME_DIR=/tmp > # weston --backend=drm-backend.so --use-pixma --tty=2 > --continue=without-input > > I got the following error: > > drm_atomic_check_only [PLANE:31:Smart0-win0] CRTC set but no FB Can you please start Weston with --logger-scopes=log,drm-backend and attach the output? Cheers, Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 866D9C433F5 for ; Mon, 7 Mar 2022 13:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yf+l3Q7foGdxBXn3mx4ZkZ64iLt6DTSDJ2VYqQBVM/o=; b=DWitA0DA9LyMJF HRHt+RFZ0aVdrJjzJIOlTunmrE6ndTDd0G6zGAQk/h7XKhvFXdbNtJIpe0whIPKKmwrpc9vLTK2R5 /nZH98vGDqWsYiiFMaV+OoFVv9BoA1q82p5w9jhwAJLGEXew5quIU05lzk29R+KXOgux1DHu8RTLK xkQ4avtTIhp/RD0BdmYSbDf2to6clWvhuD/qYe+xeoxonQub2q/32ixQvK8FiX+mb2aVajKswCmhj Rnvnj+8qYyp7K/O1we5lO/OhuXYFy3lL0wfyCIRobLjHSLeQFi/HBAoU89vvB9Q0N3Vc34X4TalQd hTClquwtggQqyQGQYaaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRD7X-000E2O-V1; Mon, 07 Mar 2022 13:09:52 +0000 Received: from mail-yb1-xb34.google.com ([2607:f8b0:4864:20::b34]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRD7S-000Dzl-I2 for linux-arm-kernel@lists.infradead.org; Mon, 07 Mar 2022 13:09:48 +0000 Received: by mail-yb1-xb34.google.com with SMTP id f38so30829630ybi.3 for ; Mon, 07 Mar 2022 05:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yepItlJ9qbYQk7lxa3ZiJXu15xaq36AuyzFPOK3vAVY=; b=AeUDdq/AWNd2nmTFTAWaAJ2SF2Vbyvv/+rKo46RmbS5jRVcFwjQ6vFH+O7bo/bjKe5 pC6cp64tslJfdYfAUTd11w9i4XiJTUMRq97HJvLdXTY+EPvG9SEdthY6UZ2xKsBUEMBB gyDKihc4SgMxyZHwQVVs8qsMRewQwhiE6ZvjNB1ekCxcMCzJ2BIcUIdNfzfeE+lb7kFJ 7ZUE5uusKonMkMdus5SXpoMl2koYoSUEDiw3fbc1rXKNqqovWetKdQgEd5N7dPiGaYCd MF9d+0HNsWyxtEfnEk7KS522ZgZ7dXgWSneMYVdPVApAweOFpWo6iEr4DXEsLnVTZrg7 R7qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yepItlJ9qbYQk7lxa3ZiJXu15xaq36AuyzFPOK3vAVY=; b=16qAh2rR9iXpKE/VjvJ0HlihFi78oc7KWHp6oCmesLAkIuC0b71JrSF9Mcr515crOZ nIoxoc3HpzavuNxKSafgdjQMyTT+uTrhGlWl0IpbMmFsAv3cWUdkbYvfhjzYB8I3JliZ AirQ9aqggJgurRmZbYqjsQUZX/zeNxyopZJxKrROpxUbaxLAQ3rBk4sYu0DoDKjMo6l8 ovLeqTZL4EisnKcPqT4or+FhzPEpT15+TE1YaW+jb0/wIB/8Yo4xzK7+yGB5KqaAJmBI sxBzhl/TZ6TZ2A2bs7hYXi+pnx5pow9lwWeQb1JUyuW8f3Ihq/dhuZnirbQFVS/xQ8E2 7hHQ== X-Gm-Message-State: AOAM532U5qZ1H9aST95SfVlrz2S2sXoQabpZzjXOej8EXXbwJT1/8AT5 f6QbhDPiT8yCrtkhutvfPfkl4N486xtBkE8txH8JxQ== X-Google-Smtp-Source: ABdhPJy19ZfRbc1jCqoWnTYWtbGO16Ywu+DUbMK4m78jIaXZssJbqdhjy3kb9cJjfLA+Obyy/2vWB4gu/RRxGIBBSts= X-Received: by 2002:a25:2bc5:0:b0:628:71cf:99c with SMTP id r188-20020a252bc5000000b0062871cf099cmr7771635ybr.553.1646658584984; Mon, 07 Mar 2022 05:09:44 -0800 (PST) MIME-Version: 1.0 References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-23-s.hauer@pengutronix.de> In-Reply-To: From: Daniel Stone Date: Mon, 7 Mar 2022 13:09:33 +0000 Message-ID: Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver To: Andy Yan Cc: Sascha Hauer , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_050946_660845_C3EEF15C X-CRM114-Status: GOOD ( 19.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote: > On 2/25/22 15:51, Sascha Hauer wrote: > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This driver has been derived from the downstream Rockchip Kernel and > > heavily modified: > > > > - All nonstandard DRM properties have been removed > > - dropped struct vop2_plane_state and pass around less data between > > functions > > - Dropped all DRM_FORMAT_* not known on upstream > > - rework register access to get rid of excessively used macros > > - Drop all waiting for framesyncs > > > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with weston-simple-dmabuf-egl on > > weston using the (yet to be upstreamed) panfrost driver support. > > When run a weston 10.0.0: > > # export XDG_RUNTIME_DIR=/tmp > # weston --backend=drm-backend.so --use-pixma --tty=2 > --continue=without-input > > I got the following error: > > drm_atomic_check_only [PLANE:31:Smart0-win0] CRTC set but no FB Can you please start Weston with --logger-scopes=log,drm-backend and attach the output? Cheers, Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel