From: Daniel Stone <daniel@fooishbar.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "Ander Conselvan de Oliveira"
<ander.conselvan.de.oliveira@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
"Stéphane Marchesin" <marcheu@google.com>
Subject: Re: intel_dp_detect redesign
Date: Fri, 27 Nov 2015 16:30:21 +0000 [thread overview]
Message-ID: <CAPj87rOAcTnw4kF-SMeHcvg5t87EHmjNWjRjh9ZZwe8SRxVoHA@mail.gmail.com> (raw)
In-Reply-To: <20151126100720.GH17050@phenom.ffwll.local>
Hi,
+marcheu
On 26 November 2015 at 10:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Nov 25, 2015 at 05:09:02PM +0530, Thulasimani, Sivakumar wrote:
>> however good to explicitly check for this,
>> following needs to be tested before sending in next patch/merge
>> 1) MST displays verification (Ander's reported on first set of patches)
>> 2) check behavior on sleep - resume (dave&danvet)
>> 3) storm handling needs to be handled as well. (i assume this should be
>> fine,
>> but good to check explicitly) (danvet)
>>
>
> Yeah the storm mitigation will keep on working. What I'm worried about is
> that polling won't work any more: When a storm happens we disable the hpd
> and switch all affected connectors completely to polling. Polling happens
> through the probe helpers in drm_probe_helper.c, and that code exclusively
> uses ->detect callbacks. Which means if we no longer re-probe in detect
> (since we assume hpd works correctly) then this will break the storm
> handling code.
>
> Simplest fix (but a bit a hack) would be to check whether polling is
> enabled at the top of intel_hdmi_detect and if so execute a full probe.
> And not just return the cached values.
>
> Note that storms are only a concern for HDMI, not DP (somehow DP hw is
> less shit).
Hmm, from what I understand it's a concern on DP as well. Maybe due to
DP->HDMI converters which just pass HPD through? Google's Type-C -> DP
cable crushes all short HPD events - breaking MST short pulses - which
I assume wasn't for no reason:
https://chromium.googlesource.com/chromiumos/platform/ec/+/master/board/dingdong/board.c#27
Cheers,
Daniel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-11-27 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 19:13 intel_dp_detect redesign Daniel Vetter
2015-11-25 10:04 ` Daniel Vetter
2015-11-25 11:39 ` Thulasimani, Sivakumar
2015-11-26 10:07 ` Daniel Vetter
2015-11-27 16:30 ` Daniel Stone [this message]
2015-11-30 8:19 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPj87rOAcTnw4kF-SMeHcvg5t87EHmjNWjRjh9ZZwe8SRxVoHA@mail.gmail.com \
--to=daniel@fooishbar.org \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=marcheu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.