From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA463ECE58C for ; Fri, 11 Oct 2019 07:56:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BF3721A4A for ; Fri, 11 Oct 2019 07:56:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="maTbGSQZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=fooishbar-org.20150623.gappssmtp.com header.i=@fooishbar-org.20150623.gappssmtp.com header.b="RgpbaF19" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BF3721A4A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fooishbar.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OzHbNjZ4UmvCMBhkUg9nMDb4PnHMuOK9o43pju/8yPg=; b=maTbGSQZMOEhB+ hS3ngp88kCDm3TCOTdysnDFNlSB3HYFN1YIIBgMK1wbtKgjSIOtnbHg5nkbNtG7OKMR6rDur1YbWp bdW42ohQY9mu9B/huQdLvcpn0c0Axf6H5ibED5caWBCbW6BrOgeXgriL8D6xF2BHr0hoMhJP6SzLF 0WIXux9DwKmhKmqsA0drf3pBq89fRg3WQyEXQQyV9cD3NVopm63rF5ZCQ7Ai9B0Jyzo47Q6cd/AyA bLPjeaioxPO6BqGh4kFaeV/e2j4bUzjx2RtGOiXOQ8NZ9RqhNHH19V3jL3xF/W0FTD/K+R4kqhd4p +tNTrTilmu4v7vhe9ubw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIpn8-0002D8-9j; Fri, 11 Oct 2019 07:56:50 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIpn6-0002CG-5e for linux-arm-kernel@lists.infradead.org; Fri, 11 Oct 2019 07:56:49 +0000 Received: by mail-lf1-x143.google.com with SMTP id t8so6307689lfc.13 for ; Fri, 11 Oct 2019 00:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UQGlBjxrbnywssmQJ87NwAoJZT+0lBTYiPkUBZuGVTw=; b=RgpbaF19+L4HjyZuj1xRpxDlVrIO1vDy19Dfiz5Rl7uDlpaNesNszWjtEE9sDYJAfy DWB4PA/scgT+4iGBuozxAmUtD+FvG5SdMxz4IdXLFuMA4xeYGfbdscQx29VS9bKFQrg1 qbFLHgpt3WwYvkXuPScYudDFc306eo3kz+yGJW+BCD9T8ZJvXFCwnvaX5RdgcCsQqop+ 9rQYMxDyYY2iAN4KShC6XgL/KUfSez5HDUN8kqPDWGWm8zBDdTWRsvEhNP0q0xR/FL8O fD+pCT46Vgr14iF3sExQl/Bqn0LM0FNj9b26b1jsI/8mJ7S7/xJzRLVLdLxvJ6Vh2Cyz Ee9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UQGlBjxrbnywssmQJ87NwAoJZT+0lBTYiPkUBZuGVTw=; b=dSDcu68qehcqx43xxpNAwbsJNfAsWf++gMnunvSUV245IL/GH9q353TXxhXmtmYXn1 PEa9kuO+9REBjfzgW7J1UfobAOt9OmJ+X5xZxJqnGgPG7qZgl6QS3ZhC2elc93CLitf8 0OjHBW1su5le2ipJXGHEyYDXZZo8uYvHC03Ydt+c0sDc5VrXmKOhNwiqWbPBdkPEp2jd bogScvqZ6fnvHM/dPJsts5se3BsJBXgcQwSv/yTXL98mUMeAGsNN+ssR3tEcUreNt2HR GFGd5lPHXbpPNm9uqCpK2mnhkInQcwcI8FsbpGavItIzieoDZEzTJRwACsRJ9xJIFTXs 8KAQ== X-Gm-Message-State: APjAAAVn3H579acjsUyi1p7R2kpXom74+YKvI3t3CLe1i3Ds/L08jqsn I4eq25QIMNtLpp/Ia/0Zejj9BRXw9whapDdEg7QNsA== X-Google-Smtp-Source: APXvYqydtD0YWYlut/gC+NgQe7cNI5MaxlEW5q+G5DXSbrVkjh1YI+pJD62gc97sVpJKCLOnUn61MURODiP2A09VwnY= X-Received: by 2002:ac2:47f1:: with SMTP id b17mr7461543lfp.31.1570780605507; Fri, 11 Oct 2019 00:56:45 -0700 (PDT) MIME-Version: 1.0 References: <20191010092526.10419-1-narmstrong@baylibre.com> <20191010092526.10419-5-narmstrong@baylibre.com> <20191010132601.GA10110@arm.com> <44f1771f-d640-f23d-995f-7bfcadd213bc@baylibre.com> <20191010173152.GA575@arm.com> In-Reply-To: From: Daniel Stone Date: Fri, 11 Oct 2019 08:56:26 +0100 Message-ID: Subject: Re: [PATCH 4/7] drm/meson: plane: add support for AFBC mode for OSD1 plane To: Daniel Vetter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191011_005648_359007_FC94A939 X-CRM114-Status: GOOD ( 13.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd , Neil Armstrong , "khilman@baylibre.com" , "dri-devel@lists.freedesktop.org" , "linux-amlogic@lists.infradead.org" , Ayan Halder , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, 11 Oct 2019 at 08:46, Daniel Vetter wrote: > On Thu, Oct 10, 2019 at 7:32 PM Ayan Halder wrote: > > On Thu, Oct 10, 2019 at 03:41:15PM +0200, Neil Armstrong wrote: > > > Sorry I don't understand, you ask me to limit AFBC to ABGR8888 ? > > > > Apologies for the confusion, as per the link, the formats which are > > suggested with AFBC_FORMAT_MOD_YTR are the BGR/ABGR formats (as > > listed in the 'AFBC formats' table) > > > > Thus, any other permutation of the components might make it incompatible > > with some other AFBC producers/consumers. > > Uh, that's not how this is supposed to be used. Drivers are meant to > expose _everything_ they support (bonus if you roughly sort it in > preference order). Userspace then computes the intersection of > modifiers/formats supported by all devices it needs to share a buffer > with. Allowing that was the entire point of modifiers, if we > artificially limit to the common denominator we're back "only linear > works everywhere". Correct. A lot of userspace will select for format first, then find a modifier which can be used with that format. If userspace has specific knowledge of AFBC and decides that it prefers to use AFBC so will seek out an alpha format - and make sure everyone fills the channel solid - then that's fine. But that's putting the cart before the horse. Not exposing XRGB8888 on the primary plane will break a lot of userspace, so in this case AFBC would just never really be used. Cheers, Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Stone Subject: Re: [PATCH 4/7] drm/meson: plane: add support for AFBC mode for OSD1 plane Date: Fri, 11 Oct 2019 08:56:26 +0100 Message-ID: References: <20191010092526.10419-1-narmstrong@baylibre.com> <20191010092526.10419-5-narmstrong@baylibre.com> <20191010132601.GA10110@arm.com> <44f1771f-d640-f23d-995f-7bfcadd213bc@baylibre.com> <20191010173152.GA575@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A7EA6EBC1 for ; Fri, 11 Oct 2019 07:56:47 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id c195so6329984lfg.9 for ; Fri, 11 Oct 2019 00:56:47 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: nd , Neil Armstrong , "khilman@baylibre.com" , "dri-devel@lists.freedesktop.org" , "linux-amlogic@lists.infradead.org" , Ayan Halder , "linux-arm-kernel@lists.infradead.org" List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiBGcmksIDExIE9jdCAyMDE5IGF0IDA4OjQ2LCBEYW5pZWwgVmV0dGVyIDxkYW5pZWxA ZmZ3bGwuY2g+IHdyb3RlOgo+IE9uIFRodSwgT2N0IDEwLCAyMDE5IGF0IDc6MzIgUE0gQXlhbiBI YWxkZXIgPEF5YW4uSGFsZGVyQGFybS5jb20+IHdyb3RlOgo+ID4gT24gVGh1LCBPY3QgMTAsIDIw MTkgYXQgMDM6NDE6MTVQTSArMDIwMCwgTmVpbCBBcm1zdHJvbmcgd3JvdGU6Cj4gPiA+IFNvcnJ5 IEkgZG9uJ3QgdW5kZXJzdGFuZCwgeW91IGFzayBtZSB0byBsaW1pdCBBRkJDIHRvIEFCR1I4ODg4 ID8KPiA+Cj4gPiBBcG9sb2dpZXMgZm9yIHRoZSBjb25mdXNpb24sIGFzIHBlciB0aGUgbGluaywg dGhlIGZvcm1hdHMgd2hpY2ggYXJlCj4gPiBzdWdnZXN0ZWQgd2l0aCBBRkJDX0ZPUk1BVF9NT0Rf WVRSIGFyZSB0aGUgQkdSL0FCR1IgZm9ybWF0cyAoYXMKPiA+IGxpc3RlZCBpbiB0aGUgJ0FGQkMg Zm9ybWF0cycgdGFibGUpCj4gPgo+ID4gVGh1cywgYW55IG90aGVyIHBlcm11dGF0aW9uIG9mIHRo ZSBjb21wb25lbnRzIG1pZ2h0IG1ha2UgaXQgaW5jb21wYXRpYmxlCj4gPiB3aXRoIHNvbWUgb3Ro ZXIgQUZCQyBwcm9kdWNlcnMvY29uc3VtZXJzLgo+Cj4gVWgsIHRoYXQncyBub3QgaG93IHRoaXMg aXMgc3VwcG9zZWQgdG8gYmUgdXNlZC4gRHJpdmVycyBhcmUgbWVhbnQgdG8KPiBleHBvc2UgX2V2 ZXJ5dGhpbmdfIHRoZXkgc3VwcG9ydCAoYm9udXMgaWYgeW91IHJvdWdobHkgc29ydCBpdCBpbgo+ IHByZWZlcmVuY2Ugb3JkZXIpLiBVc2Vyc3BhY2UgdGhlbiBjb21wdXRlcyB0aGUgaW50ZXJzZWN0 aW9uIG9mCj4gbW9kaWZpZXJzL2Zvcm1hdHMgc3VwcG9ydGVkIGJ5IGFsbCBkZXZpY2VzIGl0IG5l ZWRzIHRvIHNoYXJlIGEgYnVmZmVyCj4gd2l0aC4gQWxsb3dpbmcgdGhhdCB3YXMgdGhlIGVudGly ZSBwb2ludCBvZiBtb2RpZmllcnMsIGlmIHdlCj4gYXJ0aWZpY2lhbGx5IGxpbWl0IHRvIHRoZSBj b21tb24gZGVub21pbmF0b3Igd2UncmUgYmFjayAib25seSBsaW5lYXIKPiB3b3JrcyBldmVyeXdo ZXJlIi4KCkNvcnJlY3QuCgpBIGxvdCBvZiB1c2Vyc3BhY2Ugd2lsbCBzZWxlY3QgZm9yIGZvcm1h dCBmaXJzdCwgdGhlbiBmaW5kIGEgbW9kaWZpZXIKd2hpY2ggY2FuIGJlIHVzZWQgd2l0aCB0aGF0 IGZvcm1hdC4gSWYgdXNlcnNwYWNlIGhhcyBzcGVjaWZpYwprbm93bGVkZ2Ugb2YgQUZCQyBhbmQg ZGVjaWRlcyB0aGF0IGl0IHByZWZlcnMgdG8gdXNlIEFGQkMgc28gd2lsbCBzZWVrCm91dCBhbiBh bHBoYSBmb3JtYXQgLSBhbmQgbWFrZSBzdXJlIGV2ZXJ5b25lIGZpbGxzIHRoZSBjaGFubmVsIHNv bGlkIC0KdGhlbiB0aGF0J3MgZmluZS4gQnV0IHRoYXQncyBwdXR0aW5nIHRoZSBjYXJ0IGJlZm9y ZSB0aGUgaG9yc2UuCgpOb3QgZXhwb3NpbmcgWFJHQjg4ODggb24gdGhlIHByaW1hcnkgcGxhbmUg d2lsbCBicmVhayBhIGxvdCBvZgp1c2Vyc3BhY2UsIHNvIGluIHRoaXMgY2FzZSBBRkJDIHdvdWxk IGp1c3QgbmV2ZXIgcmVhbGx5IGJlIHVzZWQuCgpDaGVlcnMsCkRhbmllbApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 395F4C47404 for ; Fri, 11 Oct 2019 07:57:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D18E20679 for ; Fri, 11 Oct 2019 07:57:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QfW4t6IP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=fooishbar-org.20150623.gappssmtp.com header.i=@fooishbar-org.20150623.gappssmtp.com header.b="RgpbaF19" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D18E20679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fooishbar.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ei1TH9Ss9fMMQB/Lzu6pZIbjhJ0cvQzn5CzPcd3MGTw=; b=QfW4t6IPGeldtz LtefqF7q528w4LTfn0EiJ2puegMwRCXhk4YazPzNAIOezewQ4cSdfa08yYtwvhSB5RIjRo2Yium5l U5DvSwLsTeZwMrYaR0xyb71c/Db2JOO4g3Wep4FyaXBrFyRfTPOO/UNBBFrG2EVbb4HLggfY/Se9k i5Kkeke44R75gj0oHUwKSRh7C+jkZGigrT6Ui5wfcREuB1pjifaBNg2aJk6+jucX742xBPNbxTJ17 6cMwfndrWo/sSvAiRoCLg+GchPmsLLJqoCIkP6nIwL9H/cqLCY29wkJFp5VAbx64HvMBPFzpWZXC4 nBvk0iNPsN11W/sqIPsA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIpnG-0002Ld-6J; Fri, 11 Oct 2019 07:56:58 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIpn6-0002CF-5G for linux-amlogic@lists.infradead.org; Fri, 11 Oct 2019 07:56:49 +0000 Received: by mail-lf1-x144.google.com with SMTP id u3so6332476lfl.10 for ; Fri, 11 Oct 2019 00:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fooishbar-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UQGlBjxrbnywssmQJ87NwAoJZT+0lBTYiPkUBZuGVTw=; b=RgpbaF19+L4HjyZuj1xRpxDlVrIO1vDy19Dfiz5Rl7uDlpaNesNszWjtEE9sDYJAfy DWB4PA/scgT+4iGBuozxAmUtD+FvG5SdMxz4IdXLFuMA4xeYGfbdscQx29VS9bKFQrg1 qbFLHgpt3WwYvkXuPScYudDFc306eo3kz+yGJW+BCD9T8ZJvXFCwnvaX5RdgcCsQqop+ 9rQYMxDyYY2iAN4KShC6XgL/KUfSez5HDUN8kqPDWGWm8zBDdTWRsvEhNP0q0xR/FL8O fD+pCT46Vgr14iF3sExQl/Bqn0LM0FNj9b26b1jsI/8mJ7S7/xJzRLVLdLxvJ6Vh2Cyz Ee9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UQGlBjxrbnywssmQJ87NwAoJZT+0lBTYiPkUBZuGVTw=; b=eQ5ZkKlOZnd9T0PY48XdxVD5wnE1a3ARcB+aI1C0ngmG/mxGVD1D1E5txGaq88j91f TNfi4M/hv0kp6WNPIYxXA71T4XkUIPZB+STYIMa8+mBW4uoy+IrHKXtxFk/5oMIvu9UY 6eT8tknPF6fObjowB/a5jIeYHt3qexENoJZghwOEsn0ieEZXowjtCm8FWVf5hBdEgCPR 8eWihP5P8ds8JXcK1xGQSFX6bBf9NutBOOmd0SfPCKhEW6a60vs2tQoOD1IMjcotYx9H /GxjUJ5xmvLuAvXh3LsiZqEL50CzYG6xaGd8aXcWqApXi5TEAEeGzjRO4kSnerh6kBa0 gNMw== X-Gm-Message-State: APjAAAW7MMMYevcxfmGQ38zusTMQo4h2wjGHlrfseoEYysmr525lchEk cPuoAgvRWU8TZjhH2AAUVW4yolR3Zhqgc2n21gYcGw== X-Google-Smtp-Source: APXvYqydtD0YWYlut/gC+NgQe7cNI5MaxlEW5q+G5DXSbrVkjh1YI+pJD62gc97sVpJKCLOnUn61MURODiP2A09VwnY= X-Received: by 2002:ac2:47f1:: with SMTP id b17mr7461543lfp.31.1570780605507; Fri, 11 Oct 2019 00:56:45 -0700 (PDT) MIME-Version: 1.0 References: <20191010092526.10419-1-narmstrong@baylibre.com> <20191010092526.10419-5-narmstrong@baylibre.com> <20191010132601.GA10110@arm.com> <44f1771f-d640-f23d-995f-7bfcadd213bc@baylibre.com> <20191010173152.GA575@arm.com> In-Reply-To: From: Daniel Stone Date: Fri, 11 Oct 2019 08:56:26 +0100 Message-ID: Subject: Re: [PATCH 4/7] drm/meson: plane: add support for AFBC mode for OSD1 plane To: Daniel Vetter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191011_005648_359321_B3467D57 X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd , Neil Armstrong , "khilman@baylibre.com" , "dri-devel@lists.freedesktop.org" , "linux-amlogic@lists.infradead.org" , Ayan Halder , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi, On Fri, 11 Oct 2019 at 08:46, Daniel Vetter wrote: > On Thu, Oct 10, 2019 at 7:32 PM Ayan Halder wrote: > > On Thu, Oct 10, 2019 at 03:41:15PM +0200, Neil Armstrong wrote: > > > Sorry I don't understand, you ask me to limit AFBC to ABGR8888 ? > > > > Apologies for the confusion, as per the link, the formats which are > > suggested with AFBC_FORMAT_MOD_YTR are the BGR/ABGR formats (as > > listed in the 'AFBC formats' table) > > > > Thus, any other permutation of the components might make it incompatible > > with some other AFBC producers/consumers. > > Uh, that's not how this is supposed to be used. Drivers are meant to > expose _everything_ they support (bonus if you roughly sort it in > preference order). Userspace then computes the intersection of > modifiers/formats supported by all devices it needs to share a buffer > with. Allowing that was the entire point of modifiers, if we > artificially limit to the common denominator we're back "only linear > works everywhere". Correct. A lot of userspace will select for format first, then find a modifier which can be used with that format. If userspace has specific knowledge of AFBC and decides that it prefers to use AFBC so will seek out an alpha format - and make sure everyone fills the channel solid - then that's fine. But that's putting the cart before the horse. Not exposing XRGB8888 on the primary plane will break a lot of userspace, so in this case AFBC would just never really be used. Cheers, Daniel _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic