From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755390AbdBNUcz (ORCPT ); Tue, 14 Feb 2017 15:32:55 -0500 Received: from mail-yb0-f169.google.com ([209.85.213.169]:36458 "EHLO mail-yb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755314AbdBNUcr (ORCPT ); Tue, 14 Feb 2017 15:32:47 -0500 MIME-Version: 1.0 In-Reply-To: <1487100302-9445-2-git-send-email-john.stultz@linaro.org> References: <1487100302-9445-1-git-send-email-john.stultz@linaro.org> <1487100302-9445-2-git-send-email-john.stultz@linaro.org> From: Daniel Stone Date: Tue, 14 Feb 2017 20:32:46 +0000 Message-ID: Subject: Re: [RFC][PATCH 1/2] drm/probe-helper: Add mode_valid check to drm_crtc_helper_funcs To: John Stultz Cc: lkml , Daniel Vetter , Jani Nikula , Sean Paul , David Airlie , Rob Clark , Xinliang Liu , Xinliang Liu , Rongrong Zou , Xinwei Kong , Chen Feng , Archit Taneja , dri-devel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, On 14 February 2017 at 19:25, John Stultz wrote: > +static enum drm_mode_status > +drm_connector_check_crtc_modes(struct drm_connector *connector, > + struct drm_display_mode *mode) > +{ > + struct drm_device *dev = connector->dev; > + const struct drm_crtc_helper_funcs *crtc_funcs; > + struct drm_crtc *c; > + > + if (mode->status != MODE_OK) > + return mode->status; > + > + /* Check all the crtcs on a connector to make sure the mode is valid */ > + drm_for_each_crtc(c, dev) { > + crtc_funcs = c->helper_private; > + if (crtc_funcs && crtc_funcs->mode_valid) > + mode->status = crtc_funcs->mode_valid(c, mode); > + if (mode->status != MODE_OK) > + break; > + } > + return mode->status; > +} Hm, that's unfortunate: it limits the mode list for every connector, to those which are supported by every single CRTC. So if you have one CRTC serving low-res LVDS, and another serving higher-res HDMI, suddenly you can't get bigger modes on HDMI. The idea seems sound enough, but a little more nuance might be good ... Cheers, Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Stone Subject: Re: [RFC][PATCH 1/2] drm/probe-helper: Add mode_valid check to drm_crtc_helper_funcs Date: Tue, 14 Feb 2017 20:32:46 +0000 Message-ID: References: <1487100302-9445-1-git-send-email-john.stultz@linaro.org> <1487100302-9445-2-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb0-x22d.google.com (mail-yb0-x22d.google.com [IPv6:2607:f8b0:4002:c09::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 950166E1BE for ; Tue, 14 Feb 2017 20:32:47 +0000 (UTC) Received: by mail-yb0-x22d.google.com with SMTP id o65so39935992ybo.2 for ; Tue, 14 Feb 2017 12:32:47 -0800 (PST) In-Reply-To: <1487100302-9445-2-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: Chen Feng , lkml , Xinliang Liu , dri-devel , Rongrong Zou , Daniel Vetter , Xinwei Kong List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKCk9uIDE0IEZlYnJ1YXJ5IDIwMTcgYXQgMTk6MjUsIEpvaG4gU3R1bHR6IDxqb2hu LnN0dWx0ekBsaW5hcm8ub3JnPiB3cm90ZToKPiArc3RhdGljIGVudW0gZHJtX21vZGVfc3RhdHVz Cj4gK2RybV9jb25uZWN0b3JfY2hlY2tfY3J0Y19tb2RlcyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAq Y29ubmVjdG9yLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2Rp c3BsYXlfbW9kZSAqbW9kZSkKPiArewo+ICsgICAgICAgc3RydWN0IGRybV9kZXZpY2UgKmRldiA9 IGNvbm5lY3Rvci0+ZGV2Owo+ICsgICAgICAgY29uc3Qgc3RydWN0IGRybV9jcnRjX2hlbHBlcl9m dW5jcyAqY3J0Y19mdW5jczsKPiArICAgICAgIHN0cnVjdCBkcm1fY3J0YyAqYzsKPiArCj4gKyAg ICAgICBpZiAobW9kZS0+c3RhdHVzICE9IE1PREVfT0spCj4gKyAgICAgICAgICAgICAgIHJldHVy biBtb2RlLT5zdGF0dXM7Cj4gKwo+ICsgICAgICAgLyogQ2hlY2sgYWxsIHRoZSBjcnRjcyBvbiBh IGNvbm5lY3RvciB0byBtYWtlIHN1cmUgdGhlIG1vZGUgaXMgdmFsaWQgKi8KPiArICAgICAgIGRy bV9mb3JfZWFjaF9jcnRjKGMsIGRldikgewo+ICsgICAgICAgICAgICAgICBjcnRjX2Z1bmNzID0g Yy0+aGVscGVyX3ByaXZhdGU7Cj4gKyAgICAgICAgICAgICAgIGlmIChjcnRjX2Z1bmNzICYmIGNy dGNfZnVuY3MtPm1vZGVfdmFsaWQpCj4gKyAgICAgICAgICAgICAgICAgICAgICAgbW9kZS0+c3Rh dHVzID0gY3J0Y19mdW5jcy0+bW9kZV92YWxpZChjLCBtb2RlKTsKPiArICAgICAgICAgICAgICAg aWYgKG1vZGUtPnN0YXR1cyAhPSBNT0RFX09LKQo+ICsgICAgICAgICAgICAgICAgICAgICAgIGJy ZWFrOwo+ICsgICAgICAgfQo+ICsgICAgICAgcmV0dXJuIG1vZGUtPnN0YXR1czsKPiArfQoKSG0s IHRoYXQncyB1bmZvcnR1bmF0ZTogaXQgbGltaXRzIHRoZSBtb2RlIGxpc3QgZm9yIGV2ZXJ5IGNv bm5lY3RvciwKdG8gdGhvc2Ugd2hpY2ggYXJlIHN1cHBvcnRlZCBieSBldmVyeSBzaW5nbGUgQ1JU Qy4gU28gaWYgeW91IGhhdmUgb25lCkNSVEMgc2VydmluZyBsb3ctcmVzIExWRFMsIGFuZCBhbm90 aGVyIHNlcnZpbmcgaGlnaGVyLXJlcyBIRE1JLApzdWRkZW5seSB5b3UgY2FuJ3QgZ2V0IGJpZ2dl ciBtb2RlcyBvbiBIRE1JLiBUaGUgaWRlYSBzZWVtcyBzb3VuZAplbm91Z2gsIGJ1dCBhIGxpdHRs ZSBtb3JlIG51YW5jZSBtaWdodCBiZSBnb29kIC4uLgoKQ2hlZXJzLApEYW5pZWwKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==