From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761125AbdADRDi (ORCPT ); Wed, 4 Jan 2017 12:03:38 -0500 Received: from mail-yw0-f173.google.com ([209.85.161.173]:35954 "EHLO mail-yw0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbdADRC7 (ORCPT ); Wed, 4 Jan 2017 12:02:59 -0500 MIME-Version: 1.0 In-Reply-To: <1483547351-5792-2-git-send-email-ayaka@soulik.info> References: <1483547351-5792-1-git-send-email-ayaka@soulik.info> <1483547351-5792-2-git-send-email-ayaka@soulik.info> From: Daniel Stone Date: Wed, 4 Jan 2017 17:02:57 +0000 Message-ID: Subject: Re: [PATCH v2 1/2] drm_fourcc: Add new P010, P016 video format To: Randy Li Cc: dri-devel , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Li Randy , Linux Kernel Mailing List , "Vetter, Daniel" , mchehab@kernel.org, linux-media@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On 4 January 2017 at 16:29, Randy Li wrote: > index 90d2cc8..23c8e99 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -165,6 +165,9 @@ const struct drm_format_info *__drm_format_info(u32 format) > { .format = DRM_FORMAT_UYVY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_VYUY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_AYUV, .depth = 0, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1 }, > + /* FIXME a pixel in Y for P010 is 10 bits */ > + { .format = DRM_FORMAT_P010, .depth = 0, .num_planes = 2, .cpp = { 1, 2, 0 }, .hsub = 2, .vsub = 2 }, It seems like P010 stores each Y component in a 16-bit value, with the bottom 6 bits ignored. So I think cpp here should be 2. Cheers, Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Stone Subject: Re: [PATCH v2 1/2] drm_fourcc: Add new P010, P016 video format Date: Wed, 4 Jan 2017 17:02:57 +0000 Message-ID: References: <1483547351-5792-1-git-send-email-ayaka@soulik.info> <1483547351-5792-2-git-send-email-ayaka@soulik.info> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-x230.google.com (mail-yw0-x230.google.com [IPv6:2607:f8b0:4002:c05::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6C70D6E77F for ; Wed, 4 Jan 2017 17:02:59 +0000 (UTC) Received: by mail-yw0-x230.google.com with SMTP id t125so319588388ywc.1 for ; Wed, 04 Jan 2017 09:02:59 -0800 (PST) In-Reply-To: <1483547351-5792-2-git-send-email-ayaka@soulik.info> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Randy Li Cc: Li Randy , Linux Kernel Mailing List , dri-devel , "Vetter, Daniel" , mchehab@kernel.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgUmFuZHksCgpPbiA0IEphbnVhcnkgMjAxNyBhdCAxNjoyOSwgUmFuZHkgTGkgPGF5YWthQHNv dWxpay5pbmZvPiB3cm90ZToKPiBpbmRleCA5MGQyY2M4Li4yM2M4ZTk5IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZm91cmNjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2ZvdXJjYy5jCj4gQEAgLTE2NSw2ICsxNjUsOSBAQCBjb25zdCBzdHJ1Y3QgZHJtX2Zvcm1hdF9p bmZvICpfX2RybV9mb3JtYXRfaW5mbyh1MzIgZm9ybWF0KQo+ICAgICAgICAgICAgICAgICB7IC5m b3JtYXQgPSBEUk1fRk9STUFUX1VZVlksICAgICAgICAgICAgLmRlcHRoID0gMCwgIC5udW1fcGxh bmVzID0gMSwgLmNwcCA9IHsgMiwgMCwgMCB9LCAuaHN1YiA9IDIsIC52c3ViID0gMSB9LAo+ICAg ICAgICAgICAgICAgICB7IC5mb3JtYXQgPSBEUk1fRk9STUFUX1ZZVVksICAgICAgICAgICAgLmRl cHRoID0gMCwgIC5udW1fcGxhbmVzID0gMSwgLmNwcCA9IHsgMiwgMCwgMCB9LCAuaHN1YiA9IDIs IC52c3ViID0gMSB9LAo+ICAgICAgICAgICAgICAgICB7IC5mb3JtYXQgPSBEUk1fRk9STUFUX0FZ VVYsICAgICAgICAgICAgLmRlcHRoID0gMCwgIC5udW1fcGxhbmVzID0gMSwgLmNwcCA9IHsgNCwg MCwgMCB9LCAuaHN1YiA9IDEsIC52c3ViID0gMSB9LAo+ICsgICAgICAgICAgICAgICAvKiBGSVhN RSBhIHBpeGVsIGluIFkgZm9yIFAwMTAgaXMgMTAgYml0cyAqLwo+ICsgICAgICAgICAgICAgICB7 IC5mb3JtYXQgPSBEUk1fRk9STUFUX1AwMTAsICAgICAgICAgICAgLmRlcHRoID0gMCwgIC5udW1f cGxhbmVzID0gMiwgLmNwcCA9IHsgMSwgMiwgMCB9LCAuaHN1YiA9IDIsIC52c3ViID0gMiB9LAoK SXQgc2VlbXMgbGlrZSBQMDEwIHN0b3JlcyBlYWNoIFkgY29tcG9uZW50IGluIGEgMTYtYml0IHZh bHVlLCB3aXRoIHRoZQpib3R0b20gNiBiaXRzIGlnbm9yZWQuIFNvIEkgdGhpbmsgY3BwIGhlcmUg c2hvdWxkIGJlIDIuCgpDaGVlcnMsCkRhbmllbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK