From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752156AbcHFUwo (ORCPT ); Sat, 6 Aug 2016 16:52:44 -0400 Received: from mail-lf0-f42.google.com ([209.85.215.42]:34140 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbcHFUwn (ORCPT ); Sat, 6 Aug 2016 16:52:43 -0400 MIME-Version: 1.0 In-Reply-To: <1469196645-3061-3-git-send-email-tomeu.vizoso@collabora.com> References: <1469196645-3061-1-git-send-email-tomeu.vizoso@collabora.com> <1469196645-3061-3-git-send-email-tomeu.vizoso@collabora.com> From: Daniel Stone Date: Sat, 6 Aug 2016 18:04:06 +0100 Message-ID: Subject: Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs To: Tomeu Vizoso Cc: Linux Kernel Mailing List , linux-doc@vger.kernel.org, Jonathan Corbet , dri-devel , Daniel Vetter , Emil Velikov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomeu, On 22 July 2016 at 15:10, Tomeu Vizoso wrote: > +/** > + * DOC: CRC ABI > + * > + * DRM device drivers can provide to userspace CRC information of each frame as > + * it reached a given hardware component (a "source"). > + * > + * Userspace can control generation of CRCs in a given CRTC by writing to the s/can/must/ Is it worth having 'auto' as a default source perhaps? > + * file dri/0/crtc-N/crc/control in debugfs, with N being the index of the CRTC. > + * Accepted values are source names (which are driver-specific) and the "none" > + * and "auto" keywords. "none" will disable CRC generation and "auto" will let > + * the driver select a default source of frame CRCs for this CRTC. Is it also worth having 'connector-%s' (named as per sysfs, e.g. connector-HDMI-A-0) as a standardised entry, for cloneable CRTCs which have CRC control on the connector rather than the CRTC? Cheers, Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Stone Subject: Re: [PATCH v3 2/3] drm: Add API for capturing frame CRCs Date: Sat, 6 Aug 2016 18:04:06 +0100 Message-ID: References: <1469196645-3061-1-git-send-email-tomeu.vizoso@collabora.com> <1469196645-3061-3-git-send-email-tomeu.vizoso@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x22a.google.com (mail-lf0-x22a.google.com [IPv6:2a00:1450:4010:c07::22a]) by gabe.freedesktop.org (Postfix) with ESMTPS id D32B06E2B2 for ; Sat, 6 Aug 2016 17:04:08 +0000 (UTC) Received: by mail-lf0-x22a.google.com with SMTP id g62so222236085lfe.3 for ; Sat, 06 Aug 2016 10:04:08 -0700 (PDT) In-Reply-To: <1469196645-3061-3-git-send-email-tomeu.vizoso@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomeu Vizoso Cc: Jonathan Corbet , linux-doc@vger.kernel.org, Linux Kernel Mailing List , dri-devel , Daniel Vetter , Emil Velikov List-Id: dri-devel@lists.freedesktop.org SGkgVG9tZXUsCgpPbiAyMiBKdWx5IDIwMTYgYXQgMTU6MTAsIFRvbWV1IFZpem9zbyA8dG9tZXUu dml6b3NvQGNvbGxhYm9yYS5jb20+IHdyb3RlOgo+ICsvKioKPiArICogRE9DOiBDUkMgQUJJCj4g KyAqCj4gKyAqIERSTSBkZXZpY2UgZHJpdmVycyBjYW4gcHJvdmlkZSB0byB1c2Vyc3BhY2UgQ1JD IGluZm9ybWF0aW9uIG9mIGVhY2ggZnJhbWUgYXMKPiArICogaXQgcmVhY2hlZCBhIGdpdmVuIGhh cmR3YXJlIGNvbXBvbmVudCAoYSAic291cmNlIikuCj4gKyAqCj4gKyAqIFVzZXJzcGFjZSBjYW4g Y29udHJvbCBnZW5lcmF0aW9uIG9mIENSQ3MgaW4gYSBnaXZlbiBDUlRDIGJ5IHdyaXRpbmcgdG8g dGhlCgpzL2Nhbi9tdXN0LwoKSXMgaXQgd29ydGggaGF2aW5nICdhdXRvJyBhcyBhIGRlZmF1bHQg c291cmNlIHBlcmhhcHM/Cgo+ICsgKiBmaWxlIGRyaS8wL2NydGMtTi9jcmMvY29udHJvbCBpbiBk ZWJ1Z2ZzLCB3aXRoIE4gYmVpbmcgdGhlIGluZGV4IG9mIHRoZSBDUlRDLgo+ICsgKiBBY2NlcHRl ZCB2YWx1ZXMgYXJlIHNvdXJjZSBuYW1lcyAod2hpY2ggYXJlIGRyaXZlci1zcGVjaWZpYykgYW5k IHRoZSAibm9uZSIKPiArICogYW5kICJhdXRvIiBrZXl3b3Jkcy4gIm5vbmUiIHdpbGwgZGlzYWJs ZSBDUkMgZ2VuZXJhdGlvbiBhbmQgImF1dG8iIHdpbGwgbGV0Cj4gKyAqIHRoZSBkcml2ZXIgc2Vs ZWN0IGEgZGVmYXVsdCBzb3VyY2Ugb2YgZnJhbWUgQ1JDcyBmb3IgdGhpcyBDUlRDLgoKSXMgaXQg YWxzbyB3b3J0aCBoYXZpbmcgJ2Nvbm5lY3Rvci0lcycgKG5hbWVkIGFzIHBlciBzeXNmcywgZS5n Lgpjb25uZWN0b3ItSERNSS1BLTApIGFzIGEgc3RhbmRhcmRpc2VkIGVudHJ5LCBmb3IgY2xvbmVh YmxlIENSVENzIHdoaWNoCmhhdmUgQ1JDIGNvbnRyb2wgb24gdGhlIGNvbm5lY3RvciByYXRoZXIg dGhhbiB0aGUgQ1JUQz8KCkNoZWVycywKRGFuaWVsCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=