All of lore.kernel.org
 help / color / mirror / Atom feed
From: 蒋威 <jarvis.w.jiang@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, rppt@linux.ibm.com,
	akpm@linux-foundation.org,  linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-mm@kvack.org,  cchen50@lenovo.com,
	mpearson@lenovo.com
Subject: Re: [PATCH] Add MHI bus support and driver for T99W175 5G modem
Date: Wed, 17 Mar 2021 18:09:44 +0800	[thread overview]
Message-ID: <CAPncsNMHCwnTS95M_MTd3DUycCBvHXkp+RSu5Tug9057B9-S0w@mail.gmail.com> (raw)
In-Reply-To: <20210316143756.45ef6d91@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

> There's already a drivers/net/mhi/
It seems the latest kernel supports mhi driver, but there is no mhi driver
on the 5.4.44 kernel, I want to add it to 5.4.44, is that ok?

> Virtio drivers don't sit under drivers/virtio, and most certainly not
under drivers/bus/virtio
Thanks, however, I will put files into a more suitable location.

> Ugh, can you clarify what's the source of this code dump and if you're
coordinating with others working on Qualcomm drivers?
The source code is ported from IPQ8072 arm platform, including MHI, MBIM,
RmNet.
No, I have no cooperation with the people working on Qualcomm drivers.

Thanks,
Jarvis

Jakub Kicinski <kuba@kernel.org> 于2021年3月17日周三 上午5:37写道：

> On Tue, 16 Mar 2021 05:42:37 -0700 Jarvis Jiang wrote:
> >  drivers/bus/mhi/devices/mhi_netdev.c          | 1830 +++++++++++++
>
> There's already a drivers/net/mhi/
>
> Please make sure the drivers live in their respective subsystem.
>
> Virtio drivers don't sit under drivers/virtio, and most certainly not
> under drivers/bus/virtio...
>
> >  drivers/bus/mhi/devices/mhi_satellite.c       | 1155 +++++++++
> >  drivers/bus/mhi/devices/mhi_uci.c             |  802 ++++++
>
> Ugh, can you clarify what's the source of this code dump and if you're
> coordinating with others working on Qualcomm drivers?
>

[-- Attachment #2: Type: text/html, Size: 1753 bytes --]

  reply	other threads:[~2021-03-17 10:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 12:42 [PATCH] Add MHI bus support and driver for T99W175 5G modem Jarvis Jiang
2021-03-16 13:30 ` Mike Rapoport
2021-03-17  9:37   ` 蒋威
2021-03-16 21:37 ` Jakub Kicinski
2021-03-17 10:09   ` 蒋威 [this message]
2021-03-18  8:45 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPncsNMHCwnTS95M_MTd3DUycCBvHXkp+RSu5Tug9057B9-S0w@mail.gmail.com \
    --to=jarvis.w.jiang@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cchen50@lenovo.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpearson@lenovo.com \
    --cc=netdev@vger.kernel.org \
    --cc=rppt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.