From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <himadri18.07@gmail.com>
MIME-Version: 1.0
From: Himadri Pandya <himadri18.07@gmail.com>
Date: Mon, 7 Jan 2019 16:04:46 +0530
Message-ID: <CAPnhUpZuYMAfor5jYeD-P4bP4aq=iMRN+fgXXSJc8qkRV_Yokw@mail.gmail.com>
Subject: rtl8192e: need help with variable naming convention
Content-Type: multipart/alternative; boundary="000000000000478f9d057edbc879"
List-ID: <driverdev-devel.linuxdriverproject.org>
To: driverdev-devel@linuxdriverproject.org
Cc: gregkh@linuxfoundation.org

--000000000000478f9d057edbc879
Content-Type: text/plain; charset="UTF-8"

Hello,

I'm getting started with device drivers. And as a starter, I'm working on
some clean-up patches.  I'm particularly targeting to rename a structure
array "ChannelPlan"(in file dot11d.c) to fix a checkpatch.pl warning "Avoid
CamelCase". According to the coding style, it should be converted to
"channel_plan". But the code contains a function argument with the same
name "channel_plan". Should I then rename the array to something like
"channel_name_"? I'm sorry for asking such a silly question. But I want to
know if renaming it in such a ways fits in the convention before I make the
change.

Thank you.

- Himadri

--000000000000478f9d057edbc879
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hello,<div><br></div><div>I&#39;m getting started with dev=
ice drivers. And as a starter, I&#39;m working on some clean-up patches.=C2=
=A0 I&#39;m particularly targeting to rename a structure array &quot;Channe=
lPlan&quot;(in file dot11d.c) to fix a <a href=3D"http://checkpatch.pl">che=
ckpatch.pl</a> warning &quot;Avoid CamelCase&quot;. According to the coding=
 style, it should be converted to &quot;channel_plan&quot;. But the code co=
ntains a function argument with the same name &quot;channel_plan&quot;. Sho=
uld I then rename the array to something like &quot;channel_name_&quot;? I&=
#39;m sorry for asking such a silly question. But I want to know if renamin=
g it in such a ways fits in the convention before I make the change.<br></d=
iv><div><br></div><div>Thank you.</div><div><br></div><div>- Himadri</div><=
/div>

--000000000000478f9d057edbc879--