From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <himadri18.07@gmail.com>
MIME-Version: 1.0
References: <CAPnhUpZuYMAfor5jYeD-P4bP4aq=iMRN+fgXXSJc8qkRV_Yokw@mail.gmail.com>
 <20190107105214.GA31559@kroah.com>
In-Reply-To: <20190107105214.GA31559@kroah.com>
From: Himadri Pandya <himadri18.07@gmail.com>
Date: Sat, 12 Jan 2019 22:26:55 -0800
Message-ID: <CAPnhUpaMyR8tWt+OGqnUUB0kH__tMf5SFE6eTLfJRCH8MCW_NQ@mail.gmail.com>
Subject: Re: rtl8192e: need help with variable naming convention
Content-Type: multipart/alternative; boundary="0000000000006c0207057f5104c9"
List-ID: <driverdev-devel.linuxdriverproject.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: driverdev-devel@linuxdriverproject.org

--0000000000006c0207057f5104c9
Content-Type: text/plain; charset="UTF-8"

Tried but it resulted in a compilation error. So renaming it with a
different name (channel_array[ ]) instead.

Thank you.

- Himadri

On Mon, Jan 7, 2019 at 2:52 AM Greg KH <gregkh@linuxfoundation.org> wrote:

> On Mon, Jan 07, 2019 at 04:04:46PM +0530, Himadri Pandya wrote:
> > Hello,
> >
> > I'm getting started with device drivers. And as a starter, I'm working on
> > some clean-up patches.  I'm particularly targeting to rename a structure
> > array "ChannelPlan"(in file dot11d.c) to fix a checkpatch.pl warning
> "Avoid
> > CamelCase". According to the coding style, it should be converted to
> > "channel_plan". But the code contains a function argument with the same
> > name "channel_plan". Should I then rename the array to something like
> > "channel_name_"? I'm sorry for asking such a silly question. But I want
> to
> > know if renaming it in such a ways fits in the convention before I make
> the
> > change.
>
> A structure name is different from a function name, so odds are you can
> just do this with no problems.  Try it and find out!
>
> greg k-h
>

--0000000000006c0207057f5104c9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Tried but it resulted in a compilation error. So renaming=
=C2=A0it with a different name (channel_array[ ]) instead.<div><br></div><d=
iv>Thank you.</div><div><br></div><div>- Himadri=C2=A0<br></div></div><br><=
div class=3D"gmail_quote"><div dir=3D"ltr">On Mon, Jan 7, 2019 at 2:52 AM G=
reg KH &lt;<a href=3D"mailto:gregkh@linuxfoundation.org">gregkh@linuxfounda=
tion.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D=
"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-le=
ft:1ex">On Mon, Jan 07, 2019 at 04:04:46PM +0530, Himadri Pandya wrote:<br>
&gt; Hello,<br>
&gt; <br>
&gt; I&#39;m getting started with device drivers. And as a starter, I&#39;m=
 working on<br>
&gt; some clean-up patches.=C2=A0 I&#39;m particularly targeting to rename =
a structure<br>
&gt; array &quot;ChannelPlan&quot;(in file dot11d.c) to fix a <a href=3D"ht=
tp://checkpatch.pl" rel=3D"noreferrer" target=3D"_blank">checkpatch.pl</a> =
warning &quot;Avoid<br>
&gt; CamelCase&quot;. According to the coding style, it should be converted=
 to<br>
&gt; &quot;channel_plan&quot;. But the code contains a function argument wi=
th the same<br>
&gt; name &quot;channel_plan&quot;. Should I then rename the array to somet=
hing like<br>
&gt; &quot;channel_name_&quot;? I&#39;m sorry for asking such a silly quest=
ion. But I want to<br>
&gt; know if renaming it in such a ways fits in the convention before I mak=
e the<br>
&gt; change.<br>
<br>
A structure name is different from a function name, so odds are you can<br>
just do this with no problems.=C2=A0 Try it and find out!<br>
<br>
greg k-h<br>
</blockquote></div>

--0000000000006c0207057f5104c9--