From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <himadri18.07@gmail.com>
MIME-Version: 1.0
References: <CAPnhUpZuYMAfor5jYeD-P4bP4aq=iMRN+fgXXSJc8qkRV_Yokw@mail.gmail.com>
 <20190107105214.GA31559@kroah.com> <20190107130314.GD3200@kadam>
 <CAPnhUpb7huehqHpLZ+Kz657xAZVCqLWYTW2RfK6Yy=mAP5QgYg@mail.gmail.com> <20190114105123.GA22496@kadam>
In-Reply-To: <20190114105123.GA22496@kadam>
From: Himadri Pandya <himadri18.07@gmail.com>
Date: Mon, 14 Jan 2019 17:39:24 +0530
Message-ID: <CAPnhUpacCUrqw3c_cA9A9mOTw7Lksd-Cy-XOZagxfqTQp9crfQ@mail.gmail.com>
Subject: Re: rtl8192e: need help with variable naming convention
Content-Type: multipart/alternative; boundary="0000000000001f12b2057f69eb45"
List-ID: <driverdev-devel.linuxdriverproject.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, driverdev-devel@linuxdriverproject.org

--0000000000001f12b2057f69eb45
Content-Type: text/plain; charset="UTF-8"

On Mon, 14 Jan, 2019, 4:21 PM Dan Carpenter <dan.carpenter@oracle.com wrote:

Naming is hard.  Having "_array" in the name isn't great either.  It's
> normally obvious it's an array because of the [] characters.
>

Okay. How about renaming it to "_list[ ]" ? But I'm not sure if calling it
a list will introduce redundancy or increase readability by showing we're
implementing a list with an array?

- Himadri

>

--0000000000001f12b2057f69eb45
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><div class=3D"gmail_quote"><div dir=3D"ltr">On Mon, =
14 Jan, 2019, 4:21 PM Dan Carpenter &lt;<a href=3D"mailto:dan.carpenter@ora=
cle.com">dan.carpenter@oracle.com</a> wrote:</div><div dir=3D"ltr"><br></di=
v><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:=
1px #ccc solid;padding-left:1ex">
Naming is hard.=C2=A0 Having &quot;_array&quot; in the name isn&#39;t great=
 either.=C2=A0 It&#39;s<br>
normally obvious it&#39;s an array because of the [] characters.<br></block=
quote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">Okay. How a=
bout renaming it to &quot;_list[ ]&quot; ? But I&#39;m not sure if calling =
it a list will introduce redundancy or increase readability by showing we&#=
39;re implementing a list with an array?=C2=A0</div><div dir=3D"auto"><br><=
/div><div dir=3D"auto">- Himadri=C2=A0</div><div dir=3D"auto"><div class=3D=
"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;=
border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--0000000000001f12b2057f69eb45--