From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47ECBC433F5 for ; Fri, 21 Jan 2022 16:53:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 75B9F835B3; Fri, 21 Jan 2022 17:53:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="gkI6lmf8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 374958141A; Fri, 21 Jan 2022 17:53:51 +0100 (CET) Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A535783055 for ; Fri, 21 Jan 2022 17:53:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa33.google.com with SMTP id m131so5916051vkm.7 for ; Fri, 21 Jan 2022 08:53:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MzynsgiS0b03PsLdvk8Dah6J9z444OzgEHXn1ejwzhE=; b=gkI6lmf8XBD65r6yaMRju5AM6tK5fPvrROpjbtpctc3SLXXTb7YGgVnXVte784ytY8 akgenpHOwDmkbVbkzPsIHYPpwj5/qGJ+EgU+hJu9XKOPActdLVbsD6DFGQ89fFYY/uyP hyk2C2gVFnTz90gnHRQtBa2GHlHj+5GqdaLlc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MzynsgiS0b03PsLdvk8Dah6J9z444OzgEHXn1ejwzhE=; b=kTiiClBXqPP8uRoZTqXBLfbZ5w5Nszv7TthI8IBFLlz/bwzf7ss7vjIPLS1N6eDIRJ v0rziW3Rk7dzw0ux3o6w7/7LQREaSESFfarb2oUtdX3dvCisUqNmWFZyTHe+0q5Cuuvs qa/tb74Zgc+jJyGxlV0F2ZWYTAopxhPuggzuFJ+3ctqi2W8d1GdEKnMWFmRnz+7LkTG5 eIFaHTRAx4R/7jfNHekKu2QTykn8av1Uga87GH8XdYAA/9SpCxc+aRpSJia0DNfi3iCi sSHnLEGwe30M6He6WpsXvGn8VDPm5BqJmG3g+fnjUWh6IdVwh0Wu4giQsDYi+nayyIkU 3O/w== X-Gm-Message-State: AOAM5303sJxbH2I13Jr7AY8JIBhVdB6rVwCLZGIv1i3IBmzEzP4G4IET vlY/lUFxVuAdTBh6VDZar47h5LsrGWFODuGvfLjaSYERSxs= X-Google-Smtp-Source: ABdhPJxfwsikcsvHHeXcYxnykUc5TCFwt7I2sR/XEM9hy9PBttcBMhI7RwWm7qA1bPQ9wfzVmubmjPyd8Pxn5wQhIIQ= X-Received: by 2002:a05:6122:208a:: with SMTP id i10mr2202501vkd.16.1642784026581; Fri, 21 Jan 2022 08:53:46 -0800 (PST) MIME-Version: 1.0 References: <20220116151441.219566-1-heinrich.schuchardt@canonical.com> <20220116151441.219566-7-heinrich.schuchardt@canonical.com> In-Reply-To: From: Simon Glass Date: Fri, 21 Jan 2022 09:53:34 -0700 Message-ID: Subject: Re: [PATCH 6/8] cmd: efidebug: simplify printing GUIDs To: Heinrich Schuchardt Cc: Tom Rini , Rasmus Villemoes , Patrick Delaunay , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Fri, 21 Jan 2022 at 09:03, Heinrich Schuchardt wrote: > > On 1/21/22 16:20, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt > > wrote: > >> > >> Use "%pS" to print text representations of GUIDs. > >> > >> Signed-off-by: Heinrich Schuchardt > >> --- > >> cmd/efidebug.c | 160 ++--------------------------------------- > >> include/efi_api.h | 8 +++ > >> include/efi_dt_fixup.h | 4 -- > >> include/efi_rng.h | 4 -- > >> lib/uuid.c | 116 ++++++++++++++++++++++++++++++ > >> 5 files changed, 128 insertions(+), 164 deletions(-) > >> > > > > Does this blow up the image size? These strings only in the debug side before. > > It was to avoid image size increase that I added > +#ifdef CONFIG_CMD_EFIDEBUG Ah yes, thanks. Reviewed-by: Simon Glass > > > > > Having said that, I would much rather see a string than a guid, which > > I consider to be little more than an obfuscation. > > That was my motivation. When debugging a boot failure I set DEBUG in > lib/efi_loader/efi_boottime.c and reading GUIDs in the debug output was > not helpful. Indeed. Regards, SImon