From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2ED7C433F5 for ; Tue, 8 Feb 2022 20:40:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4F09B83DAD; Tue, 8 Feb 2022 21:39:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Xw0UrYVh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C457C83D91; Tue, 8 Feb 2022 21:39:38 +0100 (CET) Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8DF3F83D1D for ; Tue, 8 Feb 2022 21:39:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vs1-xe33.google.com with SMTP id g10so369593vss.1 for ; Tue, 08 Feb 2022 12:39:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:from:in-reply-to:references:date:message-id :subject:to:cc; bh=sxlOffCpvBGr0vx/j5uPbDX2vM29IbttJz2AX9UQhMA=; b=Xw0UrYVh+RO1k30VZVcHoCsTaEG5vkJe0TBC1URQo/TkAwKZCCmbEEuENrX6N3iyIi DXyqPSsCUwwXXNJ0CXC6t3/bM9XpwHJXQKkVmaO+YXilcdrbIDBY0MGiPGkEJFM4UlQU DXPtfooSmg5PXkozDiggvGIWfr7i5VoFV+TAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:sender:from:in-reply-to:references :date:message-id:subject:to:cc; bh=sxlOffCpvBGr0vx/j5uPbDX2vM29IbttJz2AX9UQhMA=; b=UgolKwcMPrreiSBo0PmdpgKjrAEmdISyYccdwjab/roRzyeQSfgb0PJY8YepwKLO+t E7UfI8HCgut8tvDZGuUdtK9jt6QByKgJBgHrdzaxN3r1BhkAEacKYSL/S4N2u2Lyaljt 5wZOcxN0dTXluCfI7cJV+00P9lalglh31swjpYnP6kRlQvCUIwPbgMHLTMM6M5TUplL/ Zd5mxjLuZEzYscOmU8geGZj7N3SGlcHsi87VBrlptglJNGGlZkqXCl2WrJYnovDnLWux N1FFroJTL/NIGHpkAF3DmL+wOHB/BM8M1mAHOmUYTxLB68US++zJaphSWBgroMRz4+If LUeQ== X-Gm-Message-State: AOAM531TDubRVB8ToTDX20ciEUw9PXDUGireGQP+1z9XGd+wps1zctmV SH6cZgaywKA0R7khiTtb1/w4CwH7lVcUlCP3nbXvww== X-Google-Smtp-Source: ABdhPJyyloUBLRT3SkL1g8JY/qCgU5c1AYYeZrXLqpIuomqj0f5Hi9tZLA5tHATRZ7lOuFb+TCgBMbeUBsBMkZ2wCv0= X-Received: by 2002:a05:6102:508:: with SMTP id l8mr2002273vsa.51.1644352771036; Tue, 08 Feb 2022 12:39:31 -0800 (PST) Received: from 480794996271 named unknown by gmailapi.google.com with HTTPREST; Tue, 8 Feb 2022 20:39:30 +0000 MIME-Version: 1.0 From: Simon Glass In-Reply-To: References: <20220207220809.4497-1-alpernebiyasak@gmail.com> <20220207220809.4497-2-alpernebiyasak@gmail.com> Date: Tue, 8 Feb 2022 20:39:30 +0000 X-Google-Sender-Auth: j5gatDIg3ewpdqpgS8_hlF91-HQ Message-ID: Subject: Re: [PATCH v2 1/5] binman: Fix subentry expansion for FIT entry type To: Simon Glass Cc: U-Boot Mailing List , Heiko Thiery , Jan Kiszka , Alper Nebi Yasak Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Mon, 7 Feb 2022 at 15:08, Alper Nebi Yasak wrote: > > Binman tries to expand some entries into parts that make it up, e.g. > 'u-boot' into a 'u-boot-expanded' section that contains 'u-boot-nodtb' > and 'u-boot-dtb'. Entries with child entries must call ExpandEntries() > on them to build a correct image, as it's possible that unexpanded child > entries have no data of their own. The FIT entry type doesn't currently > do this, which means putting a "u-boot" entry inside it doesn't work as > expected. > > Implement ExpandEntries() for FIT and add a copy of a simple FIT image > test that checks subentry expansion in FIT entries. > > Signed-off-by: Alper Nebi Yasak > --- > > Changes in v2: > - Split reused testSimpleFit code into a helper function > > tools/binman/etype/fit.py | 5 +++++ > tools/binman/ftest.py | 33 ++++++++++++++++++++++++--------- > 2 files changed, 29 insertions(+), 9 deletions(-) Reviewed-by: Simon Glass I missed the duplicate number on the dts, but will fix that when applying. > Applied to u-boot-dm, thanks!