From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0C0DC433EF for ; Sat, 13 Nov 2021 18:16:14 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CCEF60F46 for ; Sat, 13 Nov 2021 18:16:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6CCEF60F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BB17183043; Sat, 13 Nov 2021 19:16:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="VckWndwU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6DF28830F9; Sat, 13 Nov 2021 19:16:10 +0100 (CET) Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2064082F66 for ; Sat, 13 Nov 2021 19:16:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x933.google.com with SMTP id v3so25673636uam.10 for ; Sat, 13 Nov 2021 10:16:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fzC5WvLoD3TtVFV3JcEL9quVtF3PXE+4+hvBn0gnJH4=; b=VckWndwUZqHDZixX/gobcrvx0lmBvFdbHlO1rAL8J/wToQdefQwk3wdRpTasoESJhA CvikLCGMw1DgEmXiKe0i0zx9LMBAbT9YQxoKRVn/0cWOj2KNhIWAt+W8nG3SCn/r6rUN v4j4b/X0hjmXbYTpt9jg1IBEvz4w+pVgDdke4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fzC5WvLoD3TtVFV3JcEL9quVtF3PXE+4+hvBn0gnJH4=; b=wm8CVum4bHHIpc6kwTlg+pS4L+Krau1wbfKlXn891xY7VXEE5vCUiuFPiio4lEphPb AXjMFBej8WqNvcDLy7L0cVZdh3Fr+7RFtc/LWB6xirPjwAPuBS3RKDD6nhcuRpBYPiEM W3HpHeDSNFIlkKalxBebg850L8YF36RpyTUaS+iPA+Sv9uSNwxBZqfhtwBMWwp/vRjj+ IqLDI26ESNt1lGdw2lT55uDzylunCUaWqrrOFBU3cn9JpHwGj+Al6UXd/axIyT40/xlM i+/d6mgY8wBVhm78qBL2SUpAcZia2m79lg/eUZJE4+6sn2X0bCy4moTkQWgQy9K8clTw AXiA== X-Gm-Message-State: AOAM5336+JdtNCmDeKeJmDX5e1CiWbYCs7FEnRneRLQmNp4KZKFhw0w9 nbriaOfDwKc2erMt8mxmT9izdgzN4UQGmFt2bBg7yA== X-Google-Smtp-Source: ABdhPJwocs7FHJuiH5UrUAg+9jMIcBt0FN4L3O8IyjzQ7AGpSxNegUOeX25SeqLK8v+Q33BOx/svLrTDPfA35LFxqqk= X-Received: by 2002:a67:de88:: with SMTP id r8mr22336266vsk.15.1636827365876; Sat, 13 Nov 2021 10:16:05 -0800 (PST) MIME-Version: 1.0 References: <20211109070223.76456-1-ilias.apalodimas@linaro.org> <20211109070223.76456-4-ilias.apalodimas@linaro.org> In-Reply-To: <20211109070223.76456-4-ilias.apalodimas@linaro.org> From: Simon Glass Date: Sat, 13 Nov 2021 11:15:54 -0700 Message-ID: Subject: Re: [PATCH 3/8 v7] tpm2: Introduce TIS tpm core To: Ilias Apalodimas Cc: u-boot@lists.denx.de, trini@konsulko.com, Rick Chen , Sean Anderson , Heinrich Schuchardt , Masahisa Kojima Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, 9 Nov 2021 at 00:02, Ilias Apalodimas wrote: > > There's a lot of code duplication in U-Boot right now. All the TPM TIS > compatible drivers we have at the moment have their own copy of a TIS > implementation. > > So let's create a common layer which implements the core TIS functions. > Any driver added from now own, which is compatible with the TIS spec, will > only have to provide the underlying bus communication mechanisms. > > Signed-off-by: Ilias Apalodimas > --- > drivers/tpm/tpm2_tis_core.c | 463 ++++++++++++++++++++++++++++++++++++ > drivers/tpm/tpm_tis.h | 136 +++++++++++ > include/tpm-v2.h | 1 + > 3 files changed, 600 insertions(+) > create mode 100644 drivers/tpm/tpm2_tis_core.c > Please can you add a change log to each patch? You have a vague one in the cover letter but I am left to guess how each patch has changed. Reviewed-by: Simon Glass Regards, Simon