From: Simon Glass <sjg@chromium.org>
To: Tom Rini <trini@konsulko.com>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Joe Perches" <joe@perches.com>,
"Alper Nebi Yasak" <alpernebiyasak@gmail.com>,
"Evan Benn" <evanbenn@chromium.org>,
"Marek Behún" <marek.behun@nic.cz>,
"Sean Anderson" <seanga2@gmail.com>,
"Wasim Khan" <wasim.khan@nxp.com>
Subject: Re: [PATCH v2 1/5] checkpatch: Support wide strings
Date: Mon, 2 Aug 2021 13:20:21 -0600 [thread overview]
Message-ID: <CAPnjgZ02TZsiRNNZ8sDeccFyzsLQnvZObEZXmz-tuuAghkCXag@mail.gmail.com> (raw)
In-Reply-To: <20210801032842.GJ9379@bill-the-cat>
Hi Tom,
On Sat, 31 Jul 2021 at 21:28, Tom Rini <trini@konsulko.com> wrote:
>
> On Sun, Jul 18, 2021 at 02:14:22PM -0600, Simon Glass wrote:
>
> > From: Joe Perches <joe@perches.com>
> >
> > Allow prefixing typical strings with L for wide strings and u for
> > unicode strings.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> > This was found on LKML:
> >
> > https://lore.kernel.org/lkml/1508280192.6530.31.camel@perches.com/T/
> >
> > It likely wasn't applied because it did not show up in patchwork
> > correctly, due to the patch being inline:
> >
> > https://lore.kernel.org/patchwork/patch/842121/
> >
> > In any case, it needed rebasing and updating to support 'u'.
> >
> > Heinrich, perhaps you can send this upstream since you have the context?
> >
> > Changes in v2:
> > - Add new patch to reduce checkpatch unicode-string spam
> >
> > scripts/checkpatch.pl | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
>
> I'm very much against having checkpatch.pl changes that aren't inside of
> the u_boot area. We're currently at I believe just 1 (outside of adding
> --u-boot flag) and I'm testing a resync to v5.13 now that just adds one
> more for good reason and is also obvious enough to not get lost. This
> however will get lost in a future resync so needs to be brought up with
> upstream.
I sent it upstream and Joe seems happy with it this time.
https://lore.kernel.org/patchwork/patch/1470668/
Regards,
Simon
next prev parent reply other threads:[~2021-08-02 19:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 20:14 [PATCH v2 0/5] Fix compiler warnings for 32-bit ARM Simon Glass
2021-07-18 20:14 ` [PATCH v2 1/5] checkpatch: Support wide strings Simon Glass
2021-08-01 3:28 ` Tom Rini
2021-08-02 19:20 ` Simon Glass [this message]
2021-08-02 21:30 ` Tom Rini
2021-07-18 20:14 ` [PATCH v2 2/5] pci: swap_case: Allow compilation on 32-bit machines Simon Glass
2021-07-29 16:49 ` Tom Rini
2021-07-18 20:14 ` [PATCH v2 3/5] doc: sandbox: Fix up dependencies Simon Glass
2021-07-29 16:49 ` Tom Rini
2021-07-18 20:14 ` [PATCH v2 4/5] efi: Use 16-bit unicode strings Simon Glass
2021-07-19 0:41 ` Heinrich Schuchardt
2021-07-19 1:01 ` Tom Rini
2021-07-19 1:07 ` Heinrich Schuchardt
2021-07-19 1:36 ` Tom Rini
2021-08-01 3:28 ` Tom Rini
2021-08-01 22:54 ` Simon Glass
2021-08-01 23:46 ` Tom Rini
2021-08-02 0:03 ` Simon Glass
2021-07-18 20:14 ` [PATCH v2 5/5] sandbox: Detect the host bit size automatically Simon Glass
2021-07-19 0:54 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ02TZsiRNNZ8sDeccFyzsLQnvZObEZXmz-tuuAghkCXag@mail.gmail.com \
--to=sjg@chromium.org \
--cc=alpernebiyasak@gmail.com \
--cc=evanbenn@chromium.org \
--cc=joe@perches.com \
--cc=marek.behun@nic.cz \
--cc=seanga2@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=wasim.khan@nxp.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.