From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 143EEC433F5 for ; Sun, 14 Nov 2021 00:35:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 687FC61037 for ; Sun, 14 Nov 2021 00:35:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 687FC61037 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 33997834B5; Sun, 14 Nov 2021 01:35:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="I8+7DeBA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0F94383458; Sun, 14 Nov 2021 01:34:41 +0100 (CET) Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 561D683394 for ; Sun, 14 Nov 2021 01:34:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x933.google.com with SMTP id t13so26757905uad.9 for ; Sat, 13 Nov 2021 16:34:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:from:in-reply-to:references:date:message-id :subject:to:cc:content-transfer-encoding; bh=eZG8rqQAxcwuE6TmLuJwBqjH6SqBy1ViA1jAU/Fkfc4=; b=I8+7DeBAc9FkCd8yj/meS9nNvHrrHk6hNuHmXB38xrUlCFZjo66eDbEqUUxPZ/YBtI gJBWRrbf5gUV11UB9gWlwJDPR9NbOcU45PpYRY8PpUZopmQ7xdJxw8e5JsU3JPUXGR8U WdOgcIyCn0q0skoER0TdMHygeO89Gay5nDCGk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:sender:from:in-reply-to:references :date:message-id:subject:to:cc:content-transfer-encoding; bh=eZG8rqQAxcwuE6TmLuJwBqjH6SqBy1ViA1jAU/Fkfc4=; b=oGaPD8dVfwgT2izIYUPdEwpfMYbg9Sr0c1A1dH7shIaSr6fBWta15p1Ihg/BkvniSe W87R+CA6sCAhjMKZpIctxKJ8je3jhU09As98wVUDkLCz5js5BTJGR4KtysoyTH1wxz+u 4tsvAveJ4L5bjQpC+sc6Nni9tARECD10Ps3haYR6yypsijWSTs1g3nFX3/u0L4OxgggJ TkHXjMrzIJEr8PfACb/tI2n9io3L/pTCJCo0d9lCd2ddKATDr4bHkFr5h32q5OIaGeYD 4t4g3rAHvTKuPDeO8B9EmG+yKOfgAqJ19v+PEPuzIF9n9BY8cuyBVwkiMdxYebYsvjVu 9Kog== X-Gm-Message-State: AOAM5334YCY4T7Ese3HsNzCU4SyYb3BTgYTd6846Oim2FiIhBizTyMoB ch9+2FeTSjX2iZrp6fL81u7qE4VDH35LV+2KtVCkzQ== X-Google-Smtp-Source: ABdhPJxVSkaKiTjAXIHss/BI6X8mRsbcmoC6KBHP9CsYmYOQ3T+5Fj4WjeiRpzsIg0B79xmhgHAQnhDOmmzKYaecNag= X-Received: by 2002:a67:de88:: with SMTP id r8mr25077711vsk.15.1636850074993; Sat, 13 Nov 2021 16:34:34 -0800 (PST) Received: from 480794996271 named unknown by gmailapi.google.com with HTTPREST; Sat, 13 Nov 2021 16:34:33 -0800 MIME-Version: 1.0 From: Simon Glass In-Reply-To: <20211103232332.2737-2-kabel@kernel.org> References: <20211103232332.2737-2-kabel@kernel.org> <20211103232332.2737-1-kabel@kernel.org> Date: Sat, 13 Nov 2021 16:34:33 -0800 X-Google-Sender-Auth: Op4GqOOzM0wPNecDHII4ky19uek Message-ID: Subject: Re: [PATCH v2 01/12] env: Don't set ready flag if import failed in env_set_default() To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: u-boot@lists.denx.de, =?UTF-8?B?TWFyZWsgQmVow7pu?= , Simon Glass , =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean From: Marek Beh=C3=BAn Do not set GD_FLG_ENV_READY nor GD_FLG_ENV_DEFAULT if failed importing in env_set_default(). Signed-off-by: Marek Beh=C3=BAn Reviewed-by: Simon Glass --- env/common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Applied to u-boot-dm, thanks!